From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"yskoh@mellanox.com" <yskoh@mellanox.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Date: Fri, 19 Apr 2019 17:01:40 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B435897461FF@IRSMSX101.ger.corp.intel.com> (raw)
Message-ID: <20190419170140.WUSTqxANKeqaJ9ROK8GEOTtwXC2WpSSezsdz2oNl498@z> (raw)
In-Reply-To: <CA70B6012E3ADB4184D44E025E5FF01B6A20B985@LCSMSX155.ger.corp.intel.com>
Hi Thomas et al,
> -----Original Message-----
> From: Jozwiak, TomaszX
> Sent: Friday, April 19, 2019 1:14 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; david.marchand@redhat.com;
> Trahe, Fiona <fiona.trahe@intel.com>; yskoh@mellanox.com; Cel, TomaszX <tomaszx.cel@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
[Fiona] Sorry for all the hassle. I've reviewed the related code and fix.
In my opinion the original fix was ok to resolve the compile issue, which
we missed due to using a different compiler version and also missed
spotting in code review. We'll be more careful in future.
I've sent a v3 with a small tweak to help the code clarity.
This is consistent with a bunch of other tests in same file.
next prev parent reply other threads:[~2019-04-19 17:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 9:57 Tomasz Jozwiak
2019-04-19 9:57 ` Tomasz Jozwiak
2019-04-19 10:05 ` Bruce Richardson
2019-04-19 10:05 ` Bruce Richardson
2019-04-19 10:17 ` Thomas Monjalon
2019-04-19 10:17 ` Thomas Monjalon
[not found] ` <CA70B6012E3ADB4184D44E025E5FF01B6A20A888@LCSMSX155.ger.corp.intel.com>
2019-04-19 11:25 ` Thomas Monjalon
2019-04-19 11:25 ` Thomas Monjalon
2019-04-19 11:36 ` Jozwiak, TomaszX
2019-04-19 11:36 ` Jozwiak, TomaszX
2019-04-19 11:50 ` Thomas Monjalon
2019-04-19 11:50 ` Thomas Monjalon
2019-04-19 12:14 ` Jozwiak, TomaszX
2019-04-19 12:14 ` Jozwiak, TomaszX
2019-04-19 17:01 ` Trahe, Fiona [this message]
2019-04-19 17:01 ` Trahe, Fiona
2019-04-19 10:49 ` David Marchand
2019-04-19 10:49 ` David Marchand
2019-04-19 11:45 ` [dpdk-dev] [PATCH v2] " Tomasz Jozwiak
2019-04-19 11:45 ` Tomasz Jozwiak
2019-04-19 16:52 ` [dpdk-dev] [PATCH v3] " Fiona Trahe
2019-04-19 16:52 ` Fiona Trahe
2019-04-19 21:06 ` Thomas Monjalon
2019-04-19 21:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B435897461FF@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tomaszx.jozwiak@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).