From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 740CEA00E6 for ; Fri, 19 Apr 2019 23:17:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 826011B96E; Fri, 19 Apr 2019 23:17:21 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 72CB65699; Fri, 19 Apr 2019 23:17:20 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 45C68396; Fri, 19 Apr 2019 17:17:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 17:17:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=sWiT0hmYCbg/2E4PNCTAEx+EkcUmNJwxT0scb3d+KcE=; b=pWwokYYT9FSG BHZN3S2s/G+xa+hl1+dD/3D30gsavJO/9hbiOW3CblqQFCoE5A2JQqVRBN/ISE1t JUTCKhY7BAE401TVS3c0uzCL5VFW/MU1syi3vXgix9uyNZGeaIhlzAO8ylfNk6xm mQLNXWwhGwzVL3W92FLphKCVxESoV8Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=sWiT0hmYCbg/2E4PNCTAEx+EkcUmNJwxT0scb3d+K cE=; b=WoxGZqAr6Zs85vyYXSOXwNZ5KR3Cnk8QTbEGDFd93eBMsPJMRNRyzm+NO zn6tfWhjsQ5oxQ5hOCyf8vpab3mvDyJkIO0404BnCTIkdRvpu43rLCLXuaTNyVt1 AeFw4YrtxosDwaia3Q7euXrTnf5hRRBuUJKC8Nu/5jS/SHktrgDrhb8uSQIX8Wbn W1D3axRiB4hNgAHhurmWXfwJrmSzwxSMI2HyBccx26mbmWCSWdGEpe0OHM8J3Mq7 GGhcU/CbS+I/E3rPUyuUkgM+0WamtiyYVmDytSsSAjsTPm41oVNxamZAVdSXSwC9 C8P5i6gzqyli1eJfxKqZRgdscsd8w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeekgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 647ADE415C; Fri, 19 Apr 2019 17:17:17 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, David Marchand , Pablo de Lara , dpdk stable Date: Fri, 19 Apr 2019 23:17:16 +0200 Message-ID: <2420212.y2DT3RLapi@xps> In-Reply-To: <20190419121239.GA1843@bricha3-MOBL.ger.corp.intel.com> References: <20190419120327.29752-1-bruce.richardson@intel.com> <20190419121239.GA1843@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419211716.ba_MHRxCLoGtcS2q3Wu-aTrX1k52SoEkj3FyDTCj7N4@z> 19/04/2019 14:12, Bruce Richardson: > On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote: > > nit: "test/compress:" for the title prefix ? > > maybe so, half the time I never know what to prefix autotest stuff like > this with! :-) Thomas, please fix on apply, if possible. In this case, you can just copy the prefix from the "Fixes:" line :) > > On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson > > <[1]bruce.richardson@intel.com> wrote: > > > > Build of test_compressdev.c fails on FreeBSD due to the missing > > include of unistd.h, to provide the function usleep. > > Fixes: b06aa643cac4 ("test/compress: add initial unit tests") > > Cc: [2]pablo.de.lara.guarch@intel.com > > Cc: [3]stable@dpdk.org > > Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com> > > > > Tested on FreeBSD 10.4. > > Reviewed-by: David Marchand <[5]david.marchand@redhat.com> Applied, thanks