From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 825C3A00E6 for ; Fri, 19 Apr 2019 23:18:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 544C31BBB4; Fri, 19 Apr 2019 23:18:43 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 8255E1B9F4 for ; Fri, 19 Apr 2019 23:18:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 5E45D5AF; Fri, 19 Apr 2019 17:18:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 17:18:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=C3OZPMTPkgXEG9c+ktACS3um1/Pp4cOaFZlD4WOCO7s=; b=b8cDaRTA/nik IdNEQGb1bYf7MPs0sBvPAc4nV4upKZ79hPZb8YPTI3SIplHZOGCy2iJkMfa2bh1M gWwcjX72bnHIkiLY6XjFMw2gbZAcvlKgikkQSGncuU1EZ+nEbirkRr90iS9Nsijc rBlBhQ6Dt16u9Ldev2x4FvHEfrG1Bqk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=C3OZPMTPkgXEG9c+ktACS3um1/Pp4cOaFZlD4WOCO 7s=; b=S5ul0N5kSBiz8/APjRROmKNOjDArqaaP+QQlGniZMpiejbbXPorHVCK0w Ozt91ie2FMOwJl868ljHeLd9BOXMdPY0GkkFqahDYrgJbpednDZxsxqNd/4ZKw/K dVX7DnKJDxjHiCPGwWDN1JgF0OWBD2oc1xBop7OzJcPYnIxj2uHeT5IAYSXleg4G Stl73CXcygCuiMpVfZ6spAf7LXG+vLm+ZnuGEsQ7iGM+CsCc60tWxEJP++3/vF+b qPUDGc3khI2658TpI/wfrfwPvX/Dn1iIG/f/Rxvz/Ur+b8Y0Y7AozoZE/khR5WZ+ isf34VbS1i3q5YtqUXn+Ma2KHkRJw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeekgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 507AA103C8; Fri, 19 Apr 2019 17:18:38 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Luca Boccassi , David Marchand Date: Fri, 19 Apr 2019 23:18:37 +0200 Message-ID: <5524018.aJI2RBs9e0@xps> In-Reply-To: References: <20190419120449.29883-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: fix support for plain bourne shell X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419211837.kIFr2wRPXdDmUscHSLgMe7RGs2KVlTryXAkojlwcDww@z> 19/04/2019 14:42, Luca Boccassi: > On Fri, 2019-04-19 at 13:04 +0100, Bruce Richardson wrote: > > The pipefail option is not supported in /bin/sh, just in bash/ksh and > > similar shells - which means it's there by default on most Linux > > distros > > but not on e.g. FreeBSD. Therefore we check for it's presence before > > setting the option, and if it's missing, we upgrade verbosity level > > if > > needed to ensure we never hide any build failures. > > > > Signed-off-by: Bruce Richardson < > > bruce.richardson@intel.com > > > > > --- > > This patch is a replacement for the previous patch: "fix support for > > FreeBSD" [1], which was an incorrect/incomplete fix. > > > > [1] > > http://patches.dpdk.org/patch/52468/ > > > > --- > > devtools/test-meson-builds.sh | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > Acked-by: Luca Boccassi Looks good. Applied, thanks