DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: shahafs@mellanox.com
Cc: dev@dpdk.org, viacheslavo@mellanox.com
Subject: [dpdk-dev] [PATCH] net/mlx5: fix Direct Rules build
Date: Fri, 19 Apr 2019 17:02:43 -0700	[thread overview]
Message-ID: <20190420000243.39143-1-yskoh@mellanox.com> (raw)
Message-ID: <20190420000243.mx-I-3Udp1OQI5WOp6KCp64C4XAQB4Ctka2oIjBXipQ@z> (raw)

All the library calls must be called via the glue layer.

Fixes: b2177648b8de ("net/mlx5: add Direct Rules flow data alloc/free routines")
Fixes: 79e35d0d5979 ("net/mlx5: share Direct Rules/Verbs flow related structures")
Cc: viacheslavo@mellanox.com

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
 drivers/net/mlx5/mlx5.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 65c69afe5a..08ed678d0d 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -332,14 +332,16 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv)
 		return 0;
 	}
 	/* Reference counter is zero, we should initialize structures. */
-	ns = mlx5dv_dr_create_ns(sh->ctx, MLX5DV_DR_NS_DOMAIN_INGRESS_BYPASS);
+	ns = mlx5_glue->dr_create_ns(sh->ctx,
+				     MLX5DV_DR_NS_DOMAIN_INGRESS_BYPASS);
 	if (!ns) {
 		DRV_LOG(ERR, "ingress mlx5dv_dr_create_ns failed");
 		err = errno;
 		goto error;
 	}
 	sh->rx_ns = ns;
-	ns = mlx5dv_dr_create_ns(sh->ctx, MLX5DV_DR_NS_DOMAIN_EGRESS_BYPASS);
+	ns = mlx5_glue->dr_create_ns(sh->ctx,
+				     MLX5DV_DR_NS_DOMAIN_EGRESS_BYPASS);
 	if (!ns) {
 		DRV_LOG(ERR, "egress mlx5dv_dr_create_ns failed");
 		err = errno;
@@ -367,11 +369,11 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv)
 error:
        /* Rollback the created objects. */
 	if (sh->rx_ns) {
-		mlx5dv_dr_destroy_ns(sh->rx_ns);
+		mlx5_glue->dr_destroy_ns(sh->rx_ns);
 		sh->rx_ns = NULL;
 	}
 	if (sh->tx_ns) {
-		mlx5dv_dr_destroy_ns(sh->tx_ns);
+		mlx5_glue->dr_destroy_ns(sh->tx_ns);
 		sh->tx_ns = NULL;
 	}
 	if (sh->fdb_ns) {
@@ -410,11 +412,11 @@ mlx5_free_shared_dr(struct mlx5_priv *priv)
 	if (sh->dv_refcnt && --sh->dv_refcnt)
 		return;
 	if (sh->rx_ns) {
-		mlx5dv_dr_destroy_ns(sh->rx_ns);
+		mlx5_glue->dr_destroy_ns(sh->rx_ns);
 		sh->rx_ns = NULL;
 	}
 	if (sh->tx_ns) {
-		mlx5dv_dr_destroy_ns(sh->tx_ns);
+		mlx5_glue->dr_destroy_ns(sh->tx_ns);
 		sh->tx_ns = NULL;
 	}
 #ifdef HAVE_MLX5DV_DR_ESWITCH
-- 
2.11.0


             reply	other threads:[~2019-04-20  0:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-20  0:02 Yongseok Koh [this message]
2019-04-20  0:02 ` Yongseok Koh
2019-04-22 17:46 ` Shahaf Shuler
2019-04-22 17:46   ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190420000243.39143-1-yskoh@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).