From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 70ACA1B395 for <dev@dpdk.org>; Mon, 22 Apr 2019 18:00:49 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id w25so5909169pfi.9 for <dev@dpdk.org>; Mon, 22 Apr 2019 09:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UlkwPj4XrDkyvyTrbj4LVYJTIveOtZTg1+CXsqT8FL4=; b=ZNSzJvqH2RUBk3u765dSiYcKlPWmdV2KmnxDm1dlPJJRf2R5j6VRhjYH+jIB0kqghI +dz1NybBqL+ibL4E0RvHqHaLZP7BgfHy8M8FZdiK3ehvWVDEsYSN+neDiyLVX0aUS8oX vExcao0F6ibsQQA0QOl9n/jMUlGNrMFs2Au1bo9Ka6yRQDs5ggWpIkGBcvIfj7qsgey9 wbZEGNq4uejqaWFiVAr5tIbPOkzJ3N/A9wuOZYcQlOm9iIjK6FBbmpSvOMqrQkXKAbPH Kz6hxChHdQ0YCzzRHiF2QjHRRVhdQnpPv7F8wgsjbovrN17yjekNF4bXd3rCc2J/A8uS JlZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UlkwPj4XrDkyvyTrbj4LVYJTIveOtZTg1+CXsqT8FL4=; b=LHt74O2yDGgqhM6E1GuYAdNAnc1ZvgFZ1tL/SRrMYC1FtBwu3hg5hW9K9lX8Zm0Ej4 8cKOjDbysUcVe3DSe05rNT1QEvW65UVOEoUq8rNm2JC5vK+ejnodnBX2MX1iYE+BfEww 4sFuVIYA9hxvbOrBT9AvP0/HQPf7N8J/xugeyPQP0OH13t4mrBCc9KnnDqyCM7ckkBJ9 lkTShedhcE1Aq5F1cgTnCsBElrxrqpYZsksKw0BHb/ganDW66Ci7I7GD74LvLEf6E4cQ sjr/RHexAwcOIYC09Nw4ioRhB2rf15NcCYph0ganpbdcjiWlcNdrNAMF9pecNRSdMxCE 15Mg== X-Gm-Message-State: APjAAAUon8EwLaxkIHYFyy9Rz9fuCplozLQH0k5EQlTiaBp3KbiYEbXG udy+QvpzKn35VNU1Rbyzkk+x/g== X-Google-Smtp-Source: APXvYqz0eXnPGm6JyLRG1T3LFATBhWwVDQeIQs5UoNgAgdUqqIBm2zuQpjxNrieHQkK0OJLqmrNPeA== X-Received: by 2002:a65:63c3:: with SMTP id n3mr5372410pgv.170.1555948848114; Mon, 22 Apr 2019 09:00:48 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s19sm3663424pgj.62.2019.04.22.09.00.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 09:00:47 -0700 (PDT) Date: Mon, 22 Apr 2019 09:00:45 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Olivier Matz <olivier.matz@6wind.com> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <20190422090045.695deff5@hermes.lan> In-Reply-To: <20190410083218.17531-2-olivier.matz@6wind.com> References: <20181024081833.21432-1-olivier.matz@6wind.com> <20190410083218.17531-1-olivier.matz@6wind.com> <20190410083218.17531-2-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v2 01/14] net: add rte prefix to arp structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 22 Apr 2019 16:00:49 -0000 On Wed, 10 Apr 2019 10:32:05 +0200 Olivier Matz <olivier.matz@6wind.com> wrote: > Add 'rte_' prefix to structures: > - rename struct arp_hdr as struct rte_arp_hdr. > - rename struct arp_ipv4 as struct rte_arp_ipv4. > > Also rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fields > to avoid conflict with the #defines in gnu libc. > > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> Agree that adding prefix is best way to handle rte_arp.h. Could you fix up all the checkpatch whitespace warnings on this and resubmit it as a PATCH (not RFC)? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F06DAA05D3 for <public@inbox.dpdk.org>; Mon, 22 Apr 2019 18:00:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC0F01B39A; Mon, 22 Apr 2019 18:00:50 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 70ACA1B395 for <dev@dpdk.org>; Mon, 22 Apr 2019 18:00:49 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id w25so5909169pfi.9 for <dev@dpdk.org>; Mon, 22 Apr 2019 09:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UlkwPj4XrDkyvyTrbj4LVYJTIveOtZTg1+CXsqT8FL4=; b=ZNSzJvqH2RUBk3u765dSiYcKlPWmdV2KmnxDm1dlPJJRf2R5j6VRhjYH+jIB0kqghI +dz1NybBqL+ibL4E0RvHqHaLZP7BgfHy8M8FZdiK3ehvWVDEsYSN+neDiyLVX0aUS8oX vExcao0F6ibsQQA0QOl9n/jMUlGNrMFs2Au1bo9Ka6yRQDs5ggWpIkGBcvIfj7qsgey9 wbZEGNq4uejqaWFiVAr5tIbPOkzJ3N/A9wuOZYcQlOm9iIjK6FBbmpSvOMqrQkXKAbPH Kz6hxChHdQ0YCzzRHiF2QjHRRVhdQnpPv7F8wgsjbovrN17yjekNF4bXd3rCc2J/A8uS JlZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UlkwPj4XrDkyvyTrbj4LVYJTIveOtZTg1+CXsqT8FL4=; b=LHt74O2yDGgqhM6E1GuYAdNAnc1ZvgFZ1tL/SRrMYC1FtBwu3hg5hW9K9lX8Zm0Ej4 8cKOjDbysUcVe3DSe05rNT1QEvW65UVOEoUq8rNm2JC5vK+ejnodnBX2MX1iYE+BfEww 4sFuVIYA9hxvbOrBT9AvP0/HQPf7N8J/xugeyPQP0OH13t4mrBCc9KnnDqyCM7ckkBJ9 lkTShedhcE1Aq5F1cgTnCsBElrxrqpYZsksKw0BHb/ganDW66Ci7I7GD74LvLEf6E4cQ sjr/RHexAwcOIYC09Nw4ioRhB2rf15NcCYph0ganpbdcjiWlcNdrNAMF9pecNRSdMxCE 15Mg== X-Gm-Message-State: APjAAAUon8EwLaxkIHYFyy9Rz9fuCplozLQH0k5EQlTiaBp3KbiYEbXG udy+QvpzKn35VNU1Rbyzkk+x/g== X-Google-Smtp-Source: APXvYqz0eXnPGm6JyLRG1T3LFATBhWwVDQeIQs5UoNgAgdUqqIBm2zuQpjxNrieHQkK0OJLqmrNPeA== X-Received: by 2002:a65:63c3:: with SMTP id n3mr5372410pgv.170.1555948848114; Mon, 22 Apr 2019 09:00:48 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s19sm3663424pgj.62.2019.04.22.09.00.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 09:00:47 -0700 (PDT) Date: Mon, 22 Apr 2019 09:00:45 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Olivier Matz <olivier.matz@6wind.com> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <20190422090045.695deff5@hermes.lan> In-Reply-To: <20190410083218.17531-2-olivier.matz@6wind.com> References: <20181024081833.21432-1-olivier.matz@6wind.com> <20190410083218.17531-1-olivier.matz@6wind.com> <20190410083218.17531-2-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v2 01/14] net: add rte prefix to arp structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190422160045.pfX4GTW-P_IiHHkE7KN5JfkUobpbyvC3r_-a0Y-hwQQ@z> On Wed, 10 Apr 2019 10:32:05 +0200 Olivier Matz <olivier.matz@6wind.com> wrote: > Add 'rte_' prefix to structures: > - rename struct arp_hdr as struct rte_arp_hdr. > - rename struct arp_ipv4 as struct rte_arp_ipv4. > > Also rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fields > to avoid conflict with the #defines in gnu libc. > > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> Agree that adding prefix is best way to handle rte_arp.h. Could you fix up all the checkpatch whitespace warnings on this and resubmit it as a PATCH (not RFC)?