Re: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable

["Rao, Nikhil" <nikhil.rao@intel.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 3693 bytes --]



> -----Original Message-----
> From: jerinj@marvell.com [mailto:jerinj@marvell.com]
> Sent: Friday, April 19, 2019 5:41 PM
> To: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> <jerinj@marvell.com>; Mattias Rönnblom
> <mattias.ronnblom@ericsson.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; Rao, Nikhil <nikhil.rao@intel.com>;
> Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: pbhagavatula@marvell.com; hemant.agrawal@nxp.com;
> nipun.gupta@nxp.com; Ma, Liang J <liang.j.ma@intel.com>
> Subject: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as
> stable
> 
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Promote the adapter functions and rte_event_port_unlinks_in_progress()
> as stable as it's been added for a while now and multiple drivers and test
> application like test-eventdev has been tested using the adapter APIs.
> 
> Cc: nikhil.rao@intel.com
> Cc: erik.g.carrillo@intel.com
> Cc: abhinandan.gujjar@intel.com
> Cc: pbhagavatula@marvell.com
> Cc: hemant.agrawal@nxp.com
> Cc: nipun.gupta@nxp.com
> Cc: harry.van.haaren@intel.com
> Cc: mattias.ronnblom@ericsson.com
> Cc: liang.j.ma@intel.com
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> 
> allow experimental api still set to true for following drivers.
> 
> drivers/event/sw - due to usage of rte_service_may_be_active() API
> drivers/event/dpaa[2] - due to usage of rte_mem_iova2virt() API
> 
> 
> v2:
> - Remove  @warning  EXPERIMENTAL from API(Erik)
> 
> ---
>  MAINTAINERS                                   |  8 +-
>  app/test-eventdev/Makefile                    |  1 -
>  app/test-eventdev/meson.build                 |  1 -
>  drivers/event/dsw/Makefile                    |  1 -
>  drivers/event/dsw/meson.build                 |  1 -
>  drivers/event/octeontx/Makefile               |  1 -
>  drivers/event/octeontx/meson.build            |  1 -
>  examples/eventdev_pipeline/Makefile           |  2 -
>  examples/eventdev_pipeline/meson.build        |  1 -
>  .../rte_event_crypto_adapter.c                | 22 ++---
>  .../rte_event_crypto_adapter.h                | 73 +++-------------
>  .../rte_event_eth_rx_adapter.h                | 50 +----------
>  .../rte_event_eth_tx_adapter.c                | 22 ++---
>  .../rte_event_eth_tx_adapter.h                | 76 ++++-------------
>  lib/librte_eventdev/rte_event_timer_adapter.c | 20 ++---
> lib/librte_eventdev/rte_event_timer_adapter.h | 83 +++----------------
>  lib/librte_eventdev/rte_eventdev.c            |  8 +-
>  lib/librte_eventdev/rte_eventdev.h            | 14 +---
>  lib/librte_eventdev/rte_eventdev_version.map  |  4 +-
>  19 files changed, 85 insertions(+), 304 deletions(-)
> 
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
>   * Register callback to process Rx packets, this is supported for
>   * SW based packet transfers.
>   * @see rte_event_eth_rx_cb_fn
> @@ -501,7 +453,7 @@ int
> rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id);
>   *  - 0: Success
>   *  - <0: Error code on failure.
>   */
> -int __rte_experimental
> +int
>  rte_event_eth_rx_adapter_cb_register(uint8_t id,
>  				uint16_t eth_dev_id,
>  				rte_event_eth_rx_adapter_cb_fn cb_fn, 

Sorry for the delay in reply, I would like to retain the rte_event_eth_rx_adapter_cb_register() function as experimental. 
I will be posting a patch for this function to accept events instead of mbufs.

Since Thomas just applied the patch, should I be posting a new patch that reverts the lines above ?

Nikhil