From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0FA30A05D3 for ; Mon, 22 Apr 2019 13:33:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8F5C1B46B; Mon, 22 Apr 2019 13:32:59 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 78DD11B46A for ; Mon, 22 Apr 2019 13:32:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Apr 2019 04:32:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,381,1549958400"; d="scan'208";a="142586354" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga008.fm.intel.com with ESMTP; 22 Apr 2019 04:32:57 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 22 Apr 2019 04:32:56 -0700 Received: from orsmsx122.amr.corp.intel.com ([169.254.11.68]) by ORSMSX116.amr.corp.intel.com ([169.254.7.36]) with mapi id 14.03.0415.000; Mon, 22 Apr 2019 04:32:56 -0700 From: "Rao, Nikhil" To: "jerinj@marvell.com" , "dev@dpdk.org" , Thomas Monjalon , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "Van Haaren, Harry" , "Gujjar, Abhinandan S" , "Carrillo, Erik G" CC: "pbhagavatula@marvell.com" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" Thread-Topic: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable Thread-Index: AQHU9qj1DAoTbGWAEkyNhSfYH6C14aZID10Q Date: Mon, 22 Apr 2019 11:32:56 +0000 Message-ID: <1F668163772FA946975B9466A9DFF729EDDFE270@ORSMSX122.amr.corp.intel.com> References: <20190418120538.16020-1-jerinj@marvell.com> <20190419121040.37227-1-jerinj@marvell.com> In-Reply-To: <20190419121040.37227-1-jerinj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjc3NmVkMzYtZjNiMS00Yzc0LWE2OGItYjY2OWY5NjQ2ZTUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVnh3RmRaZThFNTNSTE5RWXRhU0U1TlUyRGxCa0pkdDhRZ1Q2b0taQnEyaHBOcXNxdzRDTTh5MGlsbERxR211eCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422113256.Tr1LBs4EcotLflZzhvwoqVDh1FPNEhJRWnkPvRc9qRo@z> > -----Original Message----- > From: jerinj@marvell.com [mailto:jerinj@marvell.com] > Sent: Friday, April 19, 2019 5:41 PM > To: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > ; Mattias R=F6nnblom > ; Van Haaren, Harry > ; Gujjar, Abhinandan S > ; Rao, Nikhil ; > Carrillo, Erik G > Cc: pbhagavatula@marvell.com; hemant.agrawal@nxp.com; > nipun.gupta@nxp.com; Ma, Liang J > Subject: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as > stable >=20 > From: Jerin Jacob >=20 > Promote the adapter functions and rte_event_port_unlinks_in_progress() > as stable as it's been added for a while now and multiple drivers and tes= t > application like test-eventdev has been tested using the adapter APIs. >=20 > Cc: nikhil.rao@intel.com > Cc: erik.g.carrillo@intel.com > Cc: abhinandan.gujjar@intel.com > Cc: pbhagavatula@marvell.com > Cc: hemant.agrawal@nxp.com > Cc: nipun.gupta@nxp.com > Cc: harry.van.haaren@intel.com > Cc: mattias.ronnblom@ericsson.com > Cc: liang.j.ma@intel.com >=20 > Signed-off-by: Jerin Jacob > --- >=20 > allow experimental api still set to true for following drivers. >=20 > drivers/event/sw - due to usage of rte_service_may_be_active() API > drivers/event/dpaa[2] - due to usage of rte_mem_iova2virt() API >=20 >=20 > v2: > - Remove @warning EXPERIMENTAL from API(Erik) >=20 > --- > MAINTAINERS | 8 +- > app/test-eventdev/Makefile | 1 - > app/test-eventdev/meson.build | 1 - > drivers/event/dsw/Makefile | 1 - > drivers/event/dsw/meson.build | 1 - > drivers/event/octeontx/Makefile | 1 - > drivers/event/octeontx/meson.build | 1 - > examples/eventdev_pipeline/Makefile | 2 - > examples/eventdev_pipeline/meson.build | 1 - > .../rte_event_crypto_adapter.c | 22 ++--- > .../rte_event_crypto_adapter.h | 73 +++------------- > .../rte_event_eth_rx_adapter.h | 50 +---------- > .../rte_event_eth_tx_adapter.c | 22 ++--- > .../rte_event_eth_tx_adapter.h | 76 ++++------------- > lib/librte_eventdev/rte_event_timer_adapter.c | 20 ++--- > lib/librte_eventdev/rte_event_timer_adapter.h | 83 +++---------------- > lib/librte_eventdev/rte_eventdev.c | 8 +- > lib/librte_eventdev/rte_eventdev.h | 14 +--- > lib/librte_eventdev/rte_eventdev_version.map | 4 +- > 19 files changed, 85 insertions(+), 304 deletions(-) >=20 > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice > - * > * Register callback to process Rx packets, this is supported for > * SW based packet transfers. > * @see rte_event_eth_rx_cb_fn > @@ -501,7 +453,7 @@ int > rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id)= ; > * - 0: Success > * - <0: Error code on failure. > */ > -int __rte_experimental > +int > rte_event_eth_rx_adapter_cb_register(uint8_t id, > uint16_t eth_dev_id, > rte_event_eth_rx_adapter_cb_fn cb_fn,=20 Sorry for the delay in reply, I would like to retain the rte_event_eth_rx_a= dapter_cb_register() function as experimental.=20 I will be posting a patch for this function to accept events instead of mbu= fs. Since Thomas just applied the patch, should I be posting a new patch that r= everts the lines above ? Nikhil