From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7E430A05D3 for ; Mon, 22 Apr 2019 14:52:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D4C61B47A; Mon, 22 Apr 2019 14:52:45 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8F4341B461 for ; Mon, 22 Apr 2019 14:52:43 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3MCpAZL028948; Mon, 22 Apr 2019 05:52:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=SDvvfWEDnM5Osu4NlxyDZt7ZlkH+qvboLP3vLi6edqU=; b=RALrkYfFzYPpt53WkGbjBSYj96cS4YpYkOrjvnZwSdeBryXHRmSW6yKpD5PPj0pGVbFj 9liLjf2Hc20LxPz75xMq80Wty9SIm4kDu6dZ9uAtEbrU1huJMQ6TC1vBUX6FDplhs4sm qRJF6KUcXtCw91TbSTV7Cm8vSnRkR14y5vVckIseO7ljMNusyLxd4VdChqQcQ4yCzKW8 uw1Fw5FZ2cNTmo0OPmWyJXhbKFQkacO6uaAKI5rAgpjMcHmPK9dM8R4l3D1ZLX9ruEAx 6TyQfArKWk0Pcg49s784PmAtiZsTmdDan9WXjFefNsTrO6GkvgZ9Zney6Av+ZnEXz1NY LQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2s0tjratmj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 Apr 2019 05:52:42 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 22 Apr 2019 05:52:41 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.58) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 22 Apr 2019 05:52:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SDvvfWEDnM5Osu4NlxyDZt7ZlkH+qvboLP3vLi6edqU=; b=XceOMQZ3yqdAdRKQQaaLQ/OMGcoMvF4Unifsur9DGJhg6mxXTAZBfNBUfPEvaQcDUIcuoIni14rZf/HnEev98kbGTHXAwxiXPC2AndJE5vG8ytdGhliulvceP95IjxzQQdLUqbc5+UNDq+yOz7xOYYbJCBMdV0HXXQs2bkZuTZI= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB1908.namprd18.prod.outlook.com (10.161.153.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 12:52:36 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::20c9:bb0e:2024:6af]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::20c9:bb0e:2024:6af%5]) with mapi id 15.20.1813.017; Mon, 22 Apr 2019 12:52:36 +0000 From: Shally Verma To: Anoob Joseph , Ayuj Verma , "akhil.goyal@nxp.com" , "arkadiuszx.kusztal@intel.com" , "fiona.trahe@intel.com" CC: Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" , Ayuj Verma Thread-Topic: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers Thread-Index: AQHU9Zr1D2H+wNWksUGRsWr70/DXuqZIJ4Ow Date: Mon, 22 Apr 2019 12:52:36 +0000 Message-ID: References: <1555052602-19155-1-git-send-email-ayverma@marvell.com> <1555052602-19155-2-git-send-email-ayverma@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ccd85f27-0f4e-423d-4705-08d6c721652f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BN6PR1801MB1908; x-ms-traffictypediagnostic: BN6PR1801MB1908: x-microsoft-antispam-prvs: x-forefront-prvs: 00159D1518 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(366004)(396003)(39850400004)(346002)(189003)(199004)(13464003)(6246003)(53936002)(6436002)(7696005)(25786009)(2201001)(229853002)(3846002)(71190400001)(6116002)(2906002)(55016002)(107886003)(99286004)(4326008)(9686003)(52536014)(66446008)(5660300002)(66556008)(2501003)(76116006)(64756008)(14454004)(66476007)(71200400001)(14444005)(256004)(66946007)(26005)(55236004)(110136005)(73956011)(54906003)(102836004)(7736002)(66066001)(305945005)(316002)(53546011)(33656002)(76176011)(6506007)(81166006)(97736004)(86362001)(74316002)(81156014)(11346002)(476003)(68736007)(486006)(446003)(8936002)(186003)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB1908; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Kih/ZZ+oUwAZYH9XAG+lSmQY1Fixqxsdmxh9JbUK0PTVaqZsshLXJ7BGLG4C1KHIPEJQ3YjdBoHZ31z19Ta/yEsVcC4m1RU6p+Yf5p5ZjLatjjZrcdxWyELa0eKA3u2t1cnWnhk22ItEvw/kmE77jr493vKHzZjQuxF/iUb57QVVmVVGjxcWetXZIW6Tvlj7tUka7I1Om2tv0keFnHnK9RUZsoNk+9yhsliuvmO/D2H3rIh0imihnD0O5n0q/QPksXRKTiONs5+hMKZ6L64ExoC8tfj31/KZ114F7QxAj2MnQn+vZuiiA3TWSLlkcZDEA5EmjlJSHb6ZYja265YwC058iuCNqrSilhc2w5daDWVg6CRB3MsQnB6l0Xly8n9rWd+LxvEzEfg64Afquido+qyDQS8BgFU4+kxeSjsj2Mo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ccd85f27-0f4e-423d-4705-08d6c721652f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2019 12:52:36.3368 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB1908 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-21_08:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422125236.LfRKSifGlrNbSCkkbVVf6tiEjckpQWCKFdTYKzFyra0@z> Hi Anoob > -----Original Message----- > From: Anoob Joseph > Sent: Thursday, April 18, 2019 9:28 AM > To: Ayuj Verma ; akhil.goyal@nxp.com; > arkadiuszx.kusztal@intel.com; fiona.trahe@intel.com > Cc: Shally Verma ; Sunila Sahu ; > Kanaka Durga Kotamarthy ; Arvind Desai > ; dev@dpdk.org; Ayuj Verma > > Subject: RE: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering = of > headers >=20 > Hi Ayuj, Akhil, Fiona, Shally, >=20 > I think there are couple of issues with this patch. The real issue here i= s the > dependency of rte_crypto_asym.h on rte_crypto_sym.h. If > rte_crypto_asym.h doesn't include all the headers it uses, every file whi= ch > includes rte_crypto_asym.h will have to include rte_crypto_asym.h's > dependencies, which is not the right practice. Keeping it alphabetical et= c > comes later. [Shally] We can change title something to "include dependencies into asym h= eader files" , but then should I assume that You agree to this patch? >=20 > So the patch has to be rephrased to better reflect the purpose. >=20 > Also please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: dev On Behalf Of Ayuj Verma > > Sent: Friday, April 12, 2019 12:33 PM > > To: akhil.goyal@nxp.com; arkadiuszx.kusztal@intel.com; > > fiona.trahe@intel.com > > Cc: Shally Verma ; Sunila Sahu > > ; Kanaka Durga Kotamarthy > > ; Arvind Desai ; > > dev@dpdk.org; Ayuj Verma > > Subject: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering > > of headers > > > > include rte_crypto_sym.h in rte_crypto_asym.h in place of including it > > in rte_crypto.h. > > > > Signed-off-by: Ayuj Verma > > Signed-off-by: Shally Verma > > > > --- > > lib/librte_cryptodev/rte_crypto.h | 1 - > > lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_cryptodev/rte_crypto.h > > b/lib/librte_cryptodev/rte_crypto.h > > index fd5ef3a..17dccdf 100644 > > --- a/lib/librte_cryptodev/rte_crypto.h > > +++ b/lib/librte_cryptodev/rte_crypto.h > > @@ -22,7 +22,6 @@ > > #include > > #include > > > > -#include "rte_crypto_sym.h" > > #include "rte_crypto_asym.h" >=20 > [Anoob] If rte_crypto.h uses anything defined in rte_crypto_sym.h, then y= ou > cannot remove the include.=20 [Shally] so you mean we should do #include of sym.h in both, this and rte_c= rypto_asym.h file? >You can make it alphabetical, but the include has to be retained. [Shally] Sorry didn't get what you exactly mean by this? Thanks Shally >=20 > > > > /** Crypto operation types */ > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > > b/lib/librte_cryptodev/rte_crypto_asym.h > > index 5e43620..a55923a 100644 > > --- a/lib/librte_cryptodev/rte_crypto_asym.h > > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > > @@ -25,6 +25,8 @@ > > #include > > #include > > > > +#include "rte_crypto_sym.h" > > + > > typedef struct rte_crypto_param_t { > > uint8_t *data; > > /**< pointer to buffer holding data */ > > -- > > 1.8.3.1