From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 8E628A05D3
for <public@inbox.dpdk.org>; Mon, 22 Apr 2019 18:03:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 2A73E32A5;
Mon, 22 Apr 2019 18:03:32 +0200 (CEST)
Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com
[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id ADA632BB1
for <dev@dpdk.org>; Mon, 22 Apr 2019 18:03:30 +0200 (CEST)
Received: by mail-pg1-f195.google.com with SMTP id v2so3632127pge.13
for <dev@dpdk.org>; Mon, 22 Apr 2019 09:03:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=94SQZzLD0hW+A67wK06d0DWmnln/lj/kaqkrtB04Xxw=;
b=y+vQLr9756cB0/dy1i12NbMZ8CE0m4v6jDY9RiLKsxoc8YWMI5SzZAqDa8a3lwQuAC
ReeHq0WXHI+bOsVi0FU7u5VGLX+mlaWJs4etEkmRdGRRfRo+lmsXeRHpnWjexRaRIm0l
zdhWXuyEySlG0XBbIjOg1vcnqiP4UE/ly4gTc4KC2oPResAP2WdY3ZGzlQ2R4NtWtMf2
zFVjpzBlsIg/vm8lszaEv+2YgThNMHEts0VCiK9TjtpIiNqEbK1bGIz42fFof6sFwGlc
OrCtFXdzCq8x5v91eYORDqRo0t0861OB9EEw9Q68/SBnsaE/pvLgclk6UvlnK7qe8NL0
g8yg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=94SQZzLD0hW+A67wK06d0DWmnln/lj/kaqkrtB04Xxw=;
b=P2At5cKgJEJl8IhRZgHXOPZl+HEUmESm+ZG3KFMmpn50KyutKIJnfbl9b7paV0Rvj/
/Sc6O5OfJQ/FDcslKymK1kl3zAkYvSPLu91NAbLpC8FWn2aAPuUxhU8Mr8SxK+Kcg9Em
U7zok8sZ3pPfitFnIYf9ysJZG6QXXXtNLwYTwUp2vGsnh+nQOLpos8d6dxdSW2KWTNGW
nKYBcAFHmr49BKf3fB/XJ65ynasKmbXvVcJFeUSijHmo0JmpBXNS3A9RNp1aN9cDE9oC
P0caVWzDHePVbbPZ5DL0pqLU0Gli4+EaHwECsL3umNNg1z7SqBR7XOoUjdSDF/QUxsQG
xJAA==
X-Gm-Message-State: APjAAAVA2sDSlRkonOC2J1CyB46BVGfI+JPfCjZxD3hTPfeCEs1JI3fb
vOq9jW4AAkI6hN4gqGrB6k/LwA==
X-Google-Smtp-Source: APXvYqzUEoZ90PaJtW4ZkSCacmIB0DUqg3uNmPMvtpDhEd4p3edIXdpIvR0tatLw2UHZlenbOBhAZg==
X-Received: by 2002:a65:62cc:: with SMTP id m12mr19802815pgv.118.1555949009719;
Mon, 22 Apr 2019 09:03:29 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id x9sm19669095pfn.60.2019.04.22.09.03.29
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Mon, 22 Apr 2019 09:03:29 -0700 (PDT)
Date: Mon, 22 Apr 2019 09:03:27 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <20190422090327.6fef2599@hermes.lan>
In-Reply-To: <20190410083218.17531-2-olivier.matz@6wind.com>
References: <20181024081833.21432-1-olivier.matz@6wind.com>
<20190410083218.17531-1-olivier.matz@6wind.com>
<20190410083218.17531-2-olivier.matz@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC v2 01/14] net: add rte prefix to arp structures
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190422160327.FvzrcDiR1rjh4yfU-k8AEPM9PS7-6KBGgDQ_itUM7sU@z>
On Wed, 10 Apr 2019 10:32:05 +0200
Olivier Matz <olivier.matz@6wind.com> wrote:
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index f30422a6d..9c5425ef5 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -489,9 +489,9 @@ uint32_t burstnumberTX;
> #ifdef RTE_LIBRTE_BOND_DEBUG_ALB
>
> static void
> -arp_op_name(uint16_t arp_op, char *buf, size_t buf_len)
> +arp_opcode_name(uint16_t arp_opcode, char *buf, size_t buf_len)
> {
> - switch (arp_op) {
> + switch (arp_opcode) {
> case ARP_OP_REQUEST:
> strlcpy(buf, "ARP Request", buf_len);
> return;
> @@ -566,7 +566,7 @@ update_cli
This is an internal function, why did it have to be renamed?
> diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h
> index cf6ef63e3..f988e74c6 100644
> --- a/drivers/net/i40e/base/i40e_adminq_cmd.h
> +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h
> @@ -458,7 +458,7 @@ struct i40e_aqc_cppm_configuration {
> I40E_CHECK_CMD_LENGTH(i40e_aqc_cppm_configuration);
>
> /* Set ARP Proxy command / response (indirect 0x0104) */
> -struct i40e_aqc_arp_proxy_data {
> +struct i40e_aqc_arp_protocolxy_data {
> __le16 command_flags;
Don't change private data or function names in base code.