From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1CB29A05D3 for ; Mon, 22 Apr 2019 19:37:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0988A1B442; Mon, 22 Apr 2019 19:37:20 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3A54E1B439 for ; Mon, 22 Apr 2019 19:37:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 807962206E; Mon, 22 Apr 2019 13:37:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 13:37:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=8hw8NAPklssNjgiTunyvPKDJlWyMP3TpWOvYWKX8iiU=; b=Kby5c1e1Tuq9 SMkhbRn2orZA52hgey9gT9yDFNiiX1r3TAeLAWaCg9QJrfLsynht1d6LjFj/Cd5q eUBlI6mT/IkDdBOx3JR6dvr29SiKy/seolwsRdu3gWw/ZWen06cbKBmFb6+xns5C CyASBarSPp8UI0VpiuEcHD4YvINZ8tc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=8hw8NAPklssNjgiTunyvPKDJlWyMP3TpWOvYWKX8i iU=; b=GxlKAzAu5Dh7Obe6h6SANjkTQykjTCKGX052tJAbF7HLbD2qUycoEv71M DIRI3UY3EjPfnsNjIMVqC+3yzWHF4uZ2YPlr0uad8QHP5U23xr4Izn01DCXZHLZL c5Y9ZlbOv/A3bubZx4irqvAwux4Oi2DvORY6UTZBAqHZxRC2k60QGoz1MOPc8RGF xYoGXQ+uJlLTViM7/C1HsKO7b9WNrviClswUJYfTMBSDap8y+WN2czHU51Hi3R5i CxLcsUGo+DHkrYGvVS1cx3nqra4lpMlCHzbsSJU9R1BRuVNUGaw2HBYDj2prZk+u hKQ8m7flh0CbqduCUPYufsyLtcaBA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeekfedrudduhedrudehhedrudefkeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id A3FB5103CD; Mon, 22 Apr 2019 13:37:15 -0400 (EDT) From: Thomas Monjalon To: "Richardson, Bruce" Cc: dev@dpdk.org, "Iremonger, Bernard" Date: Mon, 22 Apr 2019 19:37:11 +0200 Message-ID: <3767090.2uHt9PEC52@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D87B7B@IRSMSX108.ger.corp.intel.com> References: <20190410112447.68386-1-bruce.richardson@intel.com> <8CEF83825BEC744B83065625E567D7C260D87B7B@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] reorder: add checks for invalid function inputs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422173711.VzwBrdihFZSx3oHEL8I5x3DTOFBSlKtZdt1uCWVByfQ@z> > > For APIs which can return an error value, do sanity checking of the input > > parameters for NULL and return a suitable error value for those cases. > > > > NOTE: The drain function is currently omitting NULL checks too, but this > > function has no way to flag an error value, so checking in that case would > > simply mask problems. > > > > Reported-by: Bernard Iremonger > > Signed-off-by: Bruce Richardson > > Acked-by: Bernard Iremonger Applied, thanks