* [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group
@ 2019-04-14 20:18 Ori Kam
2019-04-14 20:18 ` Ori Kam
2019-04-16 23:07 ` Yongseok Koh
0 siblings, 2 replies; 6+ messages in thread
From: Ori Kam @ 2019-04-14 20:18 UTC (permalink / raw)
To: yskoh, shahafs; +Cc: dev, orika
the flow group should be initialized.
For example selecting if the encapsulation is for root or private tables
is based on the flow->group value.
Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
Signed-off-by: Ori Kam <orika@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 3862b26..82e8749 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] = {
union flow_dv_attr flow_attr = { .attr = 0 };
struct mlx5_flow_dv_tag_resource tag_resource;
+ flow->group = attr->group;
if (priority == MLX5_FLOW_PRIO_RSVD)
priority = priv->config.flow_prio - 1;
for (; !actions_end ; actions++) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group
2019-04-14 20:18 [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group Ori Kam
@ 2019-04-14 20:18 ` Ori Kam
2019-04-16 23:07 ` Yongseok Koh
1 sibling, 0 replies; 6+ messages in thread
From: Ori Kam @ 2019-04-14 20:18 UTC (permalink / raw)
To: yskoh, shahafs; +Cc: dev, orika
the flow group should be initialized.
For example selecting if the encapsulation is for root or private tables
is based on the flow->group value.
Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
Signed-off-by: Ori Kam <orika@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 3862b26..82e8749 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] = {
union flow_dv_attr flow_attr = { .attr = 0 };
struct mlx5_flow_dv_tag_resource tag_resource;
+ flow->group = attr->group;
if (priority == MLX5_FLOW_PRIO_RSVD)
priority = priv->config.flow_prio - 1;
for (; !actions_end ; actions++) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group
2019-04-14 20:18 [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group Ori Kam
2019-04-14 20:18 ` Ori Kam
@ 2019-04-16 23:07 ` Yongseok Koh
2019-04-16 23:07 ` Yongseok Koh
2019-04-22 17:45 ` Shahaf Shuler
1 sibling, 2 replies; 6+ messages in thread
From: Yongseok Koh @ 2019-04-16 23:07 UTC (permalink / raw)
To: Ori Kam; +Cc: Shahaf Shuler, dev
On Sun, Apr 14, 2019 at 08:18:55PM +0000, Ori Kam wrote:
> the flow group should be initialized.
> For example selecting if the encapsulation is for root or private tables
> is based on the flow->group value.
>
> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
>
> Signed-off-by: Ori Kam <orika@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
> drivers/net/mlx5/mlx5_flow_dv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
> index 3862b26..82e8749 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] = {
> union flow_dv_attr flow_attr = { .attr = 0 };
> struct mlx5_flow_dv_tag_resource tag_resource;
>
> + flow->group = attr->group;
> if (priority == MLX5_FLOW_PRIO_RSVD)
> priority = priv->config.flow_prio - 1;
> for (; !actions_end ; actions++) {
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group
2019-04-16 23:07 ` Yongseok Koh
@ 2019-04-16 23:07 ` Yongseok Koh
2019-04-22 17:45 ` Shahaf Shuler
1 sibling, 0 replies; 6+ messages in thread
From: Yongseok Koh @ 2019-04-16 23:07 UTC (permalink / raw)
To: Ori Kam; +Cc: Shahaf Shuler, dev
On Sun, Apr 14, 2019 at 08:18:55PM +0000, Ori Kam wrote:
> the flow group should be initialized.
> For example selecting if the encapsulation is for root or private tables
> is based on the flow->group value.
>
> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
>
> Signed-off-by: Ori Kam <orika@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
> drivers/net/mlx5/mlx5_flow_dv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
> index 3862b26..82e8749 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] = {
> union flow_dv_attr flow_attr = { .attr = 0 };
> struct mlx5_flow_dv_tag_resource tag_resource;
>
> + flow->group = attr->group;
> if (priority == MLX5_FLOW_PRIO_RSVD)
> priority = priv->config.flow_prio - 1;
> for (; !actions_end ; actions++) {
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group
2019-04-16 23:07 ` Yongseok Koh
2019-04-16 23:07 ` Yongseok Koh
@ 2019-04-22 17:45 ` Shahaf Shuler
2019-04-22 17:45 ` Shahaf Shuler
1 sibling, 1 reply; 6+ messages in thread
From: Shahaf Shuler @ 2019-04-22 17:45 UTC (permalink / raw)
To: Yongseok Koh, Ori Kam; +Cc: dev
Wednesday, April 17, 2019 2:08 AM, Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: fix missing init for flow group
>
> On Sun, Apr 14, 2019 at 08:18:55PM +0000, Ori Kam wrote:
> > the flow group should be initialized.
> > For example selecting if the encapsulation is for root or private
> > tables is based on the flow->group value.
> >
> > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
> >
> > Signed-off-by: Ori Kam <orika@mellanox.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
>
> > drivers/net/mlx5/mlx5_flow_dv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> > b/drivers/net/mlx5/mlx5_flow_dv.c index 3862b26..82e8749 100644
> > --- a/drivers/net/mlx5/mlx5_flow_dv.c
> > +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> > @@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] = {
> > union flow_dv_attr flow_attr = { .attr = 0 };
> > struct mlx5_flow_dv_tag_resource tag_resource;
> >
> > + flow->group = attr->group;
> > if (priority == MLX5_FLOW_PRIO_RSVD)
> > priority = priv->config.flow_prio - 1;
> > for (; !actions_end ; actions++) {
> > --
> > 1.8.3.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group
2019-04-22 17:45 ` Shahaf Shuler
@ 2019-04-22 17:45 ` Shahaf Shuler
0 siblings, 0 replies; 6+ messages in thread
From: Shahaf Shuler @ 2019-04-22 17:45 UTC (permalink / raw)
To: Yongseok Koh, Ori Kam; +Cc: dev
Wednesday, April 17, 2019 2:08 AM, Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: fix missing init for flow group
>
> On Sun, Apr 14, 2019 at 08:18:55PM +0000, Ori Kam wrote:
> > the flow group should be initialized.
> > For example selecting if the encapsulation is for root or private
> > tables is based on the flow->group value.
> >
> > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
> >
> > Signed-off-by: Ori Kam <orika@mellanox.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
>
> > drivers/net/mlx5/mlx5_flow_dv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> > b/drivers/net/mlx5/mlx5_flow_dv.c index 3862b26..82e8749 100644
> > --- a/drivers/net/mlx5/mlx5_flow_dv.c
> > +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> > @@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] = {
> > union flow_dv_attr flow_attr = { .attr = 0 };
> > struct mlx5_flow_dv_tag_resource tag_resource;
> >
> > + flow->group = attr->group;
> > if (priority == MLX5_FLOW_PRIO_RSVD)
> > priority = priv->config.flow_prio - 1;
> > for (; !actions_end ; actions++) {
> > --
> > 1.8.3.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-22 17:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-14 20:18 [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group Ori Kam
2019-04-14 20:18 ` Ori Kam
2019-04-16 23:07 ` Yongseok Koh
2019-04-16 23:07 ` Yongseok Koh
2019-04-22 17:45 ` Shahaf Shuler
2019-04-22 17:45 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).