From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 9E71FA05D3
for <public@inbox.dpdk.org>; Mon, 22 Apr 2019 22:55:26 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 5FE631B440;
Mon, 22 Apr 2019 22:55:25 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1E0AB559A
for <dev@dpdk.org>; Mon, 22 Apr 2019 22:55:24 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id A370321AC2;
Mon, 22 Apr 2019 16:55:23 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Mon, 22 Apr 2019 16:55:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=pSCBUM1KDWtttk+GteOlAHU2MhTFAr12PHQhCMUr1yQ=; b=JU99G4JKZmcF
Q5Z+CoDHZTSdQ3W5ajT6sG8IZh2rHmEquUtQ73xmFiipw3eIqcuzsm7Or6AMYAjS
QPkHScSR4pseL4bBA+dRLnKHtx1xP7EthJMsEETCmALGiIYKAW3jmK5kKmI8Ksyw
l4mry7VoN2vckmCv0E+ajNGZqLAB05k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=pSCBUM1KDWtttk+GteOlAHU2MhTFAr12PHQhCMUr1
yQ=; b=i3ItXggZU/DkSbFjA/mV64RHh1ETzhGY+FmfT5JIs6BYp2wIkJXbba9P0
VQWG0hu94q1KzlTwRBWABD1soh95UE4FMhy539DroSnbyX4rZc8CiEjy/pmvaeix
n2sA9LWD+Qt/XWG1I5qq4H6Lz+VpXbwut8je1o6ZUA3TxzbCVPetZlsi4hLeMqfl
eW4NyS9ktVRX/RCNiuXj13A5KMtJ4d+qK+hxW2tDrSjNUQ16bbZIUbe6FbjsX6HF
MXsGfimXGQ4hvGqZY+DmywzXlm1uYllm9eQ2Zxj/FEgflqTydo8XMMCSbB8OQChi
QunCKrqo1+15J4360c9t1MBryBtGw==
X-ME-Sender: <xms:Oyq-XMKtv7e18P6YUgMTSUu_z-cuSwLWERQm2UdVucxGMGjCI-N72Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigddugeeiucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
hppeekfedrudduhedrudehhedrudefkeenucfrrghrrghmpehmrghilhhfrhhomhepthhh
ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:Oyq-XBjzGdD_bOLz03HmdAxzKu32bfaGbgaRlKUcGDQaNl5imDwulw>
<xmx:Oyq-XAWM6U5_UGEiSwKbYnQBgwTWCfgrNr962ZjyFHrDVf6eO2pjaQ>
<xmx:Oyq-XJSVuSDQiOHj84l2m9Ceun7ELj99CuCsSyj63wIJE6eYF0UCLA>
<xmx:Oyq-XEp3RlNDJC3MQNq03nyv3HRLhaQ5YLJ1Vtyz8_CCF1nUCdHPRA>
Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr
[83.115.155.138])
by mail.messagingengine.com (Postfix) with ESMTPA id 8C2F310316;
Mon, 22 Apr 2019 16:55:21 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>
Date: Mon, 22 Apr 2019 22:55:18 +0200
Message-ID: <3365798.BUGD0mJE1c@xps>
In-Reply-To: <601a96fa-1a3e-9d98-8d78-df96c4ebd400@intel.com>
References: <20190409092201.7886-1-david.hunt@intel.com>
<601a96fa-1a3e-9d98-8d78-df96c4ebd400@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity
issues
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190422205518.n8P2laex1RFLOr8r8Oxa-KA4iN79L71qxTnv3O1lIYs@z>
09/04/2019 13:18, Burakov, Anatoly:
> On 09-Apr-19 10:22 AM, David Hunt wrote:
> > A previous change removed the limit of 64 cores by
> > moving away from 64-bit masks to char arrays. However
> > this left a buffer overrun issue, where the max channels
> > was defined as 64, and max cores was defined as 256. These
> > should all be consistently set to RTE_MAX_LCORE.
> >
> > The #defines being removed are CHANNEL_CMDS_MAX_CPUS,
> > CHANNEL_CMDS_MAX_CHANNELS, POWER_MGR_MAX_CPUS, and
> > CHANNEL_CMDS_MAX_VM_CHANNELS, and are being replaced
> > with RTE_MAX_LCORE for consistency and simplicity.
> >
> > Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
> > Coverity issue: 337672
> > Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
> > Coverity issue: 337673
> > Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
> > Coverity issue: 337678
>
> No need to mention the same commit three times :)
>
> > Signed-off-by: David Hunt <david.hunt@intel.com>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks