From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id ED501A05D3
for <public@inbox.dpdk.org>; Tue, 23 Apr 2019 00:20:31 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id AC0061B49C;
Tue, 23 Apr 2019 00:20:30 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 75EC91B48F;
Tue, 23 Apr 2019 00:20:29 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 12B5821FE8;
Mon, 22 Apr 2019 18:20:29 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Mon, 22 Apr 2019 18:20:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=K2vdwDGroCnX6EaV1gTk9qmxenkAtNeFoTsZ9HwBmpw=; b=c3caAsEXTXwz
QD8hpx6BL0Pht1UfZ2oIe8pEyZRbBUqvAjzKWzrT1GqAkHQKxQVuUMjF35q/v/GJ
Eajzt0vh6MD5pXe7paAEF+fF+juDPzG7BWkE4cLOTxgQPj57mAXktCce0TQVwysS
WsYcc1Wx4xd9Lqhey5ZwFhZHQWyPTSY=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=K2vdwDGroCnX6EaV1gTk9qmxenkAtNeFoTsZ9HwBm
pw=; b=4c+58Xn3MYEAUBt8zkFi6zStGN1ixoP5QzuHnvoiuyTnFVOkZfIUN055z
+rrvhLSu3klXSQr9l5M9B0Xo9NdpU+FByNnQzCP/322qvAjVRGqtpHAStwebV4Vk
OGjdmSD/Xz5AWVsez5/0+bhEoi9NgWy7HzQY7nEPyF9iBtYwIGFuHbeZQV0Urlhm
LJG+Vd+JJCRXqVgG9ZweDSk+R4EmApjmr99QEwt12Ir4Nhp1PA0ALbGQ1hmO1TGm
3EubKwhRGH3lM2L9Ux6pjkj+Vv1L5kc3H1xTyK5o6PWeC6vA+Gqy0M8b5x143vQS
EbeKcsyXlr3iIIdymYu82BkGOvl9A==
X-ME-Sender: <xms:LD6-XMO0WewA6hA_wG_jU0dbmlZUKQBUhtGbhqIQbj0gp3ozIcHuQw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeejgddtfecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epkeefrdduudehrdduheehrddufeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho
mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:LD6-XHMegplNb2B4TzQkteiGAFapMKq_1SXNVT3PrhSlkJo4VsFY5g>
<xmx:LD6-XOQ1cdHB4XALQ91yB0l1E6MvuIU6HWitlJrtDLmiTV42UAmtQw>
<xmx:LD6-XJDTzViz9j-vcnNhaGmOl38Xl6HjPVI1S2rECJpe3aQmSCXzjA>
<xmx:LT6-XB_ArD1YCRc9bjlwbh7DbrkbnBEBa1ogYlWkVWVsZWxHw_RnSQ>
Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr
[83.115.155.138])
by mail.messagingengine.com (Postfix) with ESMTPA id 770D0E415C;
Mon, 22 Apr 2019 18:20:26 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Sirvys, Andrius" <andrius.sirvys@intel.com>
Cc: stable@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Date: Tue, 23 Apr 2019 00:20:24 +0200
Message-ID: <1708946.S1UqcUaSvh@xps>
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23F5F3D8B@IRSMSX103.ger.corp.intel.com>
References: <20190418085206.86048-1-andrius.sirvys@intel.com>
<B27915DBBA3421428155699D51E4CFE23F5F3D8B@IRSMSX103.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] lib/bitratestats: fix
unchecked return value
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190422222024.z-NWYQm60mWp6V5c1N8lhRAK7R-eTAwtW4rvrBhlf7Q@z>
> > Checking the return value of rte_metrics_update_values, if failed
> > returning that value.
> > Coverity had picked up that that the return value wasn't being checked.
> >
> > Coverity issue: 336863
> > Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
> > Cc: remy.horton@intel.com
> >
> > Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> > Acked-by: Rami Rosen <ramirose@gmail.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
+Cc: stable
Applied, thanks