* [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr
@ 2019-04-17 6:49 Andy Pei
2019-04-17 6:49 ` Andy Pei
` (2 more replies)
0 siblings, 3 replies; 20+ messages in thread
From: Andy Pei @ 2019-04-17 6:49 UTC (permalink / raw)
To: dev; +Cc: andy.pei, rosen.xu, marko.kovacevic, liq3ea, stable
In rte_fpga_do_pr() function, if 'stat' returns error,
rte_fpga_do_pr() returns -EINVAL without closing the
'file_fd' that has been opened.
After this patch, 'file_fd' is closed before rte_fpga_do_pr()
returns -EINVAL when 'stat' returns error
Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Cc: rosen.xu@intel.com
Cc: marko.kovacevic@intel.com
Cc: liq3ea@163.com
Cc: andy.pei@intel.com
Cc: stable@dpdk.org
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
---
drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
index da772d0..eff001b 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -244,7 +244,8 @@
if (ret) {
IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n",
file_name);
- return -EINVAL;
+ ret = -EINVAL;
+ goto close_fd;
}
buffer_size = file_stat.st_size;
IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
--
1.8.3.1
^ permalink raw reply [flat|nested] 20+ messages in thread* [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr 2019-04-17 6:49 [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Andy Pei @ 2019-04-17 6:49 ` Andy Pei 2019-04-17 7:14 ` Xu, Rosen 2019-04-17 7:16 ` [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: " Andy Pei 2 siblings, 0 replies; 20+ messages in thread From: Andy Pei @ 2019-04-17 6:49 UTC (permalink / raw) To: dev; +Cc: andy.pei, rosen.xu, marko.kovacevic, liq3ea, stable In rte_fpga_do_pr() function, if 'stat' returns error, rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been opened. After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL when 'stat' returns error Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: rosen.xu@intel.com Cc: marko.kovacevic@intel.com Cc: liq3ea@163.com Cc: andy.pei@intel.com Cc: stable@dpdk.org Signed-off-by: Andy Pei <andy.pei@intel.com> --- --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c index da772d0..eff001b 100644 --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c @@ -244,7 +244,8 @@ if (ret) { IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n", file_name); - return -EINVAL; + ret = -EINVAL; + goto close_fd; } buffer_size = file_stat.st_size; IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size); -- 1.8.3.1 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr 2019-04-17 6:49 [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Andy Pei 2019-04-17 6:49 ` Andy Pei @ 2019-04-17 7:14 ` Xu, Rosen 2019-04-17 7:14 ` Xu, Rosen 2019-04-17 7:17 ` Pei, Andy 2019-04-17 7:16 ` [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: " Andy Pei 2 siblings, 2 replies; 20+ messages in thread From: Xu, Rosen @ 2019-04-17 7:14 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: Kovacevic, Marko, liq3ea, stable Hi, > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, April 17, 2019 14:49 > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com; > stable@dpdk.org > Subject: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Pls use raw/ifpga_rawdev prefix. I suggest you to run ./devtools/check-git-log.sh -1 before you sending patch. > In rte_fpga_do_pr() function, if 'stat' returns error, > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been > opened. > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL > when 'stat' returns error Pls put this in the commit message: Coverity issue: 279441 > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: marko.kovacevic@intel.com > Cc: liq3ea@163.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > index da772d0..eff001b 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > @@ -244,7 +244,8 @@ > if (ret) { > IFPGA_RAWDEV_PMD_ERR("stat on bitstream file > failed: %s\n", > file_name); > - return -EINVAL; > + ret = -EINVAL; > + goto close_fd; > } > buffer_size = file_stat.st_size; > IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size); > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr 2019-04-17 7:14 ` Xu, Rosen @ 2019-04-17 7:14 ` Xu, Rosen 2019-04-17 7:17 ` Pei, Andy 1 sibling, 0 replies; 20+ messages in thread From: Xu, Rosen @ 2019-04-17 7:14 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: Kovacevic, Marko, liq3ea, stable Hi, > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, April 17, 2019 14:49 > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com; > stable@dpdk.org > Subject: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Pls use raw/ifpga_rawdev prefix. I suggest you to run ./devtools/check-git-log.sh -1 before you sending patch. > In rte_fpga_do_pr() function, if 'stat' returns error, > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been > opened. > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL > when 'stat' returns error Pls put this in the commit message: Coverity issue: 279441 > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: marko.kovacevic@intel.com > Cc: liq3ea@163.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > index da772d0..eff001b 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > @@ -244,7 +244,8 @@ > if (ret) { > IFPGA_RAWDEV_PMD_ERR("stat on bitstream file > failed: %s\n", > file_name); > - return -EINVAL; > + ret = -EINVAL; > + goto close_fd; > } > buffer_size = file_stat.st_size; > IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size); > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr 2019-04-17 7:14 ` Xu, Rosen 2019-04-17 7:14 ` Xu, Rosen @ 2019-04-17 7:17 ` Pei, Andy 2019-04-17 7:17 ` Pei, Andy 1 sibling, 1 reply; 20+ messages in thread From: Pei, Andy @ 2019-04-17 7:17 UTC (permalink / raw) To: Xu, Rosen, dev; +Cc: Kovacevic, Marko, liq3ea, stable Okay -----Original Message----- From: Xu, Rosen Sent: Wednesday, April 17, 2019 3:14 PM To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org Cc: Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com; stable@dpdk.org Subject: RE: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Hi, > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, April 17, 2019 14:49 > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com; > stable@dpdk.org > Subject: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Pls use raw/ifpga_rawdev prefix. I suggest you to run ./devtools/check-git-log.sh -1 before you sending patch. > In rte_fpga_do_pr() function, if 'stat' returns error, > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that > has been opened. > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns > -EINVAL when 'stat' returns error Pls put this in the commit message: Coverity issue: 279441 > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: marko.kovacevic@intel.com > Cc: liq3ea@163.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > index da772d0..eff001b 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > @@ -244,7 +244,8 @@ > if (ret) { > IFPGA_RAWDEV_PMD_ERR("stat on bitstream file > failed: %s\n", > file_name); > - return -EINVAL; > + ret = -EINVAL; > + goto close_fd; > } > buffer_size = file_stat.st_size; > IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size); > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr 2019-04-17 7:17 ` Pei, Andy @ 2019-04-17 7:17 ` Pei, Andy 0 siblings, 0 replies; 20+ messages in thread From: Pei, Andy @ 2019-04-17 7:17 UTC (permalink / raw) To: Xu, Rosen, dev; +Cc: Kovacevic, Marko, liq3ea, stable Okay -----Original Message----- From: Xu, Rosen Sent: Wednesday, April 17, 2019 3:14 PM To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org Cc: Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com; stable@dpdk.org Subject: RE: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Hi, > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, April 17, 2019 14:49 > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com; > stable@dpdk.org > Subject: [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Pls use raw/ifpga_rawdev prefix. I suggest you to run ./devtools/check-git-log.sh -1 before you sending patch. > In rte_fpga_do_pr() function, if 'stat' returns error, > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that > has been opened. > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns > -EINVAL when 'stat' returns error Pls put this in the commit message: Coverity issue: 279441 > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: marko.kovacevic@intel.com > Cc: liq3ea@163.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > index da772d0..eff001b 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > @@ -244,7 +244,8 @@ > if (ret) { > IFPGA_RAWDEV_PMD_ERR("stat on bitstream file > failed: %s\n", > file_name); > - return -EINVAL; > + ret = -EINVAL; > + goto close_fd; > } > buffer_size = file_stat.st_size; > IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size); > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-17 6:49 [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Andy Pei 2019-04-17 6:49 ` Andy Pei 2019-04-17 7:14 ` Xu, Rosen @ 2019-04-17 7:16 ` Andy Pei 2019-04-17 7:16 ` Andy Pei 2019-04-17 8:03 ` Xu, Rosen 2 siblings, 2 replies; 20+ messages in thread From: Andy Pei @ 2019-04-17 7:16 UTC (permalink / raw) To: dev; +Cc: andy.pei, rosen.xu, marko.kovacevic, liq3ea, stable In rte_fpga_do_pr() function, if 'stat' returns error, rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been opened. After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL when 'stat' returns error Coverity issue: 279441 Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: rosen.xu@intel.com Cc: marko.kovacevic@intel.com Cc: liq3ea@163.com Cc: andy.pei@intel.com Cc: stable@dpdk.org Signed-off-by: Andy Pei <andy.pei@intel.com> --- --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c index da772d0..eff001b 100644 --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c @@ -244,7 +244,8 @@ if (ret) { IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n", file_name); - return -EINVAL; + ret = -EINVAL; + goto close_fd; } buffer_size = file_stat.st_size; IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size); -- 1.8.3.1 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-17 7:16 ` [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: " Andy Pei @ 2019-04-17 7:16 ` Andy Pei 2019-04-17 8:03 ` Xu, Rosen 1 sibling, 0 replies; 20+ messages in thread From: Andy Pei @ 2019-04-17 7:16 UTC (permalink / raw) To: dev; +Cc: andy.pei, rosen.xu, marko.kovacevic, liq3ea, stable In rte_fpga_do_pr() function, if 'stat' returns error, rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been opened. After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL when 'stat' returns error Coverity issue: 279441 Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: rosen.xu@intel.com Cc: marko.kovacevic@intel.com Cc: liq3ea@163.com Cc: andy.pei@intel.com Cc: stable@dpdk.org Signed-off-by: Andy Pei <andy.pei@intel.com> --- --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c index da772d0..eff001b 100644 --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c @@ -244,7 +244,8 @@ if (ret) { IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n", file_name); - return -EINVAL; + ret = -EINVAL; + goto close_fd; } buffer_size = file_stat.st_size; IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size); -- 1.8.3.1 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-17 7:16 ` [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: " Andy Pei 2019-04-17 7:16 ` Andy Pei @ 2019-04-17 8:03 ` Xu, Rosen 2019-04-17 8:03 ` Xu, Rosen 2019-04-22 17:52 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 1 sibling, 2 replies; 20+ messages in thread From: Xu, Rosen @ 2019-04-17 8:03 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: Kovacevic, Marko, liq3ea, stable > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, April 17, 2019 15:16 > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com; > stable@dpdk.org > Subject: [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr > > In rte_fpga_do_pr() function, if 'stat' returns error, > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been > opened. > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL > when 'stat' returns error > > Coverity issue: 279441 > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: marko.kovacevic@intel.com > Cc: liq3ea@163.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > index da772d0..eff001b 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > @@ -244,7 +244,8 @@ > if (ret) { > IFPGA_RAWDEV_PMD_ERR("stat on bitstream file > failed: %s\n", > file_name); > - return -EINVAL; > + ret = -EINVAL; > + goto close_fd; > } > buffer_size = file_stat.st_size; > IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size); > -- > 1.8.3.1 Acked-by: Rosen Xu <rosen.xu@intel.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-17 8:03 ` Xu, Rosen @ 2019-04-17 8:03 ` Xu, Rosen 2019-04-22 17:52 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 1 sibling, 0 replies; 20+ messages in thread From: Xu, Rosen @ 2019-04-17 8:03 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: Kovacevic, Marko, liq3ea, stable > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, April 17, 2019 15:16 > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com; > stable@dpdk.org > Subject: [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr > > In rte_fpga_do_pr() function, if 'stat' returns error, > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been > opened. > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL > when 'stat' returns error > > Coverity issue: 279441 > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: marko.kovacevic@intel.com > Cc: liq3ea@163.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > index da772d0..eff001b 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c > @@ -244,7 +244,8 @@ > if (ret) { > IFPGA_RAWDEV_PMD_ERR("stat on bitstream file > failed: %s\n", > file_name); > - return -EINVAL; > + ret = -EINVAL; > + goto close_fd; > } > buffer_size = file_stat.st_size; > IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size); > -- > 1.8.3.1 Acked-by: Rosen Xu <rosen.xu@intel.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-17 8:03 ` Xu, Rosen 2019-04-17 8:03 ` Xu, Rosen @ 2019-04-22 17:52 ` Thomas Monjalon 2019-04-22 17:52 ` Thomas Monjalon 2019-04-23 1:19 ` Pei, Andy 1 sibling, 2 replies; 20+ messages in thread From: Thomas Monjalon @ 2019-04-22 17:52 UTC (permalink / raw) To: Xu, Rosen, Pei, Andy; +Cc: stable, dev, Kovacevic, Marko, liq3ea > > In rte_fpga_do_pr() function, if 'stat' returns error, > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been > > opened. > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL > > when 'stat' returns error > > > > Coverity issue: 279441 > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > Cc: rosen.xu@intel.com > > Cc: marko.kovacevic@intel.com > > Cc: liq3ea@163.com > > Cc: andy.pei@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > Acked-by: Rosen Xu <rosen.xu@intel.com> Li Qiang <liq3ea@163.com> proposed the same patch. Why he is not referenced here? Which patch should I merge? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-22 17:52 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon @ 2019-04-22 17:52 ` Thomas Monjalon 2019-04-23 1:19 ` Pei, Andy 1 sibling, 0 replies; 20+ messages in thread From: Thomas Monjalon @ 2019-04-22 17:52 UTC (permalink / raw) To: Xu, Rosen, Pei, Andy; +Cc: stable, dev, Kovacevic, Marko, liq3ea > > In rte_fpga_do_pr() function, if 'stat' returns error, > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been > > opened. > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL > > when 'stat' returns error > > > > Coverity issue: 279441 > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > Cc: rosen.xu@intel.com > > Cc: marko.kovacevic@intel.com > > Cc: liq3ea@163.com > > Cc: andy.pei@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > Acked-by: Rosen Xu <rosen.xu@intel.com> Li Qiang <liq3ea@163.com> proposed the same patch. Why he is not referenced here? Which patch should I merge? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-22 17:52 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2019-04-22 17:52 ` Thomas Monjalon @ 2019-04-23 1:19 ` Pei, Andy 2019-04-23 1:19 ` Pei, Andy 2019-04-23 1:36 ` Xu, Rosen 1 sibling, 2 replies; 20+ messages in thread From: Pei, Andy @ 2019-04-23 1:19 UTC (permalink / raw) To: Thomas Monjalon, Xu, Rosen; +Cc: stable, dev, Kovacevic, Marko, liq3ea Hi Thomas, My patch is the same as LI Qiang's patch. I was told that Qiang's patch cannot get onto the patchwork, so I just help him do this. -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net] Sent: Tuesday, April 23, 2019 1:52 AM To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com> Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr > > In rte_fpga_do_pr() function, if 'stat' returns error, > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that > > has been opened. > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() > > returns -EINVAL when 'stat' returns error > > > > Coverity issue: 279441 > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > Cc: rosen.xu@intel.com > > Cc: marko.kovacevic@intel.com > > Cc: liq3ea@163.com > > Cc: andy.pei@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > Acked-by: Rosen Xu <rosen.xu@intel.com> Li Qiang <liq3ea@163.com> proposed the same patch. Why he is not referenced here? Which patch should I merge? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-23 1:19 ` Pei, Andy @ 2019-04-23 1:19 ` Pei, Andy 2019-04-23 1:36 ` Xu, Rosen 1 sibling, 0 replies; 20+ messages in thread From: Pei, Andy @ 2019-04-23 1:19 UTC (permalink / raw) To: Thomas Monjalon, Xu, Rosen; +Cc: stable, dev, Kovacevic, Marko, liq3ea Hi Thomas, My patch is the same as LI Qiang's patch. I was told that Qiang's patch cannot get onto the patchwork, so I just help him do this. -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net] Sent: Tuesday, April 23, 2019 1:52 AM To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com> Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr > > In rte_fpga_do_pr() function, if 'stat' returns error, > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that > > has been opened. > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() > > returns -EINVAL when 'stat' returns error > > > > Coverity issue: 279441 > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > Cc: rosen.xu@intel.com > > Cc: marko.kovacevic@intel.com > > Cc: liq3ea@163.com > > Cc: andy.pei@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > Acked-by: Rosen Xu <rosen.xu@intel.com> Li Qiang <liq3ea@163.com> proposed the same patch. Why he is not referenced here? Which patch should I merge? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-23 1:19 ` Pei, Andy 2019-04-23 1:19 ` Pei, Andy @ 2019-04-23 1:36 ` Xu, Rosen 2019-04-23 1:36 ` Xu, Rosen 2019-04-23 8:45 ` Thomas Monjalon 1 sibling, 2 replies; 20+ messages in thread From: Xu, Rosen @ 2019-04-23 1:36 UTC (permalink / raw) To: Pei, Andy, Thomas Monjalon; +Cc: stable, dev, Kovacevic, Marko, liq3ea Hi Thomas, Qian has some problem with his email. So some patch can't be found in patch work. For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks. > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, April 23, 2019 9:19 > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Rosen > <rosen.xu@intel.com> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > <marko.kovacevic@intel.com>; liq3ea@163.com > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte > fpga do pr > > Hi Thomas, > > My patch is the same as LI Qiang's patch. > I was told that Qiang's patch cannot get onto the patchwork, so I just help > him do this. > > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, April 23, 2019 1:52 AM > To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > <marko.kovacevic@intel.com>; liq3ea@163.com > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte > fpga do pr > > > > In rte_fpga_do_pr() function, if 'stat' returns error, > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that > > > has been opened. > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() > > > returns -EINVAL when 'stat' returns error > > > > > > Coverity issue: 279441 > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > > Cc: rosen.xu@intel.com > > > Cc: marko.kovacevic@intel.com > > > Cc: liq3ea@163.com > > > Cc: andy.pei@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > > > Acked-by: Rosen Xu <rosen.xu@intel.com> > > Li Qiang <liq3ea@163.com> proposed the same patch. > Why he is not referenced here? > Which patch should I merge? > > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-23 1:36 ` Xu, Rosen @ 2019-04-23 1:36 ` Xu, Rosen 2019-04-23 8:45 ` Thomas Monjalon 1 sibling, 0 replies; 20+ messages in thread From: Xu, Rosen @ 2019-04-23 1:36 UTC (permalink / raw) To: Pei, Andy, Thomas Monjalon; +Cc: stable, dev, Kovacevic, Marko, liq3ea Hi Thomas, Qian has some problem with his email. So some patch can't be found in patch work. For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks. > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, April 23, 2019 9:19 > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Rosen > <rosen.xu@intel.com> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > <marko.kovacevic@intel.com>; liq3ea@163.com > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte > fpga do pr > > Hi Thomas, > > My patch is the same as LI Qiang's patch. > I was told that Qiang's patch cannot get onto the patchwork, so I just help > him do this. > > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, April 23, 2019 1:52 AM > To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > <marko.kovacevic@intel.com>; liq3ea@163.com > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte > fpga do pr > > > > In rte_fpga_do_pr() function, if 'stat' returns error, > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that > > > has been opened. > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() > > > returns -EINVAL when 'stat' returns error > > > > > > Coverity issue: 279441 > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > > Cc: rosen.xu@intel.com > > > Cc: marko.kovacevic@intel.com > > > Cc: liq3ea@163.com > > > Cc: andy.pei@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > > > Acked-by: Rosen Xu <rosen.xu@intel.com> > > Li Qiang <liq3ea@163.com> proposed the same patch. > Why he is not referenced here? > Which patch should I merge? > > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-23 1:36 ` Xu, Rosen 2019-04-23 1:36 ` Xu, Rosen @ 2019-04-23 8:45 ` Thomas Monjalon 2019-04-23 8:45 ` Thomas Monjalon 2019-04-24 1:13 ` Pei, Andy 1 sibling, 2 replies; 20+ messages in thread From: Thomas Monjalon @ 2019-04-23 8:45 UTC (permalink / raw) To: Pei, Andy; +Cc: Xu, Rosen, stable, dev, Kovacevic, Marko, liq3ea When you need to re-send a patch, please apply it with "git am" so the original author is kept. Another nit: the title is full of abbreviation, it is hard to read. The title prefix should be "raw/ifpga", even if checkpatch complains. Please re-send, thanks. 23/04/2019 03:36, Xu, Rosen: > Hi Thomas, > > Qian has some problem with his email. So some patch can't be found in patch work. > For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks. > > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, April 23, 2019 9:19 > > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Rosen > > <rosen.xu@intel.com> > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > > <marko.kovacevic@intel.com>; liq3ea@163.com > > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte > > fpga do pr > > > > Hi Thomas, > > > > My patch is the same as LI Qiang's patch. > > I was told that Qiang's patch cannot get onto the patchwork, so I just help > > him do this. > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Tuesday, April 23, 2019 1:52 AM > > To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com> > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > > <marko.kovacevic@intel.com>; liq3ea@163.com > > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte > > fpga do pr > > > > > > In rte_fpga_do_pr() function, if 'stat' returns error, > > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that > > > > has been opened. > > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() > > > > returns -EINVAL when 'stat' returns error > > > > > > > > Coverity issue: 279441 > > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > > > Cc: rosen.xu@intel.com > > > > Cc: marko.kovacevic@intel.com > > > > Cc: liq3ea@163.com > > > > Cc: andy.pei@intel.com > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > > > > > Acked-by: Rosen Xu <rosen.xu@intel.com> > > > > Li Qiang <liq3ea@163.com> proposed the same patch. > > Why he is not referenced here? > > Which patch should I merge? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-23 8:45 ` Thomas Monjalon @ 2019-04-23 8:45 ` Thomas Monjalon 2019-04-24 1:13 ` Pei, Andy 1 sibling, 0 replies; 20+ messages in thread From: Thomas Monjalon @ 2019-04-23 8:45 UTC (permalink / raw) To: Pei, Andy; +Cc: Xu, Rosen, stable, dev, Kovacevic, Marko, liq3ea When you need to re-send a patch, please apply it with "git am" so the original author is kept. Another nit: the title is full of abbreviation, it is hard to read. The title prefix should be "raw/ifpga", even if checkpatch complains. Please re-send, thanks. 23/04/2019 03:36, Xu, Rosen: > Hi Thomas, > > Qian has some problem with his email. So some patch can't be found in patch work. > For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks. > > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, April 23, 2019 9:19 > > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Rosen > > <rosen.xu@intel.com> > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > > <marko.kovacevic@intel.com>; liq3ea@163.com > > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte > > fpga do pr > > > > Hi Thomas, > > > > My patch is the same as LI Qiang's patch. > > I was told that Qiang's patch cannot get onto the patchwork, so I just help > > him do this. > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Tuesday, April 23, 2019 1:52 AM > > To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com> > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > > <marko.kovacevic@intel.com>; liq3ea@163.com > > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte > > fpga do pr > > > > > > In rte_fpga_do_pr() function, if 'stat' returns error, > > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that > > > > has been opened. > > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() > > > > returns -EINVAL when 'stat' returns error > > > > > > > > Coverity issue: 279441 > > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > > > Cc: rosen.xu@intel.com > > > > Cc: marko.kovacevic@intel.com > > > > Cc: liq3ea@163.com > > > > Cc: andy.pei@intel.com > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > > > > > Acked-by: Rosen Xu <rosen.xu@intel.com> > > > > Li Qiang <liq3ea@163.com> proposed the same patch. > > Why he is not referenced here? > > Which patch should I merge? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-23 8:45 ` Thomas Monjalon 2019-04-23 8:45 ` Thomas Monjalon @ 2019-04-24 1:13 ` Pei, Andy 2019-04-24 1:13 ` Pei, Andy 1 sibling, 1 reply; 20+ messages in thread From: Pei, Andy @ 2019-04-24 1:13 UTC (permalink / raw) To: Thomas Monjalon; +Cc: Xu, Rosen, stable, dev, Kovacevic, Marko, liq3ea Hi, I saw Qiang's patch on patchwork today, [v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr So I think it seems OK to ignore my patch. -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net] Sent: Tuesday, April 23, 2019 4:45 PM To: Pei, Andy <andy.pei@intel.com> Cc: Xu, Rosen <rosen.xu@intel.com>; stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr When you need to re-send a patch, please apply it with "git am" so the original author is kept. Another nit: the title is full of abbreviation, it is hard to read. The title prefix should be "raw/ifpga", even if checkpatch complains. Please re-send, thanks. 23/04/2019 03:36, Xu, Rosen: > Hi Thomas, > > Qian has some problem with his email. So some patch can't be found in patch work. > For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks. > > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, April 23, 2019 9:19 > > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Rosen > > <rosen.xu@intel.com> > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > > <marko.kovacevic@intel.com>; liq3ea@163.com > > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak > > in rte fpga do pr > > > > Hi Thomas, > > > > My patch is the same as LI Qiang's patch. > > I was told that Qiang's patch cannot get onto the patchwork, so I > > just help him do this. > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Tuesday, April 23, 2019 1:52 AM > > To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com> > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > > <marko.kovacevic@intel.com>; liq3ea@163.com > > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak > > in rte fpga do pr > > > > > > In rte_fpga_do_pr() function, if 'stat' returns error, > > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' > > > > that has been opened. > > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() > > > > returns -EINVAL when 'stat' returns error > > > > > > > > Coverity issue: 279441 > > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev > > > > driver") > > > > Cc: rosen.xu@intel.com > > > > Cc: marko.kovacevic@intel.com > > > > Cc: liq3ea@163.com > > > > Cc: andy.pei@intel.com > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > > > > > Acked-by: Rosen Xu <rosen.xu@intel.com> > > > > Li Qiang <liq3ea@163.com> proposed the same patch. > > Why he is not referenced here? > > Which patch should I merge? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr 2019-04-24 1:13 ` Pei, Andy @ 2019-04-24 1:13 ` Pei, Andy 0 siblings, 0 replies; 20+ messages in thread From: Pei, Andy @ 2019-04-24 1:13 UTC (permalink / raw) To: Thomas Monjalon; +Cc: Xu, Rosen, stable, dev, Kovacevic, Marko, liq3ea Hi, I saw Qiang's patch on patchwork today, [v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr So I think it seems OK to ignore my patch. -----Original Message----- From: Thomas Monjalon [mailto:thomas@monjalon.net] Sent: Tuesday, April 23, 2019 4:45 PM To: Pei, Andy <andy.pei@intel.com> Cc: Xu, Rosen <rosen.xu@intel.com>; stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr When you need to re-send a patch, please apply it with "git am" so the original author is kept. Another nit: the title is full of abbreviation, it is hard to read. The title prefix should be "raw/ifpga", even if checkpatch complains. Please re-send, thanks. 23/04/2019 03:36, Xu, Rosen: > Hi Thomas, > > Qian has some problem with his email. So some patch can't be found in patch work. > For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks. > > > -----Original Message----- > > From: Pei, Andy > > Sent: Tuesday, April 23, 2019 9:19 > > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Rosen > > <rosen.xu@intel.com> > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > > <marko.kovacevic@intel.com>; liq3ea@163.com > > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak > > in rte fpga do pr > > > > Hi Thomas, > > > > My patch is the same as LI Qiang's patch. > > I was told that Qiang's patch cannot get onto the patchwork, so I > > just help him do this. > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Tuesday, April 23, 2019 1:52 AM > > To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com> > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > > <marko.kovacevic@intel.com>; liq3ea@163.com > > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak > > in rte fpga do pr > > > > > > In rte_fpga_do_pr() function, if 'stat' returns error, > > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' > > > > that has been opened. > > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() > > > > returns -EINVAL when 'stat' returns error > > > > > > > > Coverity issue: 279441 > > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev > > > > driver") > > > > Cc: rosen.xu@intel.com > > > > Cc: marko.kovacevic@intel.com > > > > Cc: liq3ea@163.com > > > > Cc: andy.pei@intel.com > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > > > > > Acked-by: Rosen Xu <rosen.xu@intel.com> > > > > Li Qiang <liq3ea@163.com> proposed the same patch. > > Why he is not referenced here? > > Which patch should I merge? ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2019-04-24 1:13 UTC | newest] Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-04-17 6:49 [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Andy Pei 2019-04-17 6:49 ` Andy Pei 2019-04-17 7:14 ` Xu, Rosen 2019-04-17 7:14 ` Xu, Rosen 2019-04-17 7:17 ` Pei, Andy 2019-04-17 7:17 ` Pei, Andy 2019-04-17 7:16 ` [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: " Andy Pei 2019-04-17 7:16 ` Andy Pei 2019-04-17 8:03 ` Xu, Rosen 2019-04-17 8:03 ` Xu, Rosen 2019-04-22 17:52 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2019-04-22 17:52 ` Thomas Monjalon 2019-04-23 1:19 ` Pei, Andy 2019-04-23 1:19 ` Pei, Andy 2019-04-23 1:36 ` Xu, Rosen 2019-04-23 1:36 ` Xu, Rosen 2019-04-23 8:45 ` Thomas Monjalon 2019-04-23 8:45 ` Thomas Monjalon 2019-04-24 1:13 ` Pei, Andy 2019-04-24 1:13 ` Pei, Andy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).