From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A508FA05D3 for ; Tue, 23 Apr 2019 03:36:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 115791B493; Tue, 23 Apr 2019 03:36:43 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 516EA5B40; Tue, 23 Apr 2019 03:36:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Apr 2019 18:36:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,384,1549958400"; d="scan'208";a="163915073" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 22 Apr 2019 18:36:40 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 22 Apr 2019 18:36:40 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 09:36:38 +0800 From: "Xu, Rosen" To: "Pei, Andy" , Thomas Monjalon CC: "stable@dpdk.org" , "dev@dpdk.org" , "Kovacevic, Marko" , "liq3ea@163.com" Thread-Topic: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr Thread-Index: AQHU9O6Cr3ZqHcencESM4GfplUDIi6Y//hpwgAf6IQCAAHz6AIAAik4w Date: Tue, 23 Apr 2019 01:36:37 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A6CE8A2@SHSMSX104.ccr.corp.intel.com> References: <1555483757-48188-1-git-send-email-andy.pei@intel.com> <1555485388-50214-1-git-send-email-andy.pei@intel.com> <0E78D399C70DA940A335608C6ED296D73A6B85AA@SHSMSX104.ccr.corp.intel.com> <1609679.gfMthc3lC5@xps> <5941F446C088714A85408FA3132CFCBB0100B26D@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <5941F446C088714A85408FA3132CFCBB0100B26D@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzM5ZWM2ODYtMGIwNy00YTJmLWIyYTYtZjJmMmYxY2JmN2I0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTEtqSUs4T1FXK21xS05sM1wvb1orOFdYYkgxSTc5ZTk3enVvVGRxZzI0dHZUYzQydGdFbnBIXC92M1BPTW94ODNGIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423013637.yxfWHdYX48Qv6UcOD1nokmo7GtkbrX0zmFoS-y8FCFg@z> Hi Thomas, Qian has some problem with his email. So some patch can't be found in patch= work. For it's a urgent bug. After we have aligned with Qian, Andy send this patc= h. Thanks. > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, April 23, 2019 9:19 > To: Thomas Monjalon ; Xu, Rosen > > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > ; liq3ea@163.com > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rt= e > fpga do pr >=20 > Hi Thomas, >=20 > My patch is the same as LI Qiang's patch. > I was told that Qiang's patch cannot get onto the patchwork, so I just he= lp > him do this. >=20 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, April 23, 2019 1:52 AM > To: Xu, Rosen ; Pei, Andy > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko > ; liq3ea@163.com > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rt= e > fpga do pr >=20 > > > In rte_fpga_do_pr() function, if 'stat' returns error, > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that > > > has been opened. > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() > > > returns -EINVAL when 'stat' returns error > > > > > > Coverity issue: 279441 > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > > Cc: rosen.xu@intel.com > > > Cc: marko.kovacevic@intel.com > > > Cc: liq3ea@163.com > > > Cc: andy.pei@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Andy Pei > > > > Acked-by: Rosen Xu >=20 > Li Qiang proposed the same patch. > Why he is not referenced here? > Which patch should I merge? >=20 >=20