From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, Rami Rosen <ramirose@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc
Date: Tue, 23 Apr 2019 03:31:51 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115336E68A@SHSMSX103.ccr.corp.intel.com> (raw)
Message-ID: <20190423033151.h-qOPjL7x4vJUU2lOJKVfMq3EJf8YrIq6z5rPgvPHUk@z> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909407FD74A@shsmsx102.ccr.corp.intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Tuesday, April 16, 2019 12:40 PM
> To: Rami Rosen <ramirose@gmail.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc
>
> Hi Rami,
>
> From: Rami Rosen [mailto:ramirose@gmail.com]
> Sent: Tuesday, April 16, 2019 5:55 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc
>
> Hi,
> In I40E DPDK nic guide, https://doc.dpdk.org/guides/nics/i40e.html,
> MDD does not appear.
> [Wenzhuo] As I know, this feature is not supported by i40e. I40e can send
> such packets. That’s why we want to mentions this different behavior for
> ice.
>
> In IXGBE DPDK nic guide, https://doc.dpdk.org/guides/nics/ixgbe.html,
> MDD appears, but in the known issues section.
> [Wenzhuo] Actually, for ixgbe, we want to mention MDD as a limitation
> (the same section as known issue). Because it’s more like our driver’s
> robust is not so strong. We have to ask the APP to provide the right L2/L3
> length. (The reason is it’s not effective to let the driver inspect the packet
> to get the right length.) But this ice behavior is more like a feature. To my
> opinion, it’s reasonable to drop such packets. That’s why I put it in the
> feature section.
>
> I think MDD is supported on both.
>
> just wonder, for the sake of consistency, is it worth to add such a section
> also for these nics ?
>
> Other than that,
>
> Acked-by: Rami Rosen
> <ramirose@gmail.com<mailto:ramirose@gmail.com>>
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2019-04-23 3:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 3:33 Wenzhuo Lu
2019-04-12 3:33 ` Wenzhuo Lu
2019-04-15 21:54 ` Rami Rosen
2019-04-15 21:54 ` Rami Rosen
2019-04-16 4:39 ` Lu, Wenzhuo
2019-04-16 4:39 ` Lu, Wenzhuo
2019-04-16 7:59 ` Rami Rosen
2019-04-16 7:59 ` Rami Rosen
2019-04-17 5:16 ` Lu, Wenzhuo
2019-04-17 5:16 ` Lu, Wenzhuo
2019-04-23 3:31 ` Zhang, Qi Z [this message]
2019-04-23 3:31 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115336E68A@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ramirose@gmail.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).