From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2BF1BA05D3 for ; Tue, 23 Apr 2019 08:26:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF7231B451; Tue, 23 Apr 2019 08:26:05 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00088.outbound.protection.outlook.com [40.107.0.88]) by dpdk.org (Postfix) with ESMTP id AFD1E1B440 for ; Tue, 23 Apr 2019 08:26:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E3LsixzvvtPUREZ6MGEeAndzHs+NHxCW1Wz7IAeDsA4=; b=tawPEjoY7Hk+YvXKAIF/GzPI3x7NqBfvGH7pC0JWsa/p/CaG6M/TSYW0+Zp9/dAMDOyc6sQS5L+81IfvlAlYgBAZuQRTWd7ite/AIhwBdUdPhAhZ/+0LV/IsU5s6x62iC4uPqm6SZQROKjnBX/2B1cvnDqIcuN4SWsyWbSTC+bM= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB6047.eurprd04.prod.outlook.com (20.179.24.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.16; Tue, 23 Apr 2019 06:26:03 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1813.017; Tue, 23 Apr 2019 06:26:03 +0000 From: Akhil Goyal To: Anoob Joseph , Shally Verma , Ayuj Verma , "arkadiuszx.kusztal@intel.com" , "fiona.trahe@intel.com" CC: Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" , Ayuj Verma Thread-Topic: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers Thread-Index: AQHU+ZdcNsxphV21M0eZmdCXNieh2aZJRvoQ Date: Tue, 23 Apr 2019 06:26:03 +0000 Message-ID: References: <1555052602-19155-1-git-send-email-ayverma@marvell.com> <1555052602-19155-2-git-send-email-ayverma@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a77bcb37-65e1-4ae3-7d7d-08d6c7b48f7a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600141)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR04MB6047; x-ms-traffictypediagnostic: VI1PR04MB6047: x-microsoft-antispam-prvs: x-forefront-prvs: 0016DEFF96 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(136003)(396003)(376002)(366004)(199004)(189003)(13464003)(6116002)(7736002)(3846002)(86362001)(316002)(2201001)(97736004)(305945005)(8936002)(229853002)(81166006)(74316002)(81156014)(2501003)(66946007)(66066001)(6436002)(73956011)(64756008)(66556008)(66446008)(66476007)(256004)(4326008)(25786009)(76116006)(71200400001)(99286004)(71190400001)(14444005)(33656002)(110136005)(55016002)(9686003)(478600001)(7696005)(5660300002)(2906002)(6246003)(53546011)(93886005)(6506007)(102836004)(54906003)(26005)(14454004)(53936002)(186003)(476003)(52536014)(44832011)(486006)(76176011)(11346002)(446003)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB6047; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: FdIhgnHoqsh8xwslsm3DuZ5wG/PLi1cVNBQee1K9H2YG/hMOQkbQ3oBoFP5+alY/ewvoe/YH6cYpPooLrgzNm676lw6k8RavaItHEVp0FDlygKn2ffBCP8Hsq+wJyah/VlAfHcHepP9+PVCArhCZtRC+UUk4b2C/NXpkKXb5CuMXk5k5UMcPbirikWGkYRacv2jip68FmiznqRgHIMsN1D44oRUq8ZTuHvQkEfT/cvFL5BOE5A5TYGwBQe0DkJJF1/3NQWvM96TEBqLiktwBc0bb1ljS1tS+EyFIUFHZGUZdYPU0IXCKHIOp1zikP8ZAbai5pkzYouuCCPYX8AVkgM8m+pFxq2xo1Tpk1jbqwpOXdQD4QFdb2HoX9aYI7ObQjqhmoQ8cj6YPJqLmk5NwaQABKp4oYPmoyn6UBcmOREI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a77bcb37-65e1-4ae3-7d7d-08d6c7b48f7a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2019 06:26:03.4003 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6047 Subject: Re: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423062603.rfSV6Z1bERlwcA92PzYW30zGfJ2sJeIyfr33FPSCYJg@z> Hi Anoob, > > > > > > Hi Ayuj, Akhil, Fiona, Shally, > > > > > > I think there are couple of issues with this patch. The real issue > > > here is the dependency of rte_crypto_asym.h on rte_crypto_sym.h. If > > > rte_crypto_asym.h doesn't include all the headers it uses, every file > > > which includes rte_crypto_asym.h will have to include > > > rte_crypto_asym.h's dependencies, which is not the right practice. > > > Keeping it alphabetical etc comes later. > > > > [Shally] We can change title something to "include dependencies into as= ym > > header files" , but then should I assume that You agree to this patch? >=20 > [Anoob] Yes. The title and description has to be changed to better reflec= t what > we are trying to solve. I'm in agreement with what the patch is trying to= achieve. >=20 Agreed > > > > > > > > So the patch has to be rephrased to better reflect the purpose. > > > > > > Also please see inline. > > > > > > Thanks, > > > Anoob > > > > > > > -----Original Message----- > > > > From: dev On Behalf Of Ayuj Verma > > > > Sent: Friday, April 12, 2019 12:33 PM > > > > To: akhil.goyal@nxp.com; arkadiuszx.kusztal@intel.com; > > > > fiona.trahe@intel.com > > > > Cc: Shally Verma ; Sunila Sahu > > > > ; Kanaka Durga Kotamarthy > > > > ; Arvind Desai ; > > > > dev@dpdk.org; Ayuj Verma > > > > Subject: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical orderin= g > > > > of headers > > > > > > > > include rte_crypto_sym.h in rte_crypto_asym.h in place of including > > > > it in rte_crypto.h. > > > > > > > > Signed-off-by: Ayuj Verma > > > > Signed-off-by: Shally Verma > > > > > > > > --- > > > > lib/librte_cryptodev/rte_crypto.h | 1 - > > > > lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ > > > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/lib/librte_cryptodev/rte_crypto.h > > > > b/lib/librte_cryptodev/rte_crypto.h > > > > index fd5ef3a..17dccdf 100644 > > > > --- a/lib/librte_cryptodev/rte_crypto.h > > > > +++ b/lib/librte_cryptodev/rte_crypto.h > > > > @@ -22,7 +22,6 @@ > > > > #include > > > > #include > > > > > > > > -#include "rte_crypto_sym.h" > > > > #include "rte_crypto_asym.h" > > > > > > [Anoob] If rte_crypto.h uses anything defined in rte_crypto_sym.h, > > > then you cannot remove the include. > > > > [Shally] so you mean we should do #include of sym.h in both, this and > > rte_crypto_asym.h file? >=20 > [Anoob] If this file uses anything from rte_crypto_sym.h, then ' #include > "rte_crypto_sym.h" ' has to be retained. Here the patch is removing the i= nclude. Agreed. >=20 > Instead may be the includes can be rearranged to make it follow alphabeti= cal > order. Again, that need not be part of this patch. If Akhil is okay with = having > includes violating the alphabetical sequence, this change can be deferred= . I am ok with this. >=20 > > > > >You can make it alphabetical, but the include has to be retained. > > [Shally] Sorry didn't get what you exactly mean by this? > > > > Thanks > > Shally > > > > > > > > > > > > > > > /** Crypto operation types */ >=20 > [Anoob] IMO, only the following change is needed. Agreed. >=20 > > > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > > > > b/lib/librte_cryptodev/rte_crypto_asym.h > > > > index 5e43620..a55923a 100644 > > > > --- a/lib/librte_cryptodev/rte_crypto_asym.h > > > > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > > > > @@ -25,6 +25,8 @@ > > > > #include > > > > #include > > > > > > > > +#include "rte_crypto_sym.h" > > > > + > > > > typedef struct rte_crypto_param_t { > > > > uint8_t *data; > > > > /**< pointer to buffer holding data */ > > > > -- > > > > 1.8.3.1