From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 37634A05D3 for ; Tue, 23 Apr 2019 10:14:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 034E81B3B9; Tue, 23 Apr 2019 10:14:30 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CD15A3977; Tue, 23 Apr 2019 10:14:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 01:14:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,385,1549958400"; d="scan'208";a="167053406" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.1.168]) ([10.252.1.168]) by fmsmga001.fm.intel.com with ESMTP; 23 Apr 2019 01:13:50 -0700 To: Herakliusz Lipiec , dev@dpdk.org Cc: jianfeng.tan@intel.com, jia.quo@intel.com, gi.z.zhang@intel.com, stable@dpdk.org References: <20190417143822.21276-1-herakliusz.lipiec@intel.com> From: "Burakov, Anatoly" Message-ID: <05c0504e-4119-504f-404a-a6288e3dc3e4@intel.com> Date: Tue, 23 Apr 2019 09:13:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417143822.21276-1-herakliusz.lipiec@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/8] ipc: fix rte_mp_request_sync memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423081346.R74OpFPGnqF-81r2qDE3mPP5JsvIGjlTiPwQKO8x-fA@z> On 17-Apr-19 3:38 PM, Herakliusz Lipiec wrote: > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were sent and no > memory for response buffers was allocated, which is > not true. Fixed by always initializing message buffer > to NULL. > > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > Cc: jianfeng.tan@intel.com > Cc: jia.quo@intel.com > Cc: gi.z.zhang@intel.com > Cc: stable@dpdk.org Also, Qi Zhang's email is wrong. Please don't write anything out manually, copy-paste is your friend :) -- Thanks, Anatoly