From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 6F0F11B395 for ; Tue, 23 Apr 2019 17:31:33 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id t16so7725499plo.0 for ; Tue, 23 Apr 2019 08:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LTFZfKl4ZML8DPSAyPVzvq/+/pWwB8msFY5up0/mCiE=; b=hyLl3J5sbVTxO5ouEArsOfJh1sSKAaKWVIc9lt5Kpv96MEZsf2m+AyyJBz14NELQHr GoFLK06Yk6JJB47OhPyngrPe+dcaCXdeA5FiFLUyvatge6QdKdQv9xW7IAW20sCPRINk 6sBUABeAB29XCUTSXQPg4amELzBJJEBbZD3Mer+J+ykAjHnKhwfUvUS6AU7djtL1yw2m Gj2cJLh9wgvQDeJqOUeBB9TJHl42WHxhvVkbQvcVvoh5jboVnQm3bLHGfK2KKes2njPs EOQm+p9SoQ9fyt6xs3JZDb66/c+XA3ooi1k7EjTybpap98UkfShAn4szY01oh/jMDs61 BlVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LTFZfKl4ZML8DPSAyPVzvq/+/pWwB8msFY5up0/mCiE=; b=BdGBGiL/Jt/kFFClpGrB+rq7y5kOYBrI+Bgb6+QD9pcKvn4v9S7iWeQoLGYt4cVA2e gZrsBDcuJbupx7LcNs0w6RZrHrFJf+5aDM8QWTr4WrQKxUvCxuh1AZ9yMmzCOVZSdd80 44FDPzyrgxBcZw+fCX/SflaKK5jXgS1dph4DdNYrLhEVAXCfoAB4FnTLTMZAfqLL+nSj y4h8Uyrjtf3VFd+qg9sQbkuusFg6nN8tsug05vcK8QUOFX+4EzrJ2FLE36b6BWnQl2T0 8aGC2s7LY1kTtO6iRqhtlG5ZCKhjERCbKO7Wb4OqsoBf1Lk/EqkLeCXas/SXlU+V35lk l2TQ== X-Gm-Message-State: APjAAAUWuMe3x4s1o3AU0JWziVL0B92FZgDs0kt9co4k8wTmqaLfxkDd Km+U/7GdJHtY9veZE33T9feYhg== X-Google-Smtp-Source: APXvYqw/lUyD3NJ0CEcHGyFDY8MJnVAmYAYMz0BiFnZaK8F7hQy6kQCTl1EOemrRL+53iL08q2Xorg== X-Received: by 2002:a17:902:4081:: with SMTP id c1mr26665723pld.169.1556033492191; Tue, 23 Apr 2019 08:31:32 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d129sm29862082pfa.142.2019.04.23.08.31.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 08:31:31 -0700 (PDT) Date: Tue, 23 Apr 2019 08:31:24 -0700 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: Neil Horman , dev@dpdk.org Message-ID: <20190423083124.53481256@hermes.lan> In-Reply-To: <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 15:31:33 -0000 On Mon, 22 Apr 2019 19:44:39 +0200 Mattias R=C3=B6nnblom wrote: > On 2019-04-22 17:52, Mattias R=C3=B6nnblom wrote: > > On 2019-04-22 13:34, Neil Horman wrote: > > =20 > >>> +uint64_t __rte_experimental > >>> +rte_rand(void) =20 > >> Do you really want to mark this as experimental?=C2=A0 I know it will= =20 > >> trigger the > >> symbol checker with a warning if you don't, but this function already= =20 > >> existed > >> previously and was accepted as part of the ABI.=C2=A0 Given that the=20 > >> prototype hasn't > >> changed, I think you just need to accept it as a non-experimental=20 > >> function > >> =20 > >=20 > > I'll remove the experimental tag and move it into the 19_05 section=20 > > (without suggesting it should go into 19.05). That maneuver seems not t= o=20 > > trigger any build warnings/errors. > > =20 >=20 > OK, so that wasn't true. It does trigger a build error, courtesy of=20 > buildtools/check-experimental-syms.sh. >=20 > I can't see any obvious way around it. Ideas, anyone? Ignore the error, the build tool is not smart enough for this kind of chang= e. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 82099A05D3 for ; Tue, 23 Apr 2019 17:31:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55AD61B3DD; Tue, 23 Apr 2019 17:31:34 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 6F0F11B395 for ; Tue, 23 Apr 2019 17:31:33 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id t16so7725499plo.0 for ; Tue, 23 Apr 2019 08:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LTFZfKl4ZML8DPSAyPVzvq/+/pWwB8msFY5up0/mCiE=; b=hyLl3J5sbVTxO5ouEArsOfJh1sSKAaKWVIc9lt5Kpv96MEZsf2m+AyyJBz14NELQHr GoFLK06Yk6JJB47OhPyngrPe+dcaCXdeA5FiFLUyvatge6QdKdQv9xW7IAW20sCPRINk 6sBUABeAB29XCUTSXQPg4amELzBJJEBbZD3Mer+J+ykAjHnKhwfUvUS6AU7djtL1yw2m Gj2cJLh9wgvQDeJqOUeBB9TJHl42WHxhvVkbQvcVvoh5jboVnQm3bLHGfK2KKes2njPs EOQm+p9SoQ9fyt6xs3JZDb66/c+XA3ooi1k7EjTybpap98UkfShAn4szY01oh/jMDs61 BlVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LTFZfKl4ZML8DPSAyPVzvq/+/pWwB8msFY5up0/mCiE=; b=BdGBGiL/Jt/kFFClpGrB+rq7y5kOYBrI+Bgb6+QD9pcKvn4v9S7iWeQoLGYt4cVA2e gZrsBDcuJbupx7LcNs0w6RZrHrFJf+5aDM8QWTr4WrQKxUvCxuh1AZ9yMmzCOVZSdd80 44FDPzyrgxBcZw+fCX/SflaKK5jXgS1dph4DdNYrLhEVAXCfoAB4FnTLTMZAfqLL+nSj y4h8Uyrjtf3VFd+qg9sQbkuusFg6nN8tsug05vcK8QUOFX+4EzrJ2FLE36b6BWnQl2T0 8aGC2s7LY1kTtO6iRqhtlG5ZCKhjERCbKO7Wb4OqsoBf1Lk/EqkLeCXas/SXlU+V35lk l2TQ== X-Gm-Message-State: APjAAAUWuMe3x4s1o3AU0JWziVL0B92FZgDs0kt9co4k8wTmqaLfxkDd Km+U/7GdJHtY9veZE33T9feYhg== X-Google-Smtp-Source: APXvYqw/lUyD3NJ0CEcHGyFDY8MJnVAmYAYMz0BiFnZaK8F7hQy6kQCTl1EOemrRL+53iL08q2Xorg== X-Received: by 2002:a17:902:4081:: with SMTP id c1mr26665723pld.169.1556033492191; Tue, 23 Apr 2019 08:31:32 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d129sm29862082pfa.142.2019.04.23.08.31.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 08:31:31 -0700 (PDT) Date: Tue, 23 Apr 2019 08:31:24 -0700 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: Neil Horman , dev@dpdk.org Message-ID: <20190423083124.53481256@hermes.lan> In-Reply-To: <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423153124.vDm3C_MozJ91g5y-sAHaa__Nu38Fs2VCZ0aZt4ng97M@z> On Mon, 22 Apr 2019 19:44:39 +0200 Mattias R=C3=B6nnblom wrote: > On 2019-04-22 17:52, Mattias R=C3=B6nnblom wrote: > > On 2019-04-22 13:34, Neil Horman wrote: > > =20 > >>> +uint64_t __rte_experimental > >>> +rte_rand(void) =20 > >> Do you really want to mark this as experimental?=C2=A0 I know it will= =20 > >> trigger the > >> symbol checker with a warning if you don't, but this function already= =20 > >> existed > >> previously and was accepted as part of the ABI.=C2=A0 Given that the=20 > >> prototype hasn't > >> changed, I think you just need to accept it as a non-experimental=20 > >> function > >> =20 > >=20 > > I'll remove the experimental tag and move it into the 19_05 section=20 > > (without suggesting it should go into 19.05). That maneuver seems not t= o=20 > > trigger any build warnings/errors. > > =20 >=20 > OK, so that wasn't true. It does trigger a build error, courtesy of=20 > buildtools/check-experimental-syms.sh. >=20 > I can't see any obvious way around it. Ideas, anyone? Ignore the error, the build tool is not smart enough for this kind of chang= e.