From: Thomas Monjalon <thomas@monjalon.net>
To: "Pei, Andy" <andy.pei@intel.com>
Cc: "Xu, Rosen" <rosen.xu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"dev@dpdk.org" <dev@dpdk.org>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
"liq3ea@163.com" <liq3ea@163.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr
Date: Tue, 23 Apr 2019 10:45:00 +0200 [thread overview]
Message-ID: <2416997.dOrgfSpHr6@xps> (raw)
Message-ID: <20190423084500.UjcygN0CXQWZNzNUNc2Xc2kpSHroz06kCeW2-e_Ibjs@z> (raw)
In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A6CE8A2@SHSMSX104.ccr.corp.intel.com>
When you need to re-send a patch, please apply it with "git am"
so the original author is kept.
Another nit: the title is full of abbreviation, it is hard to read.
The title prefix should be "raw/ifpga", even if checkpatch complains.
Please re-send, thanks.
23/04/2019 03:36, Xu, Rosen:
> Hi Thomas,
>
> Qian has some problem with his email. So some patch can't be found in patch work.
> For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks.
>
> > -----Original Message-----
> > From: Pei, Andy
> > Sent: Tuesday, April 23, 2019 9:19
> > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Rosen
> > <rosen.xu@intel.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko
> > <marko.kovacevic@intel.com>; liq3ea@163.com
> > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte
> > fpga do pr
> >
> > Hi Thomas,
> >
> > My patch is the same as LI Qiang's patch.
> > I was told that Qiang's patch cannot get onto the patchwork, so I just help
> > him do this.
> >
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Tuesday, April 23, 2019 1:52 AM
> > To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko
> > <marko.kovacevic@intel.com>; liq3ea@163.com
> > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte
> > fpga do pr
> >
> > > > In rte_fpga_do_pr() function, if 'stat' returns error,
> > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that
> > > > has been opened.
> > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr()
> > > > returns -EINVAL when 'stat' returns error
> > > >
> > > > Coverity issue: 279441
> > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > > > Cc: rosen.xu@intel.com
> > > > Cc: marko.kovacevic@intel.com
> > > > Cc: liq3ea@163.com
> > > > Cc: andy.pei@intel.com
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Andy Pei <andy.pei@intel.com>
> > >
> > > Acked-by: Rosen Xu <rosen.xu@intel.com>
> >
> > Li Qiang <liq3ea@163.com> proposed the same patch.
> > Why he is not referenced here?
> > Which patch should I merge?
next prev parent reply other threads:[~2019-04-23 8:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 6:49 [dpdk-dev] [PATCH] raw/ifpga: " Andy Pei
2019-04-17 6:49 ` Andy Pei
2019-04-17 7:14 ` Xu, Rosen
2019-04-17 7:14 ` Xu, Rosen
2019-04-17 7:17 ` Pei, Andy
2019-04-17 7:17 ` Pei, Andy
2019-04-17 7:16 ` [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: " Andy Pei
2019-04-17 7:16 ` Andy Pei
2019-04-17 8:03 ` Xu, Rosen
2019-04-17 8:03 ` Xu, Rosen
2019-04-22 17:52 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-04-22 17:52 ` Thomas Monjalon
2019-04-23 1:19 ` Pei, Andy
2019-04-23 1:19 ` Pei, Andy
2019-04-23 1:36 ` Xu, Rosen
2019-04-23 1:36 ` Xu, Rosen
2019-04-23 8:45 ` Thomas Monjalon [this message]
2019-04-23 8:45 ` Thomas Monjalon
2019-04-24 1:13 ` Pei, Andy
2019-04-24 1:13 ` Pei, Andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2416997.dOrgfSpHr6@xps \
--to=thomas@monjalon.net \
--cc=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=liq3ea@163.com \
--cc=marko.kovacevic@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).