* Re: [dpdk-dev] [PATCH] eventdev: add experimental tag back
@ 2019-04-23 8:49 Jerin Jacob Kollanukkaran
2019-04-23 8:49 ` Jerin Jacob Kollanukkaran
0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-04-23 8:49 UTC (permalink / raw)
To: Nikhil Rao, thomas; +Cc: dev
> -----Original Message-----
> From: Nikhil Rao <nikhil.rao@intel.com>
> Sent: Tuesday, April 23, 2019 11:20 AM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Nikhil Rao <nikhil.rao@intel.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Subject: [EXT] [PATCH] eventdev: add experimental tag back
>
> ----------------------------------------------------------------------
> Add the experimental tag back to the Rx event adapter callback and the Rx event
> callback register functions. This patch also adds the experimental tag in the
> callback register function definition and adds the function to the EXPERIMENTAL
> section of the map file, these were missing previously.
>
> Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable")
> Cc: jerinj@marvell.com
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
diff --git a/lib/librte_eventdev/rte_eventdev_version.map
> b/lib/librte_eventdev/rte_eventdev_version.map
> index 88c3ce5..9bfc666 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -124,3 +124,9 @@ DPDK_19.05 {
> rte_event_timer_arm_tmo_tick_burst;
> rte_event_timer_cancel_burst;
> } DPDK_18.05;
> +
> +EXPERIMENTAL {
> + global:
> +
> + rte_event_eth_rx_adapter_cb_register;
This symbol is present in DPDK_19.05 section above.
Please remove the duplicate entry from DPDK_19.05.
With above fix:
Acked-by: Jerin Jacob <jerinj@marvell.com>
> +};
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] eventdev: add experimental tag back
2019-04-23 8:49 [dpdk-dev] [PATCH] eventdev: add experimental tag back Jerin Jacob Kollanukkaran
@ 2019-04-23 8:49 ` Jerin Jacob Kollanukkaran
0 siblings, 0 replies; 6+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-04-23 8:49 UTC (permalink / raw)
To: Nikhil Rao, thomas; +Cc: dev
> -----Original Message-----
> From: Nikhil Rao <nikhil.rao@intel.com>
> Sent: Tuesday, April 23, 2019 11:20 AM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Nikhil Rao <nikhil.rao@intel.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Subject: [EXT] [PATCH] eventdev: add experimental tag back
>
> ----------------------------------------------------------------------
> Add the experimental tag back to the Rx event adapter callback and the Rx event
> callback register functions. This patch also adds the experimental tag in the
> callback register function definition and adds the function to the EXPERIMENTAL
> section of the map file, these were missing previously.
>
> Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable")
> Cc: jerinj@marvell.com
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
diff --git a/lib/librte_eventdev/rte_eventdev_version.map
> b/lib/librte_eventdev/rte_eventdev_version.map
> index 88c3ce5..9bfc666 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -124,3 +124,9 @@ DPDK_19.05 {
> rte_event_timer_arm_tmo_tick_burst;
> rte_event_timer_cancel_burst;
> } DPDK_18.05;
> +
> +EXPERIMENTAL {
> + global:
> +
> + rte_event_eth_rx_adapter_cb_register;
This symbol is present in DPDK_19.05 section above.
Please remove the duplicate entry from DPDK_19.05.
With above fix:
Acked-by: Jerin Jacob <jerinj@marvell.com>
> +};
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] eventdev: add experimental tag back
2019-04-23 5:50 Nikhil Rao
2019-04-23 5:50 ` Nikhil Rao
@ 2019-04-23 10:58 ` Kevin Traynor
2019-04-23 10:58 ` Kevin Traynor
1 sibling, 1 reply; 6+ messages in thread
From: Kevin Traynor @ 2019-04-23 10:58 UTC (permalink / raw)
To: Nikhil Rao, thomas; +Cc: dev, jerinj
On 23/04/2019 06:50, Nikhil Rao wrote:
> Add the experimental tag back to the Rx event adapter callback
> and the Rx event callback register functions. This patch also
You should add an explanation why in the commit message. It is an
unusual thing to do and the other mail thread would be too hard to find.
> adds the experimental tag in the callback register
> function definition and adds the function to the EXPERIMENTAL
> section of the map file, these were missing previously.
>
> Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable")
> Cc: jerinj@marvell.com
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> lib/librte_eventdev/rte_event_eth_rx_adapter.h | 8 +++++++-
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 9 +++++----
> lib/librte_eventdev/rte_eventdev_version.map | 6 ++++++
> 3 files changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> index cf23cde..32b52a7 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> @@ -201,6 +201,9 @@ struct rte_event_eth_rx_adapter_stats {
> };
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Callback function invoked by the SW adapter before it continues
> * to process packets. The callback is passed the size of the enqueue
> * buffer in the SW adapter and the occupancy of the buffer. The
> @@ -437,6 +440,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id);
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Register callback to process Rx packets, this is supported for
> * SW based packet transfers.
> * @see rte_event_eth_rx_cb_fn
> @@ -453,7 +459,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> * - 0: Success
> * - <0: Error code on failure.
> */
> -int
> +int __rte_experimental
> rte_event_eth_rx_adapter_cb_register(uint8_t id,
> uint16_t eth_dev_id,
> rte_event_eth_rx_adapter_cb_fn cb_fn,
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 8d178be..e6001e2 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,
> return rx_adapter->service_inited ? 0 : -ESRCH;
> }
>
> -int rte_event_eth_rx_adapter_cb_register(uint8_t id,
> - uint16_t eth_dev_id,
> - rte_event_eth_rx_adapter_cb_fn cb_fn,
> - void *cb_arg)
> +int __rte_experimental
> +rte_event_eth_rx_adapter_cb_register(uint8_t id,
> + uint16_t eth_dev_id,
> + rte_event_eth_rx_adapter_cb_fn cb_fn,
> + void *cb_arg)
> {
> struct rte_event_eth_rx_adapter *rx_adapter;
> struct eth_device_info *dev_info;
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
> index 88c3ce5..9bfc666 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -124,3 +124,9 @@ DPDK_19.05 {
> rte_event_timer_arm_tmo_tick_burst;
> rte_event_timer_cancel_burst;
> } DPDK_18.05;
> +
> +EXPERIMENTAL {
> + global:
> +
> + rte_event_eth_rx_adapter_cb_register;
> +};
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] eventdev: add experimental tag back
2019-04-23 10:58 ` Kevin Traynor
@ 2019-04-23 10:58 ` Kevin Traynor
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Traynor @ 2019-04-23 10:58 UTC (permalink / raw)
To: Nikhil Rao, thomas; +Cc: dev, jerinj
On 23/04/2019 06:50, Nikhil Rao wrote:
> Add the experimental tag back to the Rx event adapter callback
> and the Rx event callback register functions. This patch also
You should add an explanation why in the commit message. It is an
unusual thing to do and the other mail thread would be too hard to find.
> adds the experimental tag in the callback register
> function definition and adds the function to the EXPERIMENTAL
> section of the map file, these were missing previously.
>
> Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable")
> Cc: jerinj@marvell.com
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> lib/librte_eventdev/rte_event_eth_rx_adapter.h | 8 +++++++-
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 9 +++++----
> lib/librte_eventdev/rte_eventdev_version.map | 6 ++++++
> 3 files changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> index cf23cde..32b52a7 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> @@ -201,6 +201,9 @@ struct rte_event_eth_rx_adapter_stats {
> };
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Callback function invoked by the SW adapter before it continues
> * to process packets. The callback is passed the size of the enqueue
> * buffer in the SW adapter and the occupancy of the buffer. The
> @@ -437,6 +440,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id);
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Register callback to process Rx packets, this is supported for
> * SW based packet transfers.
> * @see rte_event_eth_rx_cb_fn
> @@ -453,7 +459,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> * - 0: Success
> * - <0: Error code on failure.
> */
> -int
> +int __rte_experimental
> rte_event_eth_rx_adapter_cb_register(uint8_t id,
> uint16_t eth_dev_id,
> rte_event_eth_rx_adapter_cb_fn cb_fn,
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 8d178be..e6001e2 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,
> return rx_adapter->service_inited ? 0 : -ESRCH;
> }
>
> -int rte_event_eth_rx_adapter_cb_register(uint8_t id,
> - uint16_t eth_dev_id,
> - rte_event_eth_rx_adapter_cb_fn cb_fn,
> - void *cb_arg)
> +int __rte_experimental
> +rte_event_eth_rx_adapter_cb_register(uint8_t id,
> + uint16_t eth_dev_id,
> + rte_event_eth_rx_adapter_cb_fn cb_fn,
> + void *cb_arg)
> {
> struct rte_event_eth_rx_adapter *rx_adapter;
> struct eth_device_info *dev_info;
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
> index 88c3ce5..9bfc666 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -124,3 +124,9 @@ DPDK_19.05 {
> rte_event_timer_arm_tmo_tick_burst;
> rte_event_timer_cancel_burst;
> } DPDK_18.05;
> +
> +EXPERIMENTAL {
> + global:
> +
> + rte_event_eth_rx_adapter_cb_register;
> +};
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] eventdev: add experimental tag back
@ 2019-04-23 5:50 Nikhil Rao
2019-04-23 5:50 ` Nikhil Rao
2019-04-23 10:58 ` Kevin Traynor
0 siblings, 2 replies; 6+ messages in thread
From: Nikhil Rao @ 2019-04-23 5:50 UTC (permalink / raw)
To: thomas; +Cc: dev, Nikhil Rao, jerinj
Add the experimental tag back to the Rx event adapter callback
and the Rx event callback register functions. This patch also
adds the experimental tag in the callback register
function definition and adds the function to the EXPERIMENTAL
section of the map file, these were missing previously.
Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable")
Cc: jerinj@marvell.com
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
lib/librte_eventdev/rte_event_eth_rx_adapter.h | 8 +++++++-
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 9 +++++----
lib/librte_eventdev/rte_eventdev_version.map | 6 ++++++
3 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
index cf23cde..32b52a7 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
@@ -201,6 +201,9 @@ struct rte_event_eth_rx_adapter_stats {
};
/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
* Callback function invoked by the SW adapter before it continues
* to process packets. The callback is passed the size of the enqueue
* buffer in the SW adapter and the occupancy of the buffer. The
@@ -437,6 +440,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id);
/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
* Register callback to process Rx packets, this is supported for
* SW based packet transfers.
* @see rte_event_eth_rx_cb_fn
@@ -453,7 +459,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
* - 0: Success
* - <0: Error code on failure.
*/
-int
+int __rte_experimental
rte_event_eth_rx_adapter_cb_register(uint8_t id,
uint16_t eth_dev_id,
rte_event_eth_rx_adapter_cb_fn cb_fn,
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 8d178be..e6001e2 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,
return rx_adapter->service_inited ? 0 : -ESRCH;
}
-int rte_event_eth_rx_adapter_cb_register(uint8_t id,
- uint16_t eth_dev_id,
- rte_event_eth_rx_adapter_cb_fn cb_fn,
- void *cb_arg)
+int __rte_experimental
+rte_event_eth_rx_adapter_cb_register(uint8_t id,
+ uint16_t eth_dev_id,
+ rte_event_eth_rx_adapter_cb_fn cb_fn,
+ void *cb_arg)
{
struct rte_event_eth_rx_adapter *rx_adapter;
struct eth_device_info *dev_info;
diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
index 88c3ce5..9bfc666 100644
--- a/lib/librte_eventdev/rte_eventdev_version.map
+++ b/lib/librte_eventdev/rte_eventdev_version.map
@@ -124,3 +124,9 @@ DPDK_19.05 {
rte_event_timer_arm_tmo_tick_burst;
rte_event_timer_cancel_burst;
} DPDK_18.05;
+
+EXPERIMENTAL {
+ global:
+
+ rte_event_eth_rx_adapter_cb_register;
+};
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] eventdev: add experimental tag back
2019-04-23 5:50 Nikhil Rao
@ 2019-04-23 5:50 ` Nikhil Rao
2019-04-23 10:58 ` Kevin Traynor
1 sibling, 0 replies; 6+ messages in thread
From: Nikhil Rao @ 2019-04-23 5:50 UTC (permalink / raw)
To: thomas; +Cc: dev, Nikhil Rao, jerinj
Add the experimental tag back to the Rx event adapter callback
and the Rx event callback register functions. This patch also
adds the experimental tag in the callback register
function definition and adds the function to the EXPERIMENTAL
section of the map file, these were missing previously.
Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable")
Cc: jerinj@marvell.com
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
lib/librte_eventdev/rte_event_eth_rx_adapter.h | 8 +++++++-
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 9 +++++----
lib/librte_eventdev/rte_eventdev_version.map | 6 ++++++
3 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
index cf23cde..32b52a7 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
@@ -201,6 +201,9 @@ struct rte_event_eth_rx_adapter_stats {
};
/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
* Callback function invoked by the SW adapter before it continues
* to process packets. The callback is passed the size of the enqueue
* buffer in the SW adapter and the occupancy of the buffer. The
@@ -437,6 +440,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id);
/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
* Register callback to process Rx packets, this is supported for
* SW based packet transfers.
* @see rte_event_eth_rx_cb_fn
@@ -453,7 +459,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
* - 0: Success
* - <0: Error code on failure.
*/
-int
+int __rte_experimental
rte_event_eth_rx_adapter_cb_register(uint8_t id,
uint16_t eth_dev_id,
rte_event_eth_rx_adapter_cb_fn cb_fn,
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 8d178be..e6001e2 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,
return rx_adapter->service_inited ? 0 : -ESRCH;
}
-int rte_event_eth_rx_adapter_cb_register(uint8_t id,
- uint16_t eth_dev_id,
- rte_event_eth_rx_adapter_cb_fn cb_fn,
- void *cb_arg)
+int __rte_experimental
+rte_event_eth_rx_adapter_cb_register(uint8_t id,
+ uint16_t eth_dev_id,
+ rte_event_eth_rx_adapter_cb_fn cb_fn,
+ void *cb_arg)
{
struct rte_event_eth_rx_adapter *rx_adapter;
struct eth_device_info *dev_info;
diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
index 88c3ce5..9bfc666 100644
--- a/lib/librte_eventdev/rte_eventdev_version.map
+++ b/lib/librte_eventdev/rte_eventdev_version.map
@@ -124,3 +124,9 @@ DPDK_19.05 {
rte_event_timer_arm_tmo_tick_burst;
rte_event_timer_cancel_burst;
} DPDK_18.05;
+
+EXPERIMENTAL {
+ global:
+
+ rte_event_eth_rx_adapter_cb_register;
+};
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-23 10:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 8:49 [dpdk-dev] [PATCH] eventdev: add experimental tag back Jerin Jacob Kollanukkaran
2019-04-23 8:49 ` Jerin Jacob Kollanukkaran
-- strict thread matches above, loose matches on Subject: below --
2019-04-23 5:50 Nikhil Rao
2019-04-23 5:50 ` Nikhil Rao
2019-04-23 10:58 ` Kevin Traynor
2019-04-23 10:58 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).