From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1E4B0A05D3 for ; Tue, 23 Apr 2019 16:09:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 323901B3F5; Tue, 23 Apr 2019 16:09:35 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 23C3D1B3F0; Tue, 23 Apr 2019 16:09:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 07:09:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,386,1549958400"; d="scan'208";a="167135432" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga001.fm.intel.com with ESMTP; 23 Apr 2019 07:04:31 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.31]) by IRSMSX109.ger.corp.intel.com ([169.254.13.189]) with mapi id 14.03.0415.000; Tue, 23 Apr 2019 15:04:30 +0100 From: "Ananyev, Konstantin" To: Akhil Goyal , "Iremonger, Bernard" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto Thread-Index: AdT17cOXAWgCos0Egk2F6sufGT2n9wDz6F0AAATiOqD///9EgP//632g Date: Tue, 23 Apr 2019 14:04:30 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580148A9B10E@irsmsx105.ger.corp.intel.com> References: <2601191342CEEE43887BDE71AB9772580148A9B0D4@irsmsx105.ger.corp.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGU2ZTMwZDgtZDU1NC00YzQyLWJmMjYtNGMxYmViN2YxYjVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV0JDZTdWMlA5Z3JxMzc3c2ZidWNURDF6YlZLYTJpZmRDQ2ZtcE4rRGFIMWhFcmE3TlJLTW1SaTZvaVwvOGx4Sm8ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423140430.HmJfW47HQVCf1klrVBUG10m-Hp3k1eTUT6M6-3MoE1o@z> > > > > > > > > > -----Original Message----- > > > > From: Akhil Goyal > > > > Sent: Thursday, April 18, 2019 7:21 PM > > > > To: Bernard Iremonger ; dev@dpdk.org; > > > > konstantin.ananyev@intel.com > > > > Cc: stable@dpdk.org > > > > Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dr= opped > > for > > > > inline crypto > > > > > > > > Hi Bernard, > > > > > > > > > - RTE_LOG_DP(DEBUG, IPSEC, "Create session for SA spi %u on > > cryptodev " > > > > > - "%u qp %u\n", sa->spi, > > > > > - ipsec_ctx->tbl[cdev_id_qp].id, > > > > > - ipsec_ctx->tbl[cdev_id_qp].qp); > > > > > + if ((sa =3D=3D NULL) || (pool =3D=3D NULL)) > > > > > + return -EINVAL; > > > > > > > > > > - if (sa->type !=3D RTE_SECURITY_ACTION_TYPE_NONE) { > > > > > - struct rte_security_session_conf sess_conf =3D { > > > > > + struct rte_security_session_conf sess_conf =3D { > > > > > .action_type =3D sa->type, > > > > > .protocol =3D RTE_SECURITY_PROTOCOL_IPSEC= , > > > > > {.ipsec =3D { > > > > > @@ -90,247 +65,340 @@ create_session(struct ipsec_ctx *ipsec_ctx, > > struct > > > > > ipsec_sa *sa) > > > > > } }, > > > > > .crypto_xform =3D sa->xforms, > > > > > .userdata =3D NULL, > > > > > - > > > > > }; > > > > > > > > > > - if (sa->type =3D=3D > > > > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) > > > > > { > > > > > - struct rte_security_ctx *ctx =3D (struct = rte_security_ctx *) > > > > > - rte_crypt= odev_get_sec_ctx( > > > > > - ipsec_ctx= ->tbl[cdev_id_qp].id); > > > > > - > > > > > - /* Set IPsec parameters in conf */ > > > > > - set_ipsec_conf(sa, &(sess_conf.ipsec)); > > > > > - > > > > > - sa->sec_session =3D rte_security_session_= create(ctx, > > > > > - &sess_conf, ipsec_ctx->se= ssion_pool); > > > > > - if (sa->sec_session =3D=3D NULL) { > > > > > - RTE_LOG(ERR, IPSEC, > > > > > - "SEC Session init failed: err: %d= \n", ret); > > > > > - return -1; > > > > > - } > > > > > - } else if (sa->type =3D=3D > > RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO) > > > > { > > > > > - struct rte_flow_error err; > > > > > - struct rte_security_ctx *ctx =3D (struct = rte_security_ctx *) > > > > > - rte_eth_d= ev_get_sec_ctx( > > > > > - sa->porti= d); > > > > > - const struct rte_security_capability *sec= _cap; > > > > > - int ret =3D 0; > > > > > - > > > > > - sa->sec_session =3D rte_security_session_= create(ctx, > > > > > - &sess_conf, ipsec_ctx->se= ssion_pool); > > > > > - if (sa->sec_session =3D=3D NULL) { > > > > > - RTE_LOG(ERR, IPSEC, > > > > > - "SEC Session init failed: err: %d= \n", ret); > > > > > - return -1; > > > > > - } > > > > > + if (sa->type =3D=3D > > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) { > > > > > + ctx =3D (struct rte_security_ctx *) > > > > > + rte_eth_dev_get_sec_ctx(sa->porti= d); > > > > > > > > This is breaking the lookaside mode. Ctx was retrieved using the ip= sec_ctx- > > >tbl > > > > struct rte_security_ctx *ctx =3D (struct rte_security_ctx *) > > > > rte_cryptodev_get_sec_ctx( > > > > ipsec_ctx->tbl[cdev_id_qp].id); > > > > > > > > I am looking into it, but I don't have time left to get it integrat= ed in RC2. So > > this > > > > has to be pushed to RC3 > > > > > > It looks like there are multiple issues in this patch wrt lookaside a= nd none cases. > > Only the inline cases seem to be working. > > > > > > 1. the patch removes the cdev_mapping concept completely. Cdev_id_qp = is > > not getting used. > > > > Not exactly. > > cdev_id_qp is still setup, and is still used to decide to which crypto-= dev to > > enqueuer the crypto-op: > > ipsec_enqueue(...) > > { > > ... > > enqueue_cop(&ipsec_ctx->tbl[sa->cdev_id_qp], &priv->cop); >=20 > I don't see anybody filling "sa->cdev_id_qp". Please let me know if I hav= e missed it somewhere. > It is memset to 0 I guess. Yep, true we lost it somewhere during the rework. =20 >=20 > > > > > > Same in ipsec_process(). > > > > For initialization, yes cdev_id_qp is not used anymore. > > As discussed here: > > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fmai= ls.dp > > dk.org%2Farchives%2Fdev%2F2019- > > March%2F127725.html&data=3D02%7C01%7Cakhil.goyal%40nxp.com%7C04 > > 194193cfc04c0b629008d6c7eea247%7C686ea1d3bc2b4c6fa92cd99c5c301635% > > 7C0%7C0%7C636916225072561313&sdata=3Dga9IiqhYRWOz9QkRDIXNiigInk > > soVGgu1E5EetqvE%2FA%3D&reserved=3D0 > > > > I think the problem you are hitting with lookaside-proto is that for it > > we use 2 different values here: > > a) In create_sec_session we use portid (it also should be > > rte_cryptodev_get_sec_ctx() here) > > if (sa->type =3D=3D RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) { > > ctx =3D (struct rte_security_ctx *) > > rte_eth_dev_get_sec_ctx(sa->portid); > It should be rte_cryptodev_get_sec_ctx in the first place. And it needs a= cdev_id as input based on the cdev mapping done while initializing > the cryptodev and neither the portid and nor cdev_id_qp. > > b) in enqueue() we use cdev_id_qp > > > > Right now these values could be different. > > As I understand we need to make sure that fro lookaside-proto cdev_id_q= p =3D=3D > > portid provided by user, correct? > No it is not the case. Right now for lookaside there is no use of portid = in case of lookaside case. > As the cdev/qp/core mappings are managed internally and the user cannot t= weak it from cfg file. >=20 Hmm, then at least that line is wrong here: https://doc.dpdk.org/guides/sample_app_ug/ipsec_secgw.html sa out 5 cipher_algo aes-128-cbc cipher_key 0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0= \ auth_algo sha1-hmac auth_key 0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0 \ mode ipv4-tunnel src 172.16.1.5 dst 172.16.2.5 \ type lookaside-protocol-offload port_id 4 And probably: "Port/device ID of the ethernet/crypto accelerator for which the SA is conf= igured." Need to be rephrased to remove crypto accelerator notice. Another question - why you guys don't consider using portid for lookaside-p= roto? As I can see add_mapping(function that fills cdev_id_qp) doesn't bother to= check which rte_security protocols are supported (only crypto capabilities are ch= ecked). So not sure does current code will work ok with a mix of lookaside-none/loo= kaside-proto devices. Forcing user to specify crypto-dev id for lookaside-proto (via portid or so= ) will simplify things significantly.=20 Konstantin