Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_gcm: add dependency version check

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Apr 23, 2019 at 03:38:58PM +0100, De Lara Guarch, Pablo wrote:
> 
> 
> > -----Original Message-----
> > From: Richardson, Bruce
> > Sent: Friday, April 19, 2019 11:01 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty,
> > Declan <declan.doherty@intel.com>; Richardson, Bruce
> > <bruce.richardson@intel.com>
> > Subject: [PATCH 1/2] crypto/aesni_gcm: add dependency version check
> > 
> > The aesni_mb driver and the aesni_gcm driver both require the same version
> > of the IPSec_MB library, but only the former has a check of the library found
> > to see if it's the correct version. Add a similar check to the aesni_gcm
> > library's meson.build file, so that the auto-detection of dependencies works
> > correctly.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/drivers/crypto/aesni_gcm/meson.build
> > b/drivers/crypto/aesni_gcm/meson.build
> > index 70f57ad73..7183cfcba 100644
> > --- a/drivers/crypto/aesni_gcm/meson.build
> > +++ b/drivers/crypto/aesni_gcm/meson.build
> 
> The patch looks good, but we should broaden its scope and also modify the Makefile,
> to check for the library version, like in the aesni_mb PMD.
> 
> Could you add that check too?
> 
I thought about doing so, but decided not to do so because the driver isn't
enabled by default. Therefore the default out-of-the-box build is not
broken when using an old version, as it is with meson. That being said,
I'll look to see if the aesni_mb checks can be easiest ported over for a
V2.

Regards,
/Bruce