From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3E7BFA05D3 for ; Tue, 23 Apr 2019 16:45:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBFEB1B399; Tue, 23 Apr 2019 16:45:31 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4B36C69D4 for ; Tue, 23 Apr 2019 16:45:30 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP; 23 Apr 2019 07:45:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,386,1549958400"; d="scan'208";a="136664908" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by orsmga008.jf.intel.com with SMTP; 23 Apr 2019 07:45:27 -0700 Received: by (sSMTP sendmail emulation); Tue, 23 Apr 2019 15:45:26 +0100 Date: Tue, 23 Apr 2019 15:45:25 +0100 From: Bruce Richardson To: "De Lara Guarch, Pablo" Cc: "dev@dpdk.org" , "Doherty, Declan" Message-ID: <20190423144525.GA1859@bricha3-MOBL.ger.corp.intel.com> References: <20190419100113.31284-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_gcm: add dependency version check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423144525.qUkQ8OQEQJSmS3KYXtFhAi9Nx7i7AxLeTB1eGC9xrYM@z> On Tue, Apr 23, 2019 at 03:38:58PM +0100, De Lara Guarch, Pablo wrote: > > > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Friday, April 19, 2019 11:01 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Doherty, > > Declan ; Richardson, Bruce > > > > Subject: [PATCH 1/2] crypto/aesni_gcm: add dependency version check > > > > The aesni_mb driver and the aesni_gcm driver both require the same version > > of the IPSec_MB library, but only the former has a check of the library found > > to see if it's the correct version. Add a similar check to the aesni_gcm > > library's meson.build file, so that the auto-detection of dependencies works > > correctly. > > > > Signed-off-by: Bruce Richardson > > --- > > drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/crypto/aesni_gcm/meson.build > > b/drivers/crypto/aesni_gcm/meson.build > > index 70f57ad73..7183cfcba 100644 > > --- a/drivers/crypto/aesni_gcm/meson.build > > +++ b/drivers/crypto/aesni_gcm/meson.build > > The patch looks good, but we should broaden its scope and also modify the Makefile, > to check for the library version, like in the aesni_mb PMD. > > Could you add that check too? > I thought about doing so, but decided not to do so because the driver isn't enabled by default. Therefore the default out-of-the-box build is not broken when using an old version, as it is with meson. That being said, I'll look to see if the aesni_mb checks can be easiest ported over for a V2. Regards, /Bruce