From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 867F9A05D3 for ; Tue, 23 Apr 2019 17:53:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 707671B147; Tue, 23 Apr 2019 17:53:35 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 622E81B130; Tue, 23 Apr 2019 17:53:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 08:53:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,386,1549958400"; d="scan'208";a="318272474" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.33]) ([10.237.221.33]) by orsmga005.jf.intel.com with ESMTP; 23 Apr 2019 08:53:19 -0700 To: Andrew Rybchenko , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Cc: dev@dpdk.org, stable@dpdk.org, "Li, WenjieX A" , Stephen Hemminger References: <1555074753-9098-1-git-send-email-arybchenko@solarflare.com> <04bcdfba-420b-9d5e-6e10-9d8b6762c378@intel.com> <0362242f-a51a-b37b-a2e7-61f1c8bbea35@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: Date: Tue, 23 Apr 2019 16:53:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423155318.lIp5lHlYrxe40D_9CMHjak3oCyUneobp-srw5OJxlyQ@z> On 4/23/2019 4:44 PM, Andrew Rybchenko wrote: > On 4/23/19 6:04 PM, Ferruh Yigit wrote: >> On 4/23/2019 4:02 PM, Ferruh Yigit wrote: >>> On 4/12/2019 2:12 PM, Andrew Rybchenko wrote: >>>> Setting exact link speed makes sense if auto-negotiation is >>>> disabled. Fixed flag is required to disable auto-negotiation. >>> Hi Andrew, >>> >>> Fixed link speed is not supported by all PMDs and this change is breaking them >>> to set the speed in testpmd. > > Not all. sfc definitely supports it. > It looks like bnxt, e1000, igb support it as well. The ones we know for now as not supported are ixgbe and i40e. > >>> As long as device speed set correct, I believe the command doesn't really care >>> about if link mode is auto-negotiation or not. > > Sometimes it is really important to disable auto-negotiation. If this is the case, we should cover this option in testpmd, but perhaps as an extension to current command, like new parameter? > >>> I am for reverting this commit, is there any objection to revert it? >> cc'ing Wenjie who reported the issue. > > May be I misunderstood the purpose of the command. > Typically if someone wants to set link speed, it is assumed that > auto-negotiation should be disabled since user specifies what he really > wants. > Of course, it is still valid request to keep auto-negotiation enabled, but > limit set of advertised speeds (may be keep only one). I think the purpose of the command is not clear, and what you said makes sense, only it is breaking the some PMDs is problem I think. > > So, I'm not happy to revert it completely. There is an option to revert > to old > behaviour and add optional argument to disable auto-negotiation, but I > can't say that I like it, since it would make sense if the command > allows more > than one speed to be advertised (to be auto-negotiated). If it is only > one speed, > the default should be autoneg disabled. Indeed I was suggesting same thing above, I didn't get the problem with this approach, if the 'fixed' arg added it will work as you suggested, single fixed speed value. > > Anyway documentation of the command should be improved. > > Andrew. > >>>> Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Andrew Rybchenko >>>> --- >>>> app/test-pmd/cmdline.c | 12 ++++++------ >>>> 1 file changed, 6 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >>>> index 2ab03c111..691d818a6 100644 >>>> --- a/app/test-pmd/cmdline.c >>>> +++ b/app/test-pmd/cmdline.c >>>> @@ -1440,17 +1440,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed) >>>> return -1; >>>> } >>>> if (!strcmp(speedstr, "1000")) { >>>> - *speed = ETH_LINK_SPEED_1G; >>>> + *speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED; >>>> } else if (!strcmp(speedstr, "10000")) { >>>> - *speed = ETH_LINK_SPEED_10G; >>>> + *speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED; >>>> } else if (!strcmp(speedstr, "25000")) { >>>> - *speed = ETH_LINK_SPEED_25G; >>>> + *speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED; >>>> } else if (!strcmp(speedstr, "40000")) { >>>> - *speed = ETH_LINK_SPEED_40G; >>>> + *speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED; >>>> } else if (!strcmp(speedstr, "50000")) { >>>> - *speed = ETH_LINK_SPEED_50G; >>>> + *speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED; >>>> } else if (!strcmp(speedstr, "100000")) { >>>> - *speed = ETH_LINK_SPEED_100G; >>>> + *speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED; >>>> } else if (!strcmp(speedstr, "auto")) { >>>> *speed = ETH_LINK_SPEED_AUTONEG; >>>> } else { >>>> >