From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2BF06A05D3 for ; Tue, 23 Apr 2019 18:23:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05DA6325F; Tue, 23 Apr 2019 18:23:41 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id A6A643253 for ; Tue, 23 Apr 2019 18:23:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 09:23:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,386,1549958400"; d="scan'208";a="133703954" Received: from unknown (HELO [10.241.225.81]) ([10.241.225.81]) by orsmga007.jf.intel.com with ESMTP; 23 Apr 2019 09:18:37 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, anand.rawat@intel.com References: <20190410210049.11416-1-pallavi.kadam@intel.com> <2405978.gfNxMDCiSY@xps> From: Pallavi Kadam Message-ID: Date: Tue, 23 Apr 2019 09:18:37 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2405978.gfNxMDCiSY@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] doc: update release notes for windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423161837.GHcoHn5XdhysRuWBNHpVpx6LZSXhFJBv7DEo8KXpGlw@z> On 4/22/2019 3:42 PM, Thomas Monjalon wrote: > 10/04/2019 23:00, Pallavi Kadam: >> Added documentation for Windows support on 19.05 release. >> >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Anand Rawat >> --- >> +* **Added Windows Support.** >> + >> + * Added Windows support to compile and build Hello World Sample Application. >> + * Added Windows-specific EAL changes and meson changes. >> + * Added windows support for kvargs. > You forgot the uppercase for Windows. > >> + * Updated meson for building DLL on windows using DEF files. >> + * Added rte_os.h for essential os specific macros and typedefs >> + * Updated make build system to include path for rte_os.h. > I think this is too much details for a release notes. > The useful information here is the first item explaining the > support level is for compiling helloworld. Ok, will reduce it in v2.