From: Stephen Hemminger <stephen@networkplumber.org>
To: bruce.richardson@intel.com
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 2/4] net/ring: use sizeof() with snprintf
Date: Tue, 23 Apr 2019 09:48:10 -0700 [thread overview]
Message-ID: <20190423164812.3427-3-stephen@networkplumber.org> (raw)
Message-ID: <20190423164810.YSLFPuQ2FBsho90sNSj05TH8lOjW-x-4Jn0PQb60JDs@z> (raw)
In-Reply-To: <20190423164812.3427-1-stephen@networkplumber.org>
Don't hard code string length in two place; use sizeof() instead.
Ring name shoudl use RTE_RING_NAMESIZE.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/ring/rte_eth_ring.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 91e5f5f8f262..2e4ca3b16a1c 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -362,8 +362,8 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
.numa_node = numa_node,
.addr = &args,
};
- char args_str[32] = { 0 };
- char ring_name[32] = { 0 };
+ char args_str[32];
+ char ring_name[RTE_RING_NAMESIZE];
uint16_t port_id = RTE_MAX_ETHPORTS;
int ret;
@@ -381,8 +381,9 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
return -1;
}
- snprintf(args_str, 32, "%s=%p", ETH_RING_INTERNAL_ARG, &args);
- snprintf(ring_name, 32, "net_ring_%s", name);
+ snprintf(args_str, sizeof(args_str), "%s=%p",
+ ETH_RING_INTERNAL_ARG, &args);
+ snprintf(ring_name, sizeof(ring_name), "net_ring_%s", name);
ret = rte_vdev_init(ring_name, args_str);
if (ret) {
--
2.20.1
next prev parent reply other threads:[~2019-04-23 16:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 16:48 [dpdk-dev] [PATCH 0/4] net/ring: driver fixes Stephen Hemminger
2019-04-23 16:48 ` Stephen Hemminger
2019-04-23 16:48 ` [dpdk-dev] [PATCH 1/4] net/ring: fix coding style Stephen Hemminger
2019-04-23 16:48 ` Stephen Hemminger
2019-04-23 16:48 ` Stephen Hemminger [this message]
2019-04-23 16:48 ` [dpdk-dev] [PATCH 2/4] net/ring: use sizeof() with snprintf Stephen Hemminger
2019-04-23 16:48 ` [dpdk-dev] [PATCH 3/4] net/ring: use rte_calloc_socket Stephen Hemminger
2019-04-23 16:48 ` Stephen Hemminger
2019-04-23 16:48 ` [dpdk-dev] [PATCH 4/4] net/ring: check length of ring name Stephen Hemminger
2019-04-23 16:48 ` Stephen Hemminger
2019-04-23 16:53 ` [dpdk-dev] [PATCH v2 0/4] net/ring: driver fixes Stephen Hemminger
2019-04-23 16:53 ` Stephen Hemminger
2019-04-23 16:53 ` [dpdk-dev] [PATCH v2 1/4] net/ring: fix coding style Stephen Hemminger
2019-04-23 16:53 ` Stephen Hemminger
2019-04-23 16:53 ` [dpdk-dev] [PATCH v2 2/4] net/ring: use sizeof() with snprintf Stephen Hemminger
2019-04-23 16:53 ` Stephen Hemminger
2019-04-23 16:53 ` [dpdk-dev] [PATCH v2 3/4] net/ring: use rte_calloc_socket Stephen Hemminger
2019-04-23 16:53 ` Stephen Hemminger
2019-04-23 16:53 ` [dpdk-dev] [PATCH v2 4/4] net/ring: check length of ring name Stephen Hemminger
2019-04-23 16:53 ` Stephen Hemminger
2019-04-24 16:47 ` [dpdk-dev] [PATCH v2 0/4] net/ring: driver fixes Ferruh Yigit
2019-04-24 16:47 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423164812.3427-3-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).