Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

["Pei, Andy" <andy.pei@intel.com>]

Hi,

I saw Qiang's patch on patchwork today,
[v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

So I think it seems OK to ignore my patch.



-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net] 
Sent: Tuesday, April 23, 2019 4:45 PM
To: Pei, Andy <andy.pei@intel.com>
Cc: Xu, Rosen <rosen.xu@intel.com>; stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>; liq3ea@163.com
Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

When you need to re-send a patch, please apply it with "git am"
so the original author is kept.

Another nit: the title is full of abbreviation, it is hard to read.
The title prefix should be "raw/ifpga", even if checkpatch complains.

Please re-send, thanks.


23/04/2019 03:36, Xu, Rosen:
> Hi Thomas,
> 
> Qian has some problem with his email. So some patch can't be found in patch work.
> For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks.
> 
> > -----Original Message-----
> > From: Pei, Andy
> > Sent: Tuesday, April 23, 2019 9:19
> > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Rosen 
> > <rosen.xu@intel.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko 
> > <marko.kovacevic@intel.com>; liq3ea@163.com
> > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak 
> > in rte fpga do pr
> > 
> > Hi Thomas,
> > 
> > My patch is the same as LI Qiang's patch.
> > I was told that Qiang's patch cannot get onto the patchwork, so I 
> > just help him do this.
> > 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Tuesday, April 23, 2019 1:52 AM
> > To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko 
> > <marko.kovacevic@intel.com>; liq3ea@163.com
> > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak 
> > in rte fpga do pr
> > 
> > > > In rte_fpga_do_pr() function, if 'stat' returns error,
> > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' 
> > > > that has been opened.
> > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() 
> > > > returns -EINVAL when 'stat' returns error
> > > >
> > > > Coverity issue: 279441
> > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev 
> > > > driver")
> > > > Cc: rosen.xu@intel.com
> > > > Cc: marko.kovacevic@intel.com
> > > > Cc: liq3ea@163.com
> > > > Cc: andy.pei@intel.com
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Andy Pei <andy.pei@intel.com>
> > >
> > > Acked-by: Rosen Xu <rosen.xu@intel.com>
> > 
> > Li Qiang <liq3ea@163.com> proposed the same patch.
> > Why he is not referenced here?
> > Which patch should I merge?