From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D9B11A05D3 for ; Wed, 24 Apr 2019 10:56:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F34391B518; Wed, 24 Apr 2019 10:56:08 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 07A341B511 for ; Wed, 24 Apr 2019 10:56:07 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 01:56:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="143177098" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by fmsmga008.fm.intel.com with SMTP; 24 Apr 2019 01:56:05 -0700 Received: by (sSMTP sendmail emulation); Wed, 24 Apr 2019 09:56:04 +0100 Date: Wed, 24 Apr 2019 09:56:03 +0100 From: Bruce Richardson To: Peng Huang Cc: maintainer@dpdk.org, dev@dpdk.org Message-ID: <20190424085603.GC1871@bricha3-MOBL.ger.corp.intel.com> References: <1556093889-446674-1-git-send-email-peng.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1556093889-446674-1-git-send-email-peng.huang@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [DPDK] changed default-target from linux to linuxapp for back-compatibility of validate-abi.sh X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190424085603.718H7FEh7WBxg1ijVzuDTJUhvyKZ6jKmFPyRdeo1WJg@z> On Wed, Apr 24, 2019 at 08:18:09AM +0000, Peng Huang wrote: > Signed-off-by: Peng Huang > --- I think you need a fuller description of the problem here - that although "linux" is the new target name, we still need to use "linuxapp" for testing historical versions. Fixes tag also needed. /Bruce > devtools/validate-abi.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devtools/validate-abi.sh b/devtools/validate-abi.sh > index 54df2e4..138436d 100755 > --- a/devtools/validate-abi.sh > +++ b/devtools/validate-abi.sh > @@ -9,7 +9,7 @@ set -e > abicheck=abi-compliance-checker > abidump=abi-dumper > default_dst=abi-check > -default_target=x86_64-native-linux-gcc > +default_target=x86_64-native-linuxapp-gcc > > # trap on error > err_report() { > --