From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C6407A05D3 for ; Wed, 24 Apr 2019 11:22:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8CF81B526; Wed, 24 Apr 2019 11:22:07 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id DF7581B4FB for ; Wed, 24 Apr 2019 11:22:05 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id q16so3629765wmj.3 for ; Wed, 24 Apr 2019 02:22:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=zxvQ+nibNYCvvb1553t/qeOwjt6YyhvxJla26aIsuw0=; b=ZSlXqLB1LWpkHJZirB2jD8BuNMceDas6XAgrvR7OsXDMN0FpxWbYiL7OS81IDeRMtD lxIXia9e9exPMFQY/QeKeN1EtLQrjdlbK5N92AFgwm43t9R3Mn2vasHMVWzadkT8+OFZ DfFolp6oONHVn9g0NFXMyBn0RAw4dzWS10UJiahrwrpiNV0Vr3Fjc1vKHfSZY+n/bB5Y S8TzzC1aczCDV9TbZubej/AWvvnEdMt8KTdzUzjBLzyPT96wpQHyl62iFLvB2RA0xVzC UQV2gIgnKGDWipC6ZbDRJodsVca1jK4EL7TyOEm0EJMJ/8dAv7t4GdXcsoZEQB34sQcw eJoQ== X-Gm-Message-State: APjAAAV3oGGYHOx83miIw1Ls40hSGHuuBmlcm9pAw0N8wefoRtcotlX7 t5gfX56pb3FyfVJIHTZfG68= X-Google-Smtp-Source: APXvYqyUXsuU43sxbwXGGFX/esl5xYSeTXJ9sEqYu6PlRW29FgvDcHDpSBCyfNnE7lYVUEDZwXd9SQ== X-Received: by 2002:a1c:7d92:: with SMTP id y140mr5614561wmc.54.1556097725492; Wed, 24 Apr 2019 02:22:05 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id v184sm28421236wma.6.2019.04.24.02.22.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 02:22:04 -0700 (PDT) Message-ID: <8e3b35cd842729263299466a5cfb34f37d6dd729.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Wed, 24 Apr 2019 10:22:04 +0100 In-Reply-To: <20190423220644.54589-4-bruce.richardson@intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190423220644.54589-4-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190424092204.vvQ2cpt4sFjqM_lIHa9_PXfmY5qE233SDh1E0VzP6QE@z> On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > The pkg-config file generated as part of the build of DPDK should > allow > applications to be built with an installed DPDK. We can test this as > part of the build by doing an install of DPDK to a temporary > directory > within the build folder, and by then compiling up a few sample apps > using make working off that directory. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > devtools/test-meson-builds.sh | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > builds.sh > index 630a1a6fe..dfba2a782 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -90,3 +90,20 @@ if command -v $c >/dev/null 2>&1 ; then > $use_shared --cross-file $f > done > fi > + > +############## > +# Test installation of the x86-default target, to be used for > checking > +# the sample apps build using the pkg-config file for cflags and > libs > +############### > +build_path=3Dbuild-x86-default > +DESTDIR=3D`pwd`/$build_path/install-root ; export DESTDIR > +PKG_CONFIG_PATH=3D$DESTDIR/usr/local/lib64/pkgconfig ; export > PKG_CONFIG_PATH > +$ninja_cmd -C $build_path install > + > +# rather than hacking our environment, just edit the .pc file prefix > value > +sed -i "s|prefix=3D|prefix=3D$DESTDIR|" $PKG_CONFIG_PATH/libdpdk.pc What about just using meson's prefix option instead? Which is how it would be used in a real use case > +for example in helloworld l2fwd l3fwd skeleton timer; do > + echo "## Building $example" > + make -C $DESTDIR/usr/local/share/dpdk/examples/$example > +done >=20 --=20 Kind regards, Luca Boccassi