From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B4CE7A05D3 for ; Wed, 24 Apr 2019 12:39:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C328E1B431; Wed, 24 Apr 2019 12:39:02 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6C0691B427 for ; Wed, 24 Apr 2019 12:39:01 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 03:39:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="340317370" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by fmsmga005.fm.intel.com with SMTP; 24 Apr 2019 03:38:58 -0700 Received: by (sSMTP sendmail emulation); Wed, 24 Apr 2019 11:38:57 +0100 Date: Wed, 24 Apr 2019 11:38:57 +0100 From: Bruce Richardson To: Luca Boccassi Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org Message-ID: <20190424103857.GA1885@bricha3-MOBL.ger.corp.intel.com> References: <20190423154357.29877-1-bruce.richardson@intel.com> <20190423154357.29877-2-bruce.richardson@intel.com> <8b22d3442a857ddf747d38de63c57e5d68f7b1e9.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <8b22d3442a857ddf747d38de63c57e5d68f7b1e9.camel@debian.org> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190424103857.YFpIDjxmYV2Y3knSpdIjrvYxz3fU0lsWWjcGNxt2Ano@z> On Wed, Apr 24, 2019 at 10:19:20AM +0100, Luca Boccassi wrote: > On Tue, 2019-04-23 at 16:43 +0100, Bruce Richardson wrote: > > The aesni_mb driver and the aesni_gcm driver both require the same > > version > > of the IPSec_MB library, but only the former has a check of the > > library > > found by meson to see if it's the correct version. Add a similar > > check to > > the aesni_gcm library's meson.build file, so that the auto-detection > > of > > dependencies works correctly. > > > > Signed-off-by: Bruce Richardson < > > bruce.richardson@intel.com > > > > > --- > > drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/crypto/aesni_gcm/meson.build > > b/drivers/crypto/aesni_gcm/meson.build > > index 70f57ad73..7183cfcba 100644 > > --- a/drivers/crypto/aesni_gcm/meson.build > > +++ b/drivers/crypto/aesni_gcm/meson.build > > @@ -1,11 +1,22 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2018 Intel Corporation > > > > +IMB_required_ver = '0.52.0' > > lib = cc.find_library('IPSec_MB', required: false) > > if not lib.found() > > build = false > > else > > ext_deps += lib > > Shouldn't this be moved into a new else branch after the version check? > No, it's harmless where it is, since if build is set to false, the values set for sources, deps etc. are all ignored and reset for building the next driver in the list. /Bruce