From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 060161B427 for ; Wed, 24 Apr 2019 12:41:23 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 03:41:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="340317929" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by fmsmga005.fm.intel.com with SMTP; 24 Apr 2019 03:41:21 -0700 Received: by (sSMTP sendmail emulation); Wed, 24 Apr 2019 11:41:20 +0100 Date: Wed, 24 Apr 2019 11:41:19 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190424104119.GB1885@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190423220644.54589-4-bruce.richardson@intel.com> <8e3b35cd842729263299466a5cfb34f37d6dd729.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e3b35cd842729263299466a5cfb34f37d6dd729.camel@debian.org> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2019 10:41:24 -0000 On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > The pkg-config file generated as part of the build of DPDK should allow > > applications to be built with an installed DPDK. We can test this as > > part of the build by doing an install of DPDK to a temporary directory > > within the build folder, and by then compiling up a few sample apps > > using make working off that directory. > > > > Signed-off-by: Bruce Richardson < bruce.richardson@intel.com > > > > > --- devtools/test-meson-builds.sh | 17 +++++++++++++++++ 1 file > > changed, 17 insertions(+) > > > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > > builds.sh index 630a1a6fe..dfba2a782 100755 --- > > a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ > > -90,3 +90,20 @@ if command -v $c >/dev/null 2>&1 ; then $use_shared > > --cross-file $f done fi + +############## +# Test installation of the > > x86-default target, to be used for checking +# the sample apps build > > using the pkg-config file for cflags and libs +############### > > +build_path=build-x86-default +DESTDIR=`pwd`/$build_path/install-root ; > > export DESTDIR +PKG_CONFIG_PATH=$DESTDIR/usr/local/lib64/pkgconfig ; > > export PKG_CONFIG_PATH +$ninja_cmd -C $build_path install + +# rather > > than hacking our environment, just edit the .pc file prefix value +sed > > -i "s|prefix=|prefix=$DESTDIR|" $PKG_CONFIG_PATH/libdpdk.pc > > What about just using meson's prefix option instead? Which is how it > would be used in a real use case > I don't think that would fully work, as my understanding is that the prefix option would apply only to the /usr/local parts, but not to the kernel modules which would still try and install in /lib/. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E4976A05D3 for ; Wed, 24 Apr 2019 12:41:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABC4F1B431; Wed, 24 Apr 2019 12:41:25 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 060161B427 for ; Wed, 24 Apr 2019 12:41:23 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 03:41:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="340317929" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by fmsmga005.fm.intel.com with SMTP; 24 Apr 2019 03:41:21 -0700 Received: by (sSMTP sendmail emulation); Wed, 24 Apr 2019 11:41:20 +0100 Date: Wed, 24 Apr 2019 11:41:19 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190424104119.GB1885@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190423220644.54589-4-bruce.richardson@intel.com> <8e3b35cd842729263299466a5cfb34f37d6dd729.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <8e3b35cd842729263299466a5cfb34f37d6dd729.camel@debian.org> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190424104119._-YX-97XACeF_LnrqhKCid82c9AI9DYUypOWMP_mp4Q@z> On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > The pkg-config file generated as part of the build of DPDK should allow > > applications to be built with an installed DPDK. We can test this as > > part of the build by doing an install of DPDK to a temporary directory > > within the build folder, and by then compiling up a few sample apps > > using make working off that directory. > > > > Signed-off-by: Bruce Richardson < bruce.richardson@intel.com > > > > > --- devtools/test-meson-builds.sh | 17 +++++++++++++++++ 1 file > > changed, 17 insertions(+) > > > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > > builds.sh index 630a1a6fe..dfba2a782 100755 --- > > a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ > > -90,3 +90,20 @@ if command -v $c >/dev/null 2>&1 ; then $use_shared > > --cross-file $f done fi + +############## +# Test installation of the > > x86-default target, to be used for checking +# the sample apps build > > using the pkg-config file for cflags and libs +############### > > +build_path=build-x86-default +DESTDIR=`pwd`/$build_path/install-root ; > > export DESTDIR +PKG_CONFIG_PATH=$DESTDIR/usr/local/lib64/pkgconfig ; > > export PKG_CONFIG_PATH +$ninja_cmd -C $build_path install + +# rather > > than hacking our environment, just edit the .pc file prefix value +sed > > -i "s|prefix=|prefix=$DESTDIR|" $PKG_CONFIG_PATH/libdpdk.pc > > What about just using meson's prefix option instead? Which is how it > would be used in a real use case > I don't think that would fully work, as my understanding is that the prefix option would apply only to the /usr/local parts, but not to the kernel modules which would still try and install in /lib/. /Bruce