From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0178CA05D3 for ; Wed, 24 Apr 2019 13:02:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84D681B506; Wed, 24 Apr 2019 13:02:27 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 09F958E76 for ; Wed, 24 Apr 2019 13:02:27 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id g3so24512283wrx.9 for ; Wed, 24 Apr 2019 04:02:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ywFiE8uDIVhf84Li4ItnSW9abgqwuF1mVpp/l4q2Tmw=; b=VFDrSGjW/b9Yq6Ucn9qw1o96QDWYU7TbZMODYhHZ/MB1PgQrF75wikhZdbwutlwELa zfhvAtGmUhjG9DZtDIwRELJuxba/3JD8wt86WczhftQ5Yy9lBn07OgvE4znhr5skHTc7 Ac2CNDjeVk2Urd4yBfUCn1sKn4n5jhI+hjHNLrxE49AGu8MhLxTZatmSFtPEOHbmhYWk /dypq5D2IOUBsOfRss6sOXWJndKFKQ2zTgKAobGUFym0iJU5Rk3ZrTWfZbgGU+ZWdg/F wJRRisY7sY1I450I92HQdCQuglBZAPcWP/Q2VxIHn4HkgCnx/vMDLGTwe4QCcCwTVATn s/mg== X-Gm-Message-State: APjAAAVTQlem3qDMm5jR6r0aMMC4hy8Hker7dzbS7TzUq5+wQSB8WICF XOfVUjf4JlyFwQGOBh+vORQ= X-Google-Smtp-Source: APXvYqwrOX2gnSIOyuMVXjaZJAwkS3blln6JShcMWKZoA+HMfPCuk1q0KDi2f6bxiFlUZbvJ/OJV7g== X-Received: by 2002:a05:6000:2:: with SMTP id h2mr22399601wrx.76.1556103746590; Wed, 24 Apr 2019 04:02:26 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id z23sm15512491wma.0.2019.04.24.04.02.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 04:02:25 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org Date: Wed, 24 Apr 2019 12:02:24 +0100 In-Reply-To: <20190424104119.GB1885@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190423220644.54589-4-bruce.richardson@intel.com> <8e3b35cd842729263299466a5cfb34f37d6dd729.camel@debian.org> <20190424104119.GB1885@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190424110224.kLT_l6NfAJJqIQay5oAAlEuTvfSaW-9SHS2TFinQsaU@z> On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > > The pkg-config file generated as part of the build of DPDK should > > > allow > > > applications to be built with an installed DPDK. We can test this > > > as > > > part of the build by doing an install of DPDK to a temporary > > > directory > > > within the build folder, and by then compiling up a few sample > > > apps > > > using make working off that directory. > > >=20 > > > Signed-off-by: Bruce Richardson <=20 > > > bruce.richardson@intel.com > > >=20 > > >=20 > > > --- devtools/test-meson-builds.sh | 17 +++++++++++++++++ 1 file > > > changed, 17 insertions(+) > > >=20 > > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > > > builds.sh index 630a1a6fe..dfba2a782 100755 --- > > > a/devtools/test-meson-builds.sh +++ b/devtools/test-meson- > > > builds.sh @@ > > > -90,3 +90,20 @@ if command -v $c >/dev/null 2>&1 ; then > > > $use_shared > > > --cross-file $f done fi + +############## +# Test installation of > > > the > > > x86-default target, to be used for checking +# the sample apps > > > build > > > using the pkg-config file for cflags and libs +############### > > > +build_path=3Dbuild-x86-default +DESTDIR=3D`pwd`/$build_path/install- > > > root ; > > > export DESTDIR > > > +PKG_CONFIG_PATH=3D$DESTDIR/usr/local/lib64/pkgconfig ; > > > export PKG_CONFIG_PATH +$ninja_cmd -C $build_path install + +# > > > rather > > > than hacking our environment, just edit the .pc file prefix value > > > +sed > > > -i "s|prefix=3D|prefix=3D$DESTDIR|" $PKG_CONFIG_PATH/libdpdk.pc > >=20 > > What about just using meson's prefix option instead? Which is how > > it > > would be used in a real use case > >=20 >=20 > I don't think that would fully work, as my understanding is that the > prefix > option would apply only to the /usr/local parts, but not to the > kernel > modules which would still try and install in /lib/. >=20 > /Bruce What about doing a meson configure -Denable_kmods=3Dfalse before the ninja install? The modules are not needed for that test anyway, right? Alternatively, the kernel src dir could be symlinked in the build path, and the kernel_dir option could be used I'm just worried that the test should be as "realistic" as possible, to avoid missing something --=20 Kind regards, Luca Boccassi