From: Ido Goshen <Ido@cgstowernetworks.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ido Goshen <Ido@cgstowernetworks.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support
Date: Wed, 24 Apr 2019 11:31:13 +0000 [thread overview]
Message-ID: <1556105458-91997-1-git-send-email-ido@cgstowernetworks.com> (raw)
Message-ID: <20190424113113.3-PQ-iNBNQr-jpgzuFVELjdhOXu7XppD3Cb4mJiCOLQ@z> (raw)
From: Ido Goshen <ido@cgstowernetworks.com>
10BASE-T SFP+ copper transceivers become cheaper and popular
So far those were blocked by ixgbe as “unsupported”.
e.g.
eth_ixgbe_dev_init(): Unsupported SFP+ Module
eth_ixgbe_dev_init(): Hardware Initialization Failure: -19
EAL: Requested device 0000:0a:00.0 cannot be used
This patch expands the usage of allow_unsupported_sfp to be more general
and makes ixgbe more tolerant to unknown SFPs
Signed-off-by: Ido Goshen <ido@cgstowernetworks.com>
---
drivers/net/ixgbe/base/ixgbe_phy.c | 22 +++++++++++-----------
drivers/net/ixgbe/base/ixgbe_x550.c | 3 +++
2 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c
index dd118f9..ff96afc 100644
--- a/drivers/net/ixgbe/base/ixgbe_phy.c
+++ b/drivers/net/ixgbe/base/ixgbe_phy.c
@@ -1527,18 +1527,9 @@ s32 ixgbe_identify_sfp_module_generic(struct ixgbe_hw *hw)
if (hw->phy.type == ixgbe_phy_sfp_intel) {
status = IXGBE_SUCCESS;
} else {
- if (hw->allow_unsupported_sfp == true) {
- EWARN(hw,
- "WARNING: Intel (R) Network Connections are quality tested using Intel (R) Ethernet Optics. "
- "Using untested modules is not supported and may cause unstable operation or damage to the module or the adapter. "
- "Intel Corporation is not responsible for any harm caused by using untested modules.\n");
- status = IXGBE_SUCCESS;
- } else {
- DEBUGOUT("SFP+ module not supported\n");
- hw->phy.type =
+ hw->phy.type =
ixgbe_phy_sfp_unsupported;
- status = IXGBE_ERR_SFP_NOT_SUPPORTED;
- }
+ status = IXGBE_ERR_SFP_NOT_SUPPORTED;
}
} else {
status = IXGBE_SUCCESS;
@@ -1546,6 +1537,15 @@ s32 ixgbe_identify_sfp_module_generic(struct ixgbe_hw *hw)
}
out:
+ if (status == IXGBE_ERR_SFP_NOT_SUPPORTED &&
+ hw->allow_unsupported_sfp) {
+ PMD_INIT_LOG(WARNING,
+ "WARNING: Intel (R) Network Connections are quality tested using Intel (R) Ethernet Optics. "
+ "Using untested modules is not supported and may cause unstable operation or damage to the module or the adapter. "
+ "Intel Corporation is not responsible for any harm caused by using untested modules.\n");
+ hw->phy.type = ixgbe_phy_unknown;
+ status = IXGBE_SUCCESS;
+ }
return status;
err_read_i2c_eeprom:
diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c
index a920a14..212d9a0 100644
--- a/drivers/net/ixgbe/base/ixgbe_x550.c
+++ b/drivers/net/ixgbe/base/ixgbe_x550.c
@@ -1539,6 +1539,9 @@ STATIC s32 ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear)
*linear = false;
break;
case ixgbe_sfp_type_unknown:
+ if (hw->allow_unsupported_sfp)
+ return IXGBE_SUCCESS;
+ /* fall through */
case ixgbe_sfp_type_1g_cu_core0:
case ixgbe_sfp_type_1g_cu_core1:
default:
--
1.9.1
next reply other threads:[~2019-04-24 11:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 11:31 Ido Goshen [this message]
2019-04-24 11:31 ` Ido Goshen
2019-04-24 11:47 ` Ananyev, Konstantin
2019-04-24 11:47 ` Ananyev, Konstantin
2019-04-24 21:25 ` Ido Goshen
2019-04-24 21:25 ` Ido Goshen
2019-04-26 12:13 ` Ananyev, Konstantin
2019-04-26 12:13 ` Ananyev, Konstantin
2019-04-28 6:54 ` Ido Goshen
2019-04-28 6:54 ` Ido Goshen
2019-05-01 23:40 ` Ananyev, Konstantin
2019-05-01 23:40 ` Ananyev, Konstantin
2019-05-02 9:15 ` Ido Goshen
2019-05-02 9:15 ` Ido Goshen
2019-05-06 11:22 ` Igor Russkikh
2019-05-06 11:22 ` Igor Russkikh
2019-05-07 22:45 ` Stillwell Jr, Paul M
2019-05-07 22:45 ` Stillwell Jr, Paul M
2019-05-14 12:21 ` Igor Russkikh
2019-05-14 12:21 ` Igor Russkikh
2019-05-14 17:10 ` Ido Goshen
2019-05-14 17:10 ` Ido Goshen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556105458-91997-1-git-send-email-ido@cgstowernetworks.com \
--to=ido@cgstowernetworks.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).