From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 767941B534 for ; Thu, 25 Apr 2019 00:03:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 15:03:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,391,1549958400"; d="scan'208";a="164567729" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.212]) by fmsmga002.fm.intel.com with ESMTP; 24 Apr 2019 15:03:11 -0700 From: Ferruh Yigit To: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Cc: Andrew Rybchenko , WenjieX A Li , Thomas Monjalon Date: Wed, 24 Apr 2019 23:03:09 +0100 Message-Id: <20190424220309.84270-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2019 22:03:14 -0000 This reverts commit bdca79053b6aea504d02691d9319fa976062457f. Not all PMDs support the fixed link speed set, and link speed can be set even with auto negotiation enabled. Reverting the patch to not break existing usage. Signed-off-by: Ferruh Yigit --- Cc: Andrew Rybchenko Cc: WenjieX A Li Cc: Bernard Iremonger Cc: Thomas Monjalon --- app/test-pmd/cmdline.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index f45ef8a1c..c1042dd98 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1533,17 +1533,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed) return -1; } if (!strcmp(speedstr, "1000")) { - *speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_1G; } else if (!strcmp(speedstr, "10000")) { - *speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_10G; } else if (!strcmp(speedstr, "25000")) { - *speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_25G; } else if (!strcmp(speedstr, "40000")) { - *speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_40G; } else if (!strcmp(speedstr, "50000")) { - *speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_50G; } else if (!strcmp(speedstr, "100000")) { - *speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_100G; } else if (!strcmp(speedstr, "auto")) { *speed = ETH_LINK_SPEED_AUTONEG; } else { -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4B546A05D3 for ; Thu, 25 Apr 2019 00:03:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A5A51B54B; Thu, 25 Apr 2019 00:03:16 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 767941B534 for ; Thu, 25 Apr 2019 00:03:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 15:03:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,391,1549958400"; d="scan'208";a="164567729" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.212]) by fmsmga002.fm.intel.com with ESMTP; 24 Apr 2019 15:03:11 -0700 From: Ferruh Yigit To: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Cc: Andrew Rybchenko , WenjieX A Li , Thomas Monjalon Date: Wed, 24 Apr 2019 23:03:09 +0100 Message-Id: <20190424220309.84270-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190424220309.rmB3oQlVTR0hPgGTR2E6xID6VyfBzD_KcdDKMAvJdfQ@z> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. Not all PMDs support the fixed link speed set, and link speed can be set even with auto negotiation enabled. Reverting the patch to not break existing usage. Signed-off-by: Ferruh Yigit --- Cc: Andrew Rybchenko Cc: WenjieX A Li Cc: Bernard Iremonger Cc: Thomas Monjalon --- app/test-pmd/cmdline.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index f45ef8a1c..c1042dd98 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1533,17 +1533,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed) return -1; } if (!strcmp(speedstr, "1000")) { - *speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_1G; } else if (!strcmp(speedstr, "10000")) { - *speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_10G; } else if (!strcmp(speedstr, "25000")) { - *speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_25G; } else if (!strcmp(speedstr, "40000")) { - *speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_40G; } else if (!strcmp(speedstr, "50000")) { - *speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_50G; } else if (!strcmp(speedstr, "100000")) { - *speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED; + *speed = ETH_LINK_SPEED_100G; } else if (!strcmp(speedstr, "auto")) { *speed = ETH_LINK_SPEED_AUTONEG; } else { -- 2.20.1