DPDK patches and discussions
 help / color / mirror / Atom feed
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: herakliusz.lipiec@intel.com
Subject: [dpdk-dev] [PATCH 19.08 4/6] ipc: handle unsupported ipc in sendmsg
Date: Thu, 25 Apr 2019 13:45:17 +0100	[thread overview]
Message-ID: <8bfb0428de85290a8126dd0311a522aaed261fee.1556195690.git.anatoly.burakov@intel.com> (raw)
Message-ID: <20190425124517.foFlJrnPC-xMNM3jq4shCOvy7y82OPQCPxFdl4gQR64@z> (raw)
In-Reply-To: <b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com>
In-Reply-To: <b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com>

Currently, IPC API will silently ignore unsupported IPC.
Fix the API call and its callers to explicitly handle
unsupported IPC cases.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_eal/common/eal_common_proc.c | 6 ++++++
 lib/librte_eal/common/include/rte_eal.h | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index 4c062a306..0db842f84 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -792,6 +792,12 @@ rte_mp_sendmsg(struct rte_mp_msg *msg)
 	if (!check_input(msg))
 		return -1;
 
+	if (internal_config.no_shconf) {
+		RTE_LOG(DEBUG, EAL, "No shared files mode enabled, IPC is disabled\n");
+		rte_errno = ENOTSUP;
+		return -1;
+	}
+
 	RTE_LOG(DEBUG, EAL, "sendmsg: %s\n", msg->name);
 	return mp_send(msg, NULL, MP_MSG);
 }
diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h
index 7f807aa8e..d47cb2440 100644
--- a/lib/librte_eal/common/include/rte_eal.h
+++ b/lib/librte_eal/common/include/rte_eal.h
@@ -290,6 +290,9 @@ rte_mp_action_unregister(const char *name);
  * This function will send a message which will be responsed by the action
  * identified by name in the peer process.
  *
+ * @note IPC may be unsupported in certain circumstances, so caller should check
+ *    for ENOTSUP error.
+ *
  * @param msg
  *   The msg argument contains the customized message.
  *
-- 
2.17.1

  parent reply	other threads:[~2019-04-25 12:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25 12:45 [dpdk-dev] [PATCH 19.08 1/6] ipc: handle unsupported ipc in init Anatoly Burakov
2019-04-25 12:45 ` Anatoly Burakov
2019-04-25 12:45 ` [dpdk-dev] [PATCH 19.08 2/6] ipc: handle unsupported ipc in action register Anatoly Burakov
2019-04-25 12:45   ` Anatoly Burakov
2019-04-25 12:45 ` [dpdk-dev] [PATCH 19.08 3/6] ipc: don't unregister action if ipc unsupported Anatoly Burakov
2019-04-25 12:45   ` Anatoly Burakov
2019-04-25 12:45 ` Anatoly Burakov [this message]
2019-04-25 12:45   ` [dpdk-dev] [PATCH 19.08 4/6] ipc: handle unsupported ipc in sendmsg Anatoly Burakov
2019-04-25 12:45 ` [dpdk-dev] [PATCH 19.08 5/6] ipc: handle unsupported ipc in sync request Anatoly Burakov
2019-04-25 12:45   ` Anatoly Burakov
2019-04-25 12:45 ` [dpdk-dev] [PATCH 19.08 6/6] ipc: handle unsupported ipc in async request Anatoly Burakov
2019-04-25 12:45   ` Anatoly Burakov
2019-06-05  9:29 ` [dpdk-dev] [PATCH 19.08 1/6] ipc: handle unsupported ipc in init Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bfb0428de85290a8126dd0311a522aaed261fee.1556195690.git.anatoly.burakov@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=herakliusz.lipiec@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).