From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4E50FA05D3 for ; Thu, 25 Apr 2019 14:47:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFB701B5A8; Thu, 25 Apr 2019 14:47:48 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C052E1B5A8; Thu, 25 Apr 2019 14:47:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 05:47:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,393,1549958400"; d="scan'208";a="226589452" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.108]) ([10.237.220.108]) by orsmga001.jf.intel.com with ESMTP; 25 Apr 2019 05:47:44 -0700 To: Herakliusz Lipiec Cc: dev@dpdk.org, jianfeng.tan@intel.com, stable@dpdk.org References: <20190423174334.19612-1-herakliusz.lipiec@intel.com> <20190425114324.611-1-herakliusz.lipiec@intel.com> <20190425114324.611-2-herakliusz.lipiec@intel.com> From: "Burakov, Anatoly" Message-ID: <9c061f24-ab40-670d-0b7a-fe331ba8a3f2@intel.com> Date: Thu, 25 Apr 2019 13:47:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190425114324.611-2-herakliusz.lipiec@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] ipc: fix rte_mp_request_sync memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190425124743.1_XWdSdJymVodAPEPpg9r9JdHts1VXN6OzAOsLk3KlI@z> On 25-Apr-19 12:43 PM, Herakliusz Lipiec wrote: > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were sent and no > memory for response buffers was allocated, which is > not true. Fixed by always freeing memory buffers on > failure. > > Bugzilla ID: 228 > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > Cc: jianfeng.tan@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Herakliusz Lipiec > --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly