From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F19471B6EF for ; Fri, 26 Apr 2019 18:20:59 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 09:20:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,398,1549958400"; d="scan'208";a="294811542" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.15.248]) by orsmga004.jf.intel.com with SMTP; 26 Apr 2019 09:20:57 -0700 Received: by (sSMTP sendmail emulation); Fri, 26 Apr 2019 17:20:56 +0100 Date: Fri, 26 Apr 2019 17:20:56 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190426162056.GA1718@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 16:21:00 -0000 On Fri, Apr 26, 2019 at 05:11:18PM +0100, Luca Boccassi wrote: > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > As part of the meson build, a pkg-config file for libdpdk is created, > > which > > allows apps to be compiled and linked against DPDK by taking the > > cflags and > > lib parameter from pkgconfig. The example app makefiles have been > > reworked > > to take account of this support, but the build of them against the > > .pc file > > was not regularly tested. > > > > To rectify this, and give us greater confidence in the correctness of > > the > > .pc file, this set adds in the sample apps to the installation set > > for > > "ninja install" and then builds a subset of those apps against the > > pkg-config file to test it. In the process a small error when > > compiling > > the cmdline sample app using the .pc file was fixed. > > > > Bruce Richardson (4): > > examples: install examples as part of ninja install > > examples: simplify getting list of all examples > > devtools/test-meson-builds: add testing of pkg-config file > > build: add libbsd to pkg-config file if enabled > > > > config/meson.build | 10 ++++------ > > devtools/test-meson-builds.sh | 17 +++++++++++++++++ > > examples/meson.build | 17 +++++++++++++---- > > meson.build | 2 ++ > > 4 files changed, 36 insertions(+), 10 deletions(-) > > Series-acked-by: Luca Boccassi > Thanks. I've actually got a V2 coming soon with some more rework, since I found some more issues (especially on BSD) as I worked through the changes. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3C81AA05D3 for ; Fri, 26 Apr 2019 18:21:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C9E1B1B729; Fri, 26 Apr 2019 18:21:01 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F19471B6EF for ; Fri, 26 Apr 2019 18:20:59 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 09:20:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,398,1549958400"; d="scan'208";a="294811542" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.15.248]) by orsmga004.jf.intel.com with SMTP; 26 Apr 2019 09:20:57 -0700 Received: by (sSMTP sendmail emulation); Fri, 26 Apr 2019 17:20:56 +0100 Date: Fri, 26 Apr 2019 17:20:56 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20190426162056.GA1718@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190426162056.RjSXtf-dut5j9zpPqUJp0o-bZQ1dJZU3ajPuJ14NImY@z> On Fri, Apr 26, 2019 at 05:11:18PM +0100, Luca Boccassi wrote: > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > As part of the meson build, a pkg-config file for libdpdk is created, > > which > > allows apps to be compiled and linked against DPDK by taking the > > cflags and > > lib parameter from pkgconfig. The example app makefiles have been > > reworked > > to take account of this support, but the build of them against the > > .pc file > > was not regularly tested. > > > > To rectify this, and give us greater confidence in the correctness of > > the > > .pc file, this set adds in the sample apps to the installation set > > for > > "ninja install" and then builds a subset of those apps against the > > pkg-config file to test it. In the process a small error when > > compiling > > the cmdline sample app using the .pc file was fixed. > > > > Bruce Richardson (4): > > examples: install examples as part of ninja install > > examples: simplify getting list of all examples > > devtools/test-meson-builds: add testing of pkg-config file > > build: add libbsd to pkg-config file if enabled > > > > config/meson.build | 10 ++++------ > > devtools/test-meson-builds.sh | 17 +++++++++++++++++ > > examples/meson.build | 17 +++++++++++++---- > > meson.build | 2 ++ > > 4 files changed, 36 insertions(+), 10 deletions(-) > > Series-acked-by: Luca Boccassi > Thanks. I've actually got a V2 coming soon with some more rework, since I found some more issues (especially on BSD) as I worked through the changes. /Bruce