From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6949FA05D3 for ; Fri, 26 Apr 2019 18:22:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 27C301B736; Fri, 26 Apr 2019 18:22:46 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 278C41B6EF for ; Fri, 26 Apr 2019 18:22:44 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8D63D30A74FC; Fri, 26 Apr 2019 16:22:43 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-19.ams2.redhat.com [10.36.117.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7EDE15D717; Fri, 26 Apr 2019 16:22:42 +0000 (UTC) From: Kevin Traynor To: anatoly.burakov@intel.com, dev@dpdk.org Cc: Kevin Traynor Date: Fri, 26 Apr 2019 17:22:30 +0100 Message-Id: <20190426162230.21158-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 26 Apr 2019 16:22:43 +0000 (UTC) Subject: [dpdk-dev] [PATCH] vfio: expand non-viable group error message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190426162230.BUkqewmQysINbomFyEDaLpariG5Zfwe3xcmdCZaxZzY@z> "VFIO group is not viable" error message is correct but not very user friendly for something which can usually be easily rectified. Add some additional text to give more of a hint. Signed-off-by: Kevin Traynor --- lib/librte_eal/linux/eal/eal_vfio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c index 19e70bb66..6892a2c14 100644 --- a/lib/librte_eal/linux/eal/eal_vfio.c +++ b/lib/librte_eal/linux/eal/eal_vfio.c @@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr, return -1; } else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) { - RTE_LOG(ERR, EAL, " %s VFIO group is not viable!\n", dev_addr); + RTE_LOG(ERR, EAL, " %s VFIO group is not viable! " + "Not all devices in IOMMU group bound to VFIO or unbound\n", + dev_addr); close(vfio_group_fd); rte_vfio_clear_group(vfio_group_fd); -- 2.20.1