Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
> "VFIO group is not viable" error message is correct
> but not very user friendly for something which can
> usually be easily rectified.
> 
> Add some additional text to give more of a hint.
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
>   lib/librte_eal/linux/eal/eal_vfio.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c
> index 19e70bb66..6892a2c14 100644
> --- a/lib/librte_eal/linux/eal/eal_vfio.c
> +++ b/lib/librte_eal/linux/eal/eal_vfio.c
> @@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
>   		return -1;
>   	} else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) {
> -		RTE_LOG(ERR, EAL, "  %s VFIO group is not viable!\n", dev_addr);
> +		RTE_LOG(ERR, EAL, "  %s VFIO group is not viable! "
> +				"Not all devices in IOMMU group bound to VFIO or unbound\n",
> +				dev_addr);
>   		close(vfio_group_fd);
>   		rte_vfio_clear_group(vfio_group_fd);
> 

Come on, everyone knows /that/!

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly