DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] crypto/qat: fix NULL cipher algo for non 8-byte multiple
@ 2019-04-26 19:28 Fiona Trahe
  2019-04-26 19:28 ` Fiona Trahe
  2019-04-30 13:55 ` Akhil Goyal
  0 siblings, 2 replies; 4+ messages in thread
From: Fiona Trahe @ 2019-04-26 19:28 UTC (permalink / raw)
  To: dev
  Cc: thomas, akhil.goyal, arkadiuszx.kusztal, bernard.iremonger,
	Fiona Trahe, stable

NULL cipher algo of 4-byte multiple and other sizes caused firmware hang
due to use of wrong mode. Changed from ECB mode to CTR mode to fix.

Fixes: 98f060891615 ("crypto/qat: add symmetric session file")
cc: stable@dpdk.org

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 drivers/crypto/qat/qat_sym_session.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c
index 5cc86f554..f66175d03 100644
--- a/drivers/crypto/qat/qat_sym_session.c
+++ b/drivers/crypto/qat/qat_sym_session.c
@@ -242,7 +242,8 @@ qat_sym_session_configure_cipher(struct rte_cryptodev *dev,
 		session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
 		break;
 	case RTE_CRYPTO_CIPHER_NULL:
-		session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
+		session->qat_cipher_alg = ICP_QAT_HW_CIPHER_ALGO_NULL;
+		session->qat_mode = ICP_QAT_HW_CIPHER_CTR_MODE;
 		break;
 	case RTE_CRYPTO_CIPHER_KASUMI_F8:
 		if (qat_sym_validate_kasumi_key(cipher_xform->key.length,
-- 
2.13.6

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] crypto/qat: fix NULL cipher algo for non 8-byte multiple
  2019-04-26 19:28 [dpdk-dev] [PATCH] crypto/qat: fix NULL cipher algo for non 8-byte multiple Fiona Trahe
@ 2019-04-26 19:28 ` Fiona Trahe
  2019-04-30 13:55 ` Akhil Goyal
  1 sibling, 0 replies; 4+ messages in thread
From: Fiona Trahe @ 2019-04-26 19:28 UTC (permalink / raw)
  To: dev
  Cc: thomas, akhil.goyal, arkadiuszx.kusztal, bernard.iremonger,
	Fiona Trahe, stable

NULL cipher algo of 4-byte multiple and other sizes caused firmware hang
due to use of wrong mode. Changed from ECB mode to CTR mode to fix.

Fixes: 98f060891615 ("crypto/qat: add symmetric session file")
cc: stable@dpdk.org

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 drivers/crypto/qat/qat_sym_session.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c
index 5cc86f554..f66175d03 100644
--- a/drivers/crypto/qat/qat_sym_session.c
+++ b/drivers/crypto/qat/qat_sym_session.c
@@ -242,7 +242,8 @@ qat_sym_session_configure_cipher(struct rte_cryptodev *dev,
 		session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
 		break;
 	case RTE_CRYPTO_CIPHER_NULL:
-		session->qat_mode = ICP_QAT_HW_CIPHER_ECB_MODE;
+		session->qat_cipher_alg = ICP_QAT_HW_CIPHER_ALGO_NULL;
+		session->qat_mode = ICP_QAT_HW_CIPHER_CTR_MODE;
 		break;
 	case RTE_CRYPTO_CIPHER_KASUMI_F8:
 		if (qat_sym_validate_kasumi_key(cipher_xform->key.length,
-- 
2.13.6


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL cipher algo for non 8-byte multiple
  2019-04-26 19:28 [dpdk-dev] [PATCH] crypto/qat: fix NULL cipher algo for non 8-byte multiple Fiona Trahe
  2019-04-26 19:28 ` Fiona Trahe
@ 2019-04-30 13:55 ` Akhil Goyal
  2019-04-30 13:55   ` Akhil Goyal
  1 sibling, 1 reply; 4+ messages in thread
From: Akhil Goyal @ 2019-04-30 13:55 UTC (permalink / raw)
  To: Fiona Trahe, dev; +Cc: thomas, arkadiuszx.kusztal, bernard.iremonger, stable



> NULL cipher algo of 4-byte multiple and other sizes caused firmware hang
> due to use of wrong mode. Changed from ECB mode to CTR mode to fix.
> 
> Fixes: 98f060891615 ("crypto/qat: add symmetric session file")
> cc: stable@dpdk.org
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL cipher algo for non 8-byte multiple
  2019-04-30 13:55 ` Akhil Goyal
@ 2019-04-30 13:55   ` Akhil Goyal
  0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2019-04-30 13:55 UTC (permalink / raw)
  To: Fiona Trahe, dev; +Cc: thomas, arkadiuszx.kusztal, bernard.iremonger, stable



> NULL cipher algo of 4-byte multiple and other sizes caused firmware hang
> due to use of wrong mode. Changed from ECB mode to CTR mode to fix.
> 
> Fixes: 98f060891615 ("crypto/qat: add symmetric session file")
> cc: stable@dpdk.org
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-30 13:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-26 19:28 [dpdk-dev] [PATCH] crypto/qat: fix NULL cipher algo for non 8-byte multiple Fiona Trahe
2019-04-26 19:28 ` Fiona Trahe
2019-04-30 13:55 ` Akhil Goyal
2019-04-30 13:55   ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).