From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 78EEBA05D3 for ; Sat, 27 Apr 2019 20:53:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D74341B57D; Sat, 27 Apr 2019 20:53:19 +0200 (CEST) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by dpdk.org (Postfix) with ESMTP id B7AD41B57B for ; Sat, 27 Apr 2019 20:53:18 +0200 (CEST) Received: by mail-ed1-f68.google.com with SMTP id k92so3358772edc.12 for ; Sat, 27 Apr 2019 11:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PlssPjAebZOHLfFr/RoUYam9BRuuJu4U48mOTZNd8Uc=; b=dstTfu7ynbXmnVzKtHDDzRe9EOraUtR/G5YpHTAsGcFjGHfJQmz1LQ/0hk5xZ5/YKy 3JLZKN3iuBtK4WWJV+VdVp+KHZbcAspbPycwXqtvsr57CPzo07zEGZx6GtuIXBC7m74R AzRjD6YJACAxWtuWEy/wW24Nij1UGJsaonf+Gkeq2n/Astz4vpzbjkERczW5jYwU2r/L bNlqyZXTsJprXZ0ANjULVgWtjkKyyf+SGXoK+VXr3q4YztJW2hSGSSQG42mRVPTJVO86 2SivQpE2ekuaGo4P+M3ofJ6vQ9R0Lu+TGggL/CqWQyE9TYjYOGmJG3iwXZddvVI2rHE3 HTyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PlssPjAebZOHLfFr/RoUYam9BRuuJu4U48mOTZNd8Uc=; b=m81pUG3fwBsbxIlL+/c6SLEQ+9dhILL28+XyzhG1EM7SAWuNeLH+pBx/eWTDa3M8Jq nlAGBZEG2Q4LcZzvqZoazrc9PypAYMKO6kGmRLbEAZVx9W5n0kiWGTzdc/vk/5Adb5ZL aJaYpfLSGp60Obv1pHoKUZLu+6FRK6nnxZUqlEic07gzWS3/EOUscFlBPQke7WxsZpgh jHTQb6aYr9gku24pNT950chw8JXkOfnspV1ZVF1exgMHNvvnjvt+nDisw8lLNYiOuwxF XH5HvXcJMDAbe68lMl+wgqd3G5GXrQO2SuGp7CBc4Z7xZolJt+t8RtS53JWEr7qU8Lqj sgKA== X-Gm-Message-State: APjAAAXaD9PrGfo3c+i3IvcaDGHEB1MP1EXq7ZGbHGuXL8Hb9JdO33+7 r+bpj2JPVJjBHL+FzUfTpvZQhGqagXp1jFLsTFA= X-Google-Smtp-Source: APXvYqxIO0Nf/fX32UlcLVTS98to7R1xNehxwARZ7FhnQ+oA9T/YOINCkzmcEouwASxT4+70TgqBZVEZvgTTy/ls0LM= X-Received: by 2002:a17:906:e10e:: with SMTP id gj14mr4082324ejb.285.1556391198157; Sat, 27 Apr 2019 11:53:18 -0700 (PDT) MIME-Version: 1.0 References: <1556291662-16595-1-git-send-email-john.mcnamara@intel.com> In-Reply-To: <1556291662-16595-1-git-send-email-john.mcnamara@intel.com> From: Rami Rosen Date: Sat, 27 Apr 2019 21:53:07 +0300 Message-ID: To: John McNamara Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/2] doc: fix spelling errors reported by aspell X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190427185307.ynqFeTbAPPZ3iaILLFpzN8UcL7lTexBCvadoY71amq8@z> Hi John, Thanks for this patch set, it really makes DPDK documentation more refined. > -(for example the collectd plugin) should be run to begin querying the API. > +(for example the CollectD plugin) should be run to begin querying the API. I am not sure about this change to "CollectD". Actually from what I know, in official collectd/service assurance documenration, it always appear as "collectd plugin" or "Collectd plugin" (this is the usual semantics for unix/linux daemons). For example, https://blog.dbrgn.ch/2017/3/10/write-a-collectd-python-plugin/ https://wiki.opnfv.org/display/fastpath/Collectd+how+to+implement+a+simple+plugin https://collectd.org/documentation/manpages/collectd.conf.5.shtml If it agreed that change to CollectD should be reverted, not sure that a new V3 should be sent, this is a huge patch; if reverting can be done via merge, it will be better. Other than that, Acked-by: Rami Rosen > >