* [dpdk-dev] [PATCH] ipc: fix send error handling
@ 2019-04-26 10:27 Anatoly Burakov
2019-04-26 10:27 ` Anatoly Burakov
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Anatoly Burakov @ 2019-04-26 10:27 UTC (permalink / raw)
To: dev; +Cc: stable
According to manpage, ENOBUFS error indicates that either the
input or the output queue is full. This should be considered
an error, but it is treated as an "ignore" condition. Fix the
code to report an error instead.
Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/common/eal_common_proc.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index b46d644b3..f26a60595 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -678,11 +678,6 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int type)
unlink(dst_path);
return 0;
}
- if (errno == ENOBUFS) {
- RTE_LOG(ERR, EAL, "Peer cannot receive message %s\n",
- dst_path);
- return 0;
- }
RTE_LOG(ERR, EAL, "failed to send to (%s) due to %s\n",
dst_path, strerror(errno));
return -1;
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] ipc: fix send error handling
2019-04-26 10:27 [dpdk-dev] [PATCH] ipc: fix send error handling Anatoly Burakov
@ 2019-04-26 10:27 ` Anatoly Burakov
2019-04-28 7:43 ` Rami Rosen
2019-05-03 12:26 ` Thomas Monjalon
2 siblings, 0 replies; 6+ messages in thread
From: Anatoly Burakov @ 2019-04-26 10:27 UTC (permalink / raw)
To: dev; +Cc: stable
According to manpage, ENOBUFS error indicates that either the
input or the output queue is full. This should be considered
an error, but it is treated as an "ignore" condition. Fix the
code to report an error instead.
Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/common/eal_common_proc.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index b46d644b3..f26a60595 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -678,11 +678,6 @@ send_msg(const char *dst_path, struct rte_mp_msg *msg, int type)
unlink(dst_path);
return 0;
}
- if (errno == ENOBUFS) {
- RTE_LOG(ERR, EAL, "Peer cannot receive message %s\n",
- dst_path);
- return 0;
- }
RTE_LOG(ERR, EAL, "failed to send to (%s) due to %s\n",
dst_path, strerror(errno));
return -1;
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] ipc: fix send error handling
2019-04-26 10:27 [dpdk-dev] [PATCH] ipc: fix send error handling Anatoly Burakov
2019-04-26 10:27 ` Anatoly Burakov
@ 2019-04-28 7:43 ` Rami Rosen
2019-04-28 7:43 ` Rami Rosen
2019-05-03 12:26 ` Thomas Monjalon
2 siblings, 1 reply; 6+ messages in thread
From: Rami Rosen @ 2019-04-28 7:43 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, stable
Acked-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] ipc: fix send error handling
2019-04-28 7:43 ` Rami Rosen
@ 2019-04-28 7:43 ` Rami Rosen
0 siblings, 0 replies; 6+ messages in thread
From: Rami Rosen @ 2019-04-28 7:43 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, stable
Acked-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] ipc: fix send error handling
2019-04-26 10:27 [dpdk-dev] [PATCH] ipc: fix send error handling Anatoly Burakov
2019-04-26 10:27 ` Anatoly Burakov
2019-04-28 7:43 ` Rami Rosen
@ 2019-05-03 12:26 ` Thomas Monjalon
2019-05-03 12:26 ` Thomas Monjalon
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-05-03 12:26 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, stable
26/04/2019 12:27, Anatoly Burakov:
> According to manpage, ENOBUFS error indicates that either the
> input or the output queue is full. This should be considered
> an error, but it is treated as an "ignore" condition. Fix the
> code to report an error instead.
>
> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] ipc: fix send error handling
2019-05-03 12:26 ` Thomas Monjalon
@ 2019-05-03 12:26 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-05-03 12:26 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, stable
26/04/2019 12:27, Anatoly Burakov:
> According to manpage, ENOBUFS error indicates that either the
> input or the output queue is full. This should be considered
> an error, but it is treated as an "ignore" condition. Fix the
> code to report an error instead.
>
> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-03 12:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-26 10:27 [dpdk-dev] [PATCH] ipc: fix send error handling Anatoly Burakov
2019-04-26 10:27 ` Anatoly Burakov
2019-04-28 7:43 ` Rami Rosen
2019-04-28 7:43 ` Rami Rosen
2019-05-03 12:26 ` Thomas Monjalon
2019-05-03 12:26 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).