From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 667A21B398 for ; Sun, 28 Apr 2019 18:17:16 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id j26so3994099pgl.5 for ; Sun, 28 Apr 2019 09:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xi9SqkJKosgvm44wsQjcs+zK8z6YEba7ZKECkcDYYdA=; b=oGnHajCgM7kh27yh4gaQKiEY61TQlVn9fP6f2fjnxW7Bqpszbtw5UyIRV6V/8vWbQH dIsIn2q5kRzG1SzrdA+T+sjaL1iCbvosOsoVquMOWDrQZ+PaEYKYQFAbjGOXinuznMqF 1K+e101VYGAqXFxLo6OGoxs0Mk7Afa3rIzs3qjbI+swg0PPI4uZTQIthTP/NR+0RZVY1 fhQEfFuwzfoniYiujB1ajbYDR8NHosra0B8NUl+n7NNOSlZ1Nivdzv4naZ1SVB+Na1Wk 2UtdxiD7zNV8y2haexYO5s8WlW3Ey2gcjON3tqYcB4DgAUG49bqatVftBMAo8zOkCKzu z01A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xi9SqkJKosgvm44wsQjcs+zK8z6YEba7ZKECkcDYYdA=; b=k9S5dJ10q4LH9Uu7hoZnCkt5+1pplHvy60DZSFc9VNtcZHkWKs/kBxTJbsso+WIeud rt4rNN66KWtguQM5sLrVWZMZdBXPPkGQ+koa2By3slwfXI9bu/AYSN5Ux1EGR0X8bKIv NDUEVnN2mKYuqjh9nBR/jg1G8hTPv50pT1laRtDFZvqiUAaVQYcmscrLxfs6L2M/mJf6 Z8CekeETS8zWh5J/UlBpzDMoo0EtUD6PIgOfnnszfI/D6+QQ0Et8HZmUDhpA4QB8yfpH EDK4f9f4EnA0G4TDkujYQqYWdWnxc0KwAbRF+uLGmOXeCXi1b42NL5X4svonmIo+tZHK ZMHw== X-Gm-Message-State: APjAAAWupCeT/zpnj2EhpmH5DusHtu3bovgeqFDMHHdaVb5Np6ttL/br xzi+Pk8hKp2sdNLO2OgitrsA8Q== X-Google-Smtp-Source: APXvYqxW8vO6sEX1wNcEhzqXqaFW9Fzge7EoA1zcaAVXGDnZFjA2zAlPRXceCbbnv7HHeoCyoYPUDQ== X-Received: by 2002:aa7:8589:: with SMTP id w9mr58378981pfn.97.1556468234821; Sun, 28 Apr 2019 09:17:14 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x23sm3255739pfo.175.2019.04.28.09.17.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Apr 2019 09:17:14 -0700 (PDT) Date: Sun, 28 Apr 2019 09:17:05 -0700 From: Stephen Hemminger To: Matan Azrad Cc: Thomas Monjalon , "John W. Linville" , Xiaolong Ye , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Gagandeep Singh , Pankaj Chauhan , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Ferruh Yigit , Shijith Thotton , Srisivasubramanian Srinivasan , Shahaf Shuler , Yongseok Koh , Zyta Szpak , Liron Himi , Alan Winkowski , Tomasz Duszynski , Stephen Hemminger , kys , haiyangz , Rastislav Cernay , Jan Remes , Alejandro Lucero , Tetsuya Mukawa , Jerin Jacob , Bruce Richardson , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Anatoly Burakov , "dev@dpdk.org" Message-ID: <20190428091705.3b12d45e@hermes.lan> In-Reply-To: References: <30528485.5cHeq7CNxZ@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Apr 2019 16:17:16 -0000 On Sun, 28 Apr 2019 06:57:59 +0000 Matan Azrad wrote: > Hi Thomas > > vdev_netvsc has no close API - should I change something there? > > > From: Thomas Monjalon > > Hi all, > > > > Since DPDK 18.11, the behaviour of the close operation is changed if > > RTE_ETH_DEV_CLOSE_REMOVE is enabled in the driver: > > port is released (i.e. totally freed and data erased) on close. > > This new behaviour is enabled per driver for a migration period. > > > > Looking at the code, you can see these comments: > > /* old behaviour: only free queue arrays */ RTE_ETHDEV_LOG(DEBUG, "Port > > closing is using an old behaviour.\n" > > "The driver %s should migrate to the new behaviour.\n", > > /* new behaviour: send event + reset state + free all data */ > > > > You can find an advice in the commit: > > https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2 > > Fgit.dpdk.org%2Fdpdk%2Fcommit%2F%3Fid%3D23ea57a2a&data=02%7 > > C01%7Cmatan%40mellanox.com%7C3fea370ec31f4d22be8708d6c3ecf74b%7 > > Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636911819926371170&a > > mp;sdata=%2BHLHG6VK2gNLejSHRKLYtS4Qelqg%2FOD%2FUQbZwOIT9%2BA > > %3D&reserved=0 > > " > > When enabling RTE_ETH_DEV_CLOSE_REMOVE, > > the PMD must free all its private resources for the port, in its dev_close > > function. > > It is advised to call the dev_close function in the remove function in order to > > support removing a device without closing its ports. > > " > > > > It would be great to complete this migration for the next LTS version, which > > will be 19.11. > > It means the work should be ideally finished during the summer. > > > > The migration to the new behaviour is done in 4 drivers: > > git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 > > ena > > enic > > mlx5 > > vmxnet3 > > > > Following drivers should be migrated: > > ( find drivers/net -mindepth 1 -maxdepth 1 -type d | cut -d/ -f3 ; git grep -l > > RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 ) | sort | uniq -u > > af_packet > > af_xdp > > ark > > atlantic > > avp > > axgbe > > bnx2x > > bnxt > > bonding > > cxgbe > > dpaa > > dpaa2 > > e1000 > > enetc > > failsafe > > fm10k > > i40e > > iavf > > ice > > ifc > > ixgbe > > kni > > liquidio > > mlx4 > > mvneta > > mvpp2 > > netvsc > > nfb > > nfp > > null > > octeontx > > pcap > > qede > > ring > > sfc > > softnic > > szedata2 > > tap > > thunderx > > vdev_netvsc > > vhost > > virtio > > > > Please let's progress smoothly on this topic, thanks. > > > > The concerned maintainers (Cc) can be found with the following command: > > devtools/get-maintainer.sh $(( find drivers/net -mindepth 1 -maxdepth 1 - > > type d | cut -d/ -f-3 ; git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers ) | > > sort | uniq -u) > > > I have a version still testing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6E25AA0679 for ; Sun, 28 Apr 2019 18:17:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A19501B3A7; Sun, 28 Apr 2019 18:17:17 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 667A21B398 for ; Sun, 28 Apr 2019 18:17:16 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id j26so3994099pgl.5 for ; Sun, 28 Apr 2019 09:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xi9SqkJKosgvm44wsQjcs+zK8z6YEba7ZKECkcDYYdA=; b=oGnHajCgM7kh27yh4gaQKiEY61TQlVn9fP6f2fjnxW7Bqpszbtw5UyIRV6V/8vWbQH dIsIn2q5kRzG1SzrdA+T+sjaL1iCbvosOsoVquMOWDrQZ+PaEYKYQFAbjGOXinuznMqF 1K+e101VYGAqXFxLo6OGoxs0Mk7Afa3rIzs3qjbI+swg0PPI4uZTQIthTP/NR+0RZVY1 fhQEfFuwzfoniYiujB1ajbYDR8NHosra0B8NUl+n7NNOSlZ1Nivdzv4naZ1SVB+Na1Wk 2UtdxiD7zNV8y2haexYO5s8WlW3Ey2gcjON3tqYcB4DgAUG49bqatVftBMAo8zOkCKzu z01A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xi9SqkJKosgvm44wsQjcs+zK8z6YEba7ZKECkcDYYdA=; b=k9S5dJ10q4LH9Uu7hoZnCkt5+1pplHvy60DZSFc9VNtcZHkWKs/kBxTJbsso+WIeud rt4rNN66KWtguQM5sLrVWZMZdBXPPkGQ+koa2By3slwfXI9bu/AYSN5Ux1EGR0X8bKIv NDUEVnN2mKYuqjh9nBR/jg1G8hTPv50pT1laRtDFZvqiUAaVQYcmscrLxfs6L2M/mJf6 Z8CekeETS8zWh5J/UlBpzDMoo0EtUD6PIgOfnnszfI/D6+QQ0Et8HZmUDhpA4QB8yfpH EDK4f9f4EnA0G4TDkujYQqYWdWnxc0KwAbRF+uLGmOXeCXi1b42NL5X4svonmIo+tZHK ZMHw== X-Gm-Message-State: APjAAAWupCeT/zpnj2EhpmH5DusHtu3bovgeqFDMHHdaVb5Np6ttL/br xzi+Pk8hKp2sdNLO2OgitrsA8Q== X-Google-Smtp-Source: APXvYqxW8vO6sEX1wNcEhzqXqaFW9Fzge7EoA1zcaAVXGDnZFjA2zAlPRXceCbbnv7HHeoCyoYPUDQ== X-Received: by 2002:aa7:8589:: with SMTP id w9mr58378981pfn.97.1556468234821; Sun, 28 Apr 2019 09:17:14 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x23sm3255739pfo.175.2019.04.28.09.17.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Apr 2019 09:17:14 -0700 (PDT) Date: Sun, 28 Apr 2019 09:17:05 -0700 From: Stephen Hemminger To: Matan Azrad Cc: Thomas Monjalon , "John W. Linville" , Xiaolong Ye , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Gagandeep Singh , Pankaj Chauhan , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Ferruh Yigit , Shijith Thotton , Srisivasubramanian Srinivasan , Shahaf Shuler , Yongseok Koh , Zyta Szpak , Liron Himi , Alan Winkowski , Tomasz Duszynski , Stephen Hemminger , kys , haiyangz , Rastislav Cernay , Jan Remes , Alejandro Lucero , Tetsuya Mukawa , Jerin Jacob , Bruce Richardson , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Anatoly Burakov , "dev@dpdk.org" Message-ID: <20190428091705.3b12d45e@hermes.lan> In-Reply-To: References: <30528485.5cHeq7CNxZ@xps> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190428161705.RBG9E-eFLvSDHPuxlqwv8Rde8ygIgMIVkmxUD9XtjMk@z> On Sun, 28 Apr 2019 06:57:59 +0000 Matan Azrad wrote: > Hi Thomas > > vdev_netvsc has no close API - should I change something there? > > > From: Thomas Monjalon > > Hi all, > > > > Since DPDK 18.11, the behaviour of the close operation is changed if > > RTE_ETH_DEV_CLOSE_REMOVE is enabled in the driver: > > port is released (i.e. totally freed and data erased) on close. > > This new behaviour is enabled per driver for a migration period. > > > > Looking at the code, you can see these comments: > > /* old behaviour: only free queue arrays */ RTE_ETHDEV_LOG(DEBUG, "Port > > closing is using an old behaviour.\n" > > "The driver %s should migrate to the new behaviour.\n", > > /* new behaviour: send event + reset state + free all data */ > > > > You can find an advice in the commit: > > https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2 > > Fgit.dpdk.org%2Fdpdk%2Fcommit%2F%3Fid%3D23ea57a2a&data=02%7 > > C01%7Cmatan%40mellanox.com%7C3fea370ec31f4d22be8708d6c3ecf74b%7 > > Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636911819926371170&a > > mp;sdata=%2BHLHG6VK2gNLejSHRKLYtS4Qelqg%2FOD%2FUQbZwOIT9%2BA > > %3D&reserved=0 > > " > > When enabling RTE_ETH_DEV_CLOSE_REMOVE, > > the PMD must free all its private resources for the port, in its dev_close > > function. > > It is advised to call the dev_close function in the remove function in order to > > support removing a device without closing its ports. > > " > > > > It would be great to complete this migration for the next LTS version, which > > will be 19.11. > > It means the work should be ideally finished during the summer. > > > > The migration to the new behaviour is done in 4 drivers: > > git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 > > ena > > enic > > mlx5 > > vmxnet3 > > > > Following drivers should be migrated: > > ( find drivers/net -mindepth 1 -maxdepth 1 -type d | cut -d/ -f3 ; git grep -l > > RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 ) | sort | uniq -u > > af_packet > > af_xdp > > ark > > atlantic > > avp > > axgbe > > bnx2x > > bnxt > > bonding > > cxgbe > > dpaa > > dpaa2 > > e1000 > > enetc > > failsafe > > fm10k > > i40e > > iavf > > ice > > ifc > > ixgbe > > kni > > liquidio > > mlx4 > > mvneta > > mvpp2 > > netvsc > > nfb > > nfp > > null > > octeontx > > pcap > > qede > > ring > > sfc > > softnic > > szedata2 > > tap > > thunderx > > vdev_netvsc > > vhost > > virtio > > > > Please let's progress smoothly on this topic, thanks. > > > > The concerned maintainers (Cc) can be found with the following command: > > devtools/get-maintainer.sh $(( find drivers/net -mindepth 1 -maxdepth 1 - > > type d | cut -d/ -f-3 ; git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers ) | > > sort | uniq -u) > > > I have a version still testing