From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 3AAE01B398 for ; Sun, 28 Apr 2019 18:24:06 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id t22so987853pgi.10 for ; Sun, 28 Apr 2019 09:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VkqEy+6PEkQ2DUfRAKof6NGKVd3FmbPyVMl9T9Fcdk8=; b=Md3pRb+jUBxxvakROxVcLAuUrrRIzYD4Pj/xz3omvKfVp3XJ3qCCxNq+Gr1cRH3Gf6 4tjqyrJ34N0fUVp+PTCqyM/Dc1oFiJXDeCVEAy7MnOT+gVCTXiXMeqVWF2UQdWXP4j4r x9/dL9Hke+pc+L/ZRLCQH3MRWPKPxAiVTEv9HAfESvOBdUi5meQBLEKy3kDiqul0V6o8 XFFt6am+RkQM0LPU+iPZ7YksBkbavP5WEihTC0rqoM1Nlm6SGXHJg1T7Feh4lNyLiDQ4 Oc1EP7KHlrONiLuckGK2hFntHBCuq5UkeyZ4PQuApHc1yY73jismgeTVPxz9d5bg9Mo/ Zw8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VkqEy+6PEkQ2DUfRAKof6NGKVd3FmbPyVMl9T9Fcdk8=; b=kf8u2qAKbSsQRyIFfFY2b0+B1Er736Gb7K94qjU1TCH344TpY79K0D1kmv8ZcvFNQj +5BsIugc1RcaWmXB8wyZ1aUOPkG8Dr+SYhfcx1uy8kOiqt5AyyZzbOoGIr2qtfckwo0u 9IH36vg+ZeT71MWURqI7gEVZVJ6eEHRZ7oeWEPfLT+tVGLueY+jxQ5iu2mKnncoyGS1J Q8+DMHQ7N+3tg+eRe2RFV162qbb2oJTh8M5PL1dHBHG1+nBiWKsx7jGZK0Zs1CQa05hb 0RsUFZp/c9eiw7izg64nh/cECM2b/OQHm84L8KXOnqdUXkI9sYsRFDlyutmYKR9jSvYd XQpA== X-Gm-Message-State: APjAAAXXkAnjoIpvVHYPLeyPxwPy/mt0C3AMln2wjNiLshZtXoPWwg1b 7gk2joOWpAXn1jfN6WsQzs9hTw== X-Google-Smtp-Source: APXvYqz6+mwla8cAmizTVpvnSVxpbF+zyrQJjmkFrJV4VyKjGvDHfaUNdQX8T+WeBuEp5+6TFQ2Cng== X-Received: by 2002:a62:5fc5:: with SMTP id t188mr7318673pfb.155.1556468645142; Sun, 28 Apr 2019 09:24:05 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f22sm43780230pgv.45.2019.04.28.09.24.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Apr 2019 09:24:05 -0700 (PDT) Date: Sun, 28 Apr 2019 09:23:57 -0700 From: Stephen Hemminger To: Arnon Warshavsky Cc: dev@dpdk.org, thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, ranjit.menon@intel.com, anand.rawat@intel.com, pallavi.kadam@intel.com, harini.ramakrishnan@microsoft.com, cathal.ohare@intel.com, arnonw@qwilt.com Message-ID: <20190428092357.66ae2b80@hermes.lan> In-Reply-To: <1556463528-22853-1-git-send-email-arnon@qwilt.com> References: <1556463528-22853-1-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Apr 2019 16:24:06 -0000 On Sun, 28 Apr 2019 17:58:48 +0300 Arnon Warshavsky wrote: These deprecation notices are unnecessary. These are not public API's. > +* eal: Modify function return value for the sake of removing rte_panic > + from the init sequence in version 19.08. > + - In ``lib/librte_eal/common/eal_thread.h`` replace > + ``void eal_thread_init_master(unsigned lcore_id)`` > + to return ``int`` This function is never exported (see rte_eal_version.map) and therefore be marked private to the EAL, and not a public API. > +* kni: Modify function return value for the sake of removing rte_panic > + from the init sequence in version 19.08. > + - In ``lib/librte_kni/rte_kni_fifo.h`` replace > + ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)`` > + to return ``int`` This is not a public API really so no deprecation needed. It is just an include file used internally by library and the driver. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C9A95A0679 for ; Sun, 28 Apr 2019 18:24:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 77C4A1B3A7; Sun, 28 Apr 2019 18:24:08 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 3AAE01B398 for ; Sun, 28 Apr 2019 18:24:06 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id t22so987853pgi.10 for ; Sun, 28 Apr 2019 09:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VkqEy+6PEkQ2DUfRAKof6NGKVd3FmbPyVMl9T9Fcdk8=; b=Md3pRb+jUBxxvakROxVcLAuUrrRIzYD4Pj/xz3omvKfVp3XJ3qCCxNq+Gr1cRH3Gf6 4tjqyrJ34N0fUVp+PTCqyM/Dc1oFiJXDeCVEAy7MnOT+gVCTXiXMeqVWF2UQdWXP4j4r x9/dL9Hke+pc+L/ZRLCQH3MRWPKPxAiVTEv9HAfESvOBdUi5meQBLEKy3kDiqul0V6o8 XFFt6am+RkQM0LPU+iPZ7YksBkbavP5WEihTC0rqoM1Nlm6SGXHJg1T7Feh4lNyLiDQ4 Oc1EP7KHlrONiLuckGK2hFntHBCuq5UkeyZ4PQuApHc1yY73jismgeTVPxz9d5bg9Mo/ Zw8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VkqEy+6PEkQ2DUfRAKof6NGKVd3FmbPyVMl9T9Fcdk8=; b=kf8u2qAKbSsQRyIFfFY2b0+B1Er736Gb7K94qjU1TCH344TpY79K0D1kmv8ZcvFNQj +5BsIugc1RcaWmXB8wyZ1aUOPkG8Dr+SYhfcx1uy8kOiqt5AyyZzbOoGIr2qtfckwo0u 9IH36vg+ZeT71MWURqI7gEVZVJ6eEHRZ7oeWEPfLT+tVGLueY+jxQ5iu2mKnncoyGS1J Q8+DMHQ7N+3tg+eRe2RFV162qbb2oJTh8M5PL1dHBHG1+nBiWKsx7jGZK0Zs1CQa05hb 0RsUFZp/c9eiw7izg64nh/cECM2b/OQHm84L8KXOnqdUXkI9sYsRFDlyutmYKR9jSvYd XQpA== X-Gm-Message-State: APjAAAXXkAnjoIpvVHYPLeyPxwPy/mt0C3AMln2wjNiLshZtXoPWwg1b 7gk2joOWpAXn1jfN6WsQzs9hTw== X-Google-Smtp-Source: APXvYqz6+mwla8cAmizTVpvnSVxpbF+zyrQJjmkFrJV4VyKjGvDHfaUNdQX8T+WeBuEp5+6TFQ2Cng== X-Received: by 2002:a62:5fc5:: with SMTP id t188mr7318673pfb.155.1556468645142; Sun, 28 Apr 2019 09:24:05 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f22sm43780230pgv.45.2019.04.28.09.24.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Apr 2019 09:24:05 -0700 (PDT) Date: Sun, 28 Apr 2019 09:23:57 -0700 From: Stephen Hemminger To: Arnon Warshavsky Cc: dev@dpdk.org, thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, ranjit.menon@intel.com, anand.rawat@intel.com, pallavi.kadam@intel.com, harini.ramakrishnan@microsoft.com, cathal.ohare@intel.com, arnonw@qwilt.com Message-ID: <20190428092357.66ae2b80@hermes.lan> In-Reply-To: <1556463528-22853-1-git-send-email-arnon@qwilt.com> References: <1556463528-22853-1-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190428162357.VcXbMFmU9De6CqXVv_blOWp8OtKy-nacSlv3aoIUQps@z> On Sun, 28 Apr 2019 17:58:48 +0300 Arnon Warshavsky wrote: These deprecation notices are unnecessary. These are not public API's. > +* eal: Modify function return value for the sake of removing rte_panic > + from the init sequence in version 19.08. > + - In ``lib/librte_eal/common/eal_thread.h`` replace > + ``void eal_thread_init_master(unsigned lcore_id)`` > + to return ``int`` This function is never exported (see rte_eal_version.map) and therefore be marked private to the EAL, and not a public API. > +* kni: Modify function return value for the sake of removing rte_panic > + from the init sequence in version 19.08. > + - In ``lib/librte_kni/rte_kni_fifo.h`` replace > + ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)`` > + to return ``int`` This is not a public API really so no deprecation needed. It is just an include file used internally by library and the driver.