From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Pavel Belous <Pavel.Belous@aquantia.com>,
Igor Russkikh <Igor.Russkikh@aquantia.com>
Subject: [dpdk-dev] [PATCH 10/11] net/atlantic: typo on args check
Date: Mon, 29 Apr 2019 08:20:27 +0000 [thread overview]
Message-ID: <e84db49178845a65a3a0dfab059d42b3ffb05309.1556525874.git.igor.russkikh@aquantia.com> (raw)
Message-ID: <20190429082027.Fym0sa9UN5DkNKo4PnkvCJCCmxskdYfNpQVJkPjOwYA@z> (raw)
In-Reply-To: <cover.1556525874.git.igor.russkikh@aquantia.com>
Found by coverity scan, two pointer args should be not zero checked
Coverity issue: 337929
Fixes: 2f40244b39ba ("net/atlantic: implement MACsec firmware interface")
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
---
drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
index 0d24aa99bda0..5927d90f1813 100644
--- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c
@@ -671,7 +671,7 @@ static int aq_fw2x_send_macsec_request(struct aq_hw_s *self,
int err = 0;
u32 mpi_opts = 0;
- if (!response || !response)
+ if (!req || !response)
return 0;
if ((self->caps_lo & BIT(CAPS_LO_MACSEC)) == 0)
--
2.17.1
next prev parent reply other threads:[~2019-04-29 8:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 8:20 [dpdk-dev] [PATCH 00/11] Aquantia atlantic bugfixes Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 8:20 ` [dpdk-dev] [PATCH 01/11] net/atlantic: enable broadcast traffic Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 8:20 ` [dpdk-dev] [PATCH 02/11] net/atlantic: extra line at eof Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 13:57 ` Ferruh Yigit
2019-04-29 13:57 ` Ferruh Yigit
2019-04-29 8:20 ` [dpdk-dev] [PATCH 03/11] net/atlantic: bad indentation Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 8:20 ` [dpdk-dev] [PATCH 04/11] net/atlantic: eeprom get/set should consider offset Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 8:20 ` [dpdk-dev] [PATCH 05/11] net/atlantic: fix max eeprom size Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 8:20 ` [dpdk-dev] [PATCH 06/11] net/atlantic: validity check for eeprom dev address Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 8:20 ` [dpdk-dev] [PATCH 07/11] net/atlantic: bad logic with offsets talking with firmware Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 8:20 ` [dpdk-dev] [PATCH 08/11] net/atlantic: flow control settings synchronization on rx Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 8:20 ` [dpdk-dev] [PATCH 09/11] net/atlantic: use capability bits to detect eeprom access Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh [this message]
2019-04-29 8:20 ` [dpdk-dev] [PATCH 10/11] net/atlantic: typo on args check Igor Russkikh
2019-04-29 8:20 ` [dpdk-dev] [PATCH 11/11] net/atlantic: extra err check Igor Russkikh
2019-04-29 8:20 ` Igor Russkikh
2019-05-08 16:05 ` [dpdk-dev] [PATCH 00/11] Aquantia atlantic bugfixes Kevin Traynor
2019-05-08 16:05 ` Kevin Traynor
2019-05-13 7:59 ` Igor Russkikh
2019-05-13 7:59 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e84db49178845a65a3a0dfab059d42b3ffb05309.1556525874.git.igor.russkikh@aquantia.com \
--to=igor.russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).