DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	Matan Azrad <matan@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx4: add support for multicast address list interface
Date: Mon, 29 Apr 2019 08:54:36 +0000	[thread overview]
Message-ID: <AM0PR0502MB3795AB0B6C07A6D208E3331BC3390@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
Message-ID: <20190429085436.k_nsrZOdWvBgDHDNSEo9M8Sc5iLCFgetjfdeBzExpMQ@z> (raw)
In-Reply-To: <20190418130245.25618-1-adrien.mazarguil@6wind.com>

Thursday, April 18, 2019 4:11 PM, Adrien Mazarguil:
> Subject: [PATCH] net/mlx4: add support for multicast address list interface
> 
> Since this driver does not distinguish unicast/multicast addresses,
> applications could always rely on the standard MAC add/remove/set
> interface to configure both types.
> 
> As a result, the multicast address list interface never got implemented
> (rte_eth_dev_set_mc_addr_list()) however PMD-agnostic applications still
> rely on it for compatibility reasons; a wrapper is therefore required.
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to next-net-mlx with a small change (see below). 

> ---
>  drivers/net/mlx4/mlx4.c        |  1 +
>  drivers/net/mlx4/mlx4.h        |  3 ++
>  drivers/net/mlx4/mlx4_ethdev.c | 61

[...]

> @@ -488,6 +488,63 @@ mlx4_mac_addr_add(struct rte_eth_dev *dev,
> struct ether_addr *mac_addr,  }
> 
>  /**
> + * DPDK callback to configure multicast addresses.
> + *
> + * @param dev
> + *   Pointer to Ethernet device structure.
> + * @param list
> + *   List of MAC addresses to register.
> + * @param num
> + *   Number of entries in list.
> + *
> + * @return
> + *   0 on success, negative errno value otherwise and rte_errno is set.
> + */
> +int
> +mlx4_set_mc_addr_list(struct rte_eth_dev *dev, struct ether_addr *list,
> +		      uint32_t num)
> +{
> +	struct priv *priv = dev->data->dev_private;

I have modified it to struct mlx4_priv. please shout if you disagree.


  parent reply	other threads:[~2019-04-29  8:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 13:10 Adrien Mazarguil
2019-04-18 13:10 ` Adrien Mazarguil
2019-04-29  8:54 ` Shahaf Shuler [this message]
2019-04-29  8:54   ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0502MB3795AB0B6C07A6D208E3331BC3390@AM0PR0502MB3795.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).