* [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
@ 2019-04-24 12:37 Jasvinder Singh
2019-04-24 12:37 ` Jasvinder Singh
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Jasvinder Singh @ 2019-04-24 12:37 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu
Add deprecation note for making changes in data structures, APIs
and macros in order to have more traffic classes, flexible
mapping of pipe queues to traffic classes, subport level
configuration of pipes and queues, etc. These changes are aligned
to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b47c8c254..051ab5c2a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -79,6 +79,12 @@ Deprecation Notices
The field would be added in v19.08.
+* sched: To allow more traffic classes, flexible mapping of pipe queues to
+ traffic classes, and subport level configuration of pipes and queues
+ changes will be made to macros, data structures and API functions defined
+ in "rte_sched.h". These changes are aligned to improvements suggested in the
+ RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
+
* cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
--
2.17.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-04-24 12:37 [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes Jasvinder Singh
@ 2019-04-24 12:37 ` Jasvinder Singh
2019-04-29 10:31 ` Mohammad Abdul Awal
2019-04-30 15:18 ` Pattan, Reshma
2 siblings, 0 replies; 15+ messages in thread
From: Jasvinder Singh @ 2019-04-24 12:37 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu
Add deprecation note for making changes in data structures, APIs
and macros in order to have more traffic classes, flexible
mapping of pipe queues to traffic classes, subport level
configuration of pipes and queues, etc. These changes are aligned
to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b47c8c254..051ab5c2a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -79,6 +79,12 @@ Deprecation Notices
The field would be added in v19.08.
+* sched: To allow more traffic classes, flexible mapping of pipe queues to
+ traffic classes, and subport level configuration of pipes and queues
+ changes will be made to macros, data structures and API functions defined
+ in "rte_sched.h". These changes are aligned to improvements suggested in the
+ RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
+
* cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
--
2.17.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-04-24 12:37 [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes Jasvinder Singh
2019-04-24 12:37 ` Jasvinder Singh
@ 2019-04-29 10:31 ` Mohammad Abdul Awal
2019-04-29 10:31 ` Mohammad Abdul Awal
2019-05-13 13:56 ` Thomas Monjalon
2019-04-30 15:18 ` Pattan, Reshma
2 siblings, 2 replies; 15+ messages in thread
From: Mohammad Abdul Awal @ 2019-04-29 10:31 UTC (permalink / raw)
To: Jasvinder Singh, dev; +Cc: cristian.dumitrescu
On 24/04/2019 13:37, Jasvinder Singh wrote:
> Add deprecation note for making changes in data structures, APIs
> and macros in order to have more traffic classes, flexible
> mapping of pipe queues to traffic classes, subport level
> configuration of pipes and queues, etc. These changes are aligned
> to improvements suggested in the RFC-
> https://mails.dpdk.org/archives/dev/2018-November/120035.html
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index b47c8c254..051ab5c2a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -79,6 +79,12 @@ Deprecation Notices
>
> The field would be added in v19.08.
>
> +* sched: To allow more traffic classes, flexible mapping of pipe queues to
> + traffic classes, and subport level configuration of pipes and queues
> + changes will be made to macros, data structures and API functions defined
> + in "rte_sched.h". These changes are aligned to improvements suggested in the
> + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> +
> * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-04-29 10:31 ` Mohammad Abdul Awal
@ 2019-04-29 10:31 ` Mohammad Abdul Awal
2019-05-13 13:56 ` Thomas Monjalon
1 sibling, 0 replies; 15+ messages in thread
From: Mohammad Abdul Awal @ 2019-04-29 10:31 UTC (permalink / raw)
To: Jasvinder Singh, dev; +Cc: cristian.dumitrescu
On 24/04/2019 13:37, Jasvinder Singh wrote:
> Add deprecation note for making changes in data structures, APIs
> and macros in order to have more traffic classes, flexible
> mapping of pipe queues to traffic classes, subport level
> configuration of pipes and queues, etc. These changes are aligned
> to improvements suggested in the RFC-
> https://mails.dpdk.org/archives/dev/2018-November/120035.html
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index b47c8c254..051ab5c2a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -79,6 +79,12 @@ Deprecation Notices
>
> The field would be added in v19.08.
>
> +* sched: To allow more traffic classes, flexible mapping of pipe queues to
> + traffic classes, and subport level configuration of pipes and queues
> + changes will be made to macros, data structures and API functions defined
> + in "rte_sched.h". These changes are aligned to improvements suggested in the
> + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> +
> * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-04-24 12:37 [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes Jasvinder Singh
2019-04-24 12:37 ` Jasvinder Singh
2019-04-29 10:31 ` Mohammad Abdul Awal
@ 2019-04-30 15:18 ` Pattan, Reshma
2019-04-30 15:18 ` Pattan, Reshma
2 siblings, 1 reply; 15+ messages in thread
From: Pattan, Reshma @ 2019-04-30 15:18 UTC (permalink / raw)
To: Singh, Jasvinder, dev; +Cc: Dumitrescu, Cristian
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Wednesday, April 24, 2019 1:37 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
>
> Add deprecation note for making changes in data structures, APIs and macros in
> order to have more traffic classes, flexible mapping of pipe queues to traffic
> classes, subport level configuration of pipes and queues, etc. These changes are
> aligned to improvements suggested in the RFC-
> https://mails.dpdk.org/archives/dev/2018-November/120035.html
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Acked-by : Reshma Pattan <reshma.pattan@intel.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-04-30 15:18 ` Pattan, Reshma
@ 2019-04-30 15:18 ` Pattan, Reshma
0 siblings, 0 replies; 15+ messages in thread
From: Pattan, Reshma @ 2019-04-30 15:18 UTC (permalink / raw)
To: Singh, Jasvinder, dev; +Cc: Dumitrescu, Cristian
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Wednesday, April 24, 2019 1:37 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
>
> Add deprecation note for making changes in data structures, APIs and macros in
> order to have more traffic classes, flexible mapping of pipe queues to traffic
> classes, subport level configuration of pipes and queues, etc. These changes are
> aligned to improvements suggested in the RFC-
> https://mails.dpdk.org/archives/dev/2018-November/120035.html
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Acked-by : Reshma Pattan <reshma.pattan@intel.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-04-29 10:31 ` Mohammad Abdul Awal
2019-04-29 10:31 ` Mohammad Abdul Awal
@ 2019-05-13 13:56 ` Thomas Monjalon
2019-05-13 13:56 ` Thomas Monjalon
2019-05-13 13:59 ` Singh, Jasvinder
1 sibling, 2 replies; 15+ messages in thread
From: Thomas Monjalon @ 2019-05-13 13:56 UTC (permalink / raw)
To: dev
Cc: Mohammad Abdul Awal, Jasvinder Singh, cristian.dumitrescu,
ferruh.yigit, jerin.jacob, hemant.agrawal, stephen
29/04/2019 12:31, Mohammad Abdul Awal:
> On 24/04/2019 13:37, Jasvinder Singh wrote:
> > Add deprecation note for making changes in data structures, APIs
> > and macros in order to have more traffic classes, flexible
> > mapping of pipe queues to traffic classes, subport level
> > configuration of pipes and queues, etc. These changes are aligned
> > to improvements suggested in the RFC-
> > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > ---
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > +* sched: To allow more traffic classes, flexible mapping of pipe queues to
> > + traffic classes, and subport level configuration of pipes and queues
> > + changes will be made to macros, data structures and API functions defined
> > + in "rte_sched.h". These changes are aligned to improvements suggested in the
> > + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
>
> Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Acked-by : Reshma Pattan <reshma.pattan@intel.com>
There are only 2 acks for this change.
Any other opinion? yes or no?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-05-13 13:56 ` Thomas Monjalon
@ 2019-05-13 13:56 ` Thomas Monjalon
2019-05-13 13:59 ` Singh, Jasvinder
1 sibling, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2019-05-13 13:56 UTC (permalink / raw)
To: dev
Cc: Mohammad Abdul Awal, Jasvinder Singh, cristian.dumitrescu,
ferruh.yigit, jerin.jacob, hemant.agrawal, stephen
29/04/2019 12:31, Mohammad Abdul Awal:
> On 24/04/2019 13:37, Jasvinder Singh wrote:
> > Add deprecation note for making changes in data structures, APIs
> > and macros in order to have more traffic classes, flexible
> > mapping of pipe queues to traffic classes, subport level
> > configuration of pipes and queues, etc. These changes are aligned
> > to improvements suggested in the RFC-
> > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > ---
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > +* sched: To allow more traffic classes, flexible mapping of pipe queues to
> > + traffic classes, and subport level configuration of pipes and queues
> > + changes will be made to macros, data structures and API functions defined
> > + in "rte_sched.h". These changes are aligned to improvements suggested in the
> > + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
>
> Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Acked-by : Reshma Pattan <reshma.pattan@intel.com>
There are only 2 acks for this change.
Any other opinion? yes or no?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-05-13 13:56 ` Thomas Monjalon
2019-05-13 13:56 ` Thomas Monjalon
@ 2019-05-13 13:59 ` Singh, Jasvinder
2019-05-13 13:59 ` Singh, Jasvinder
2019-05-13 14:12 ` Thomas Monjalon
1 sibling, 2 replies; 15+ messages in thread
From: Singh, Jasvinder @ 2019-05-13 13:59 UTC (permalink / raw)
To: Thomas Monjalon, dev
Cc: Awal, Mohammad Abdul, Dumitrescu, Cristian, Yigit, Ferruh,
jerin.jacob, hemant.agrawal, stephen
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 13, 2019 2:56 PM
> To: dev@dpdk.org
> Cc: Awal, Mohammad Abdul <mohammad.abdul.awal@intel.com>; Singh,
> Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com;
> stephen@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
>
> 29/04/2019 12:31, Mohammad Abdul Awal:
> > On 24/04/2019 13:37, Jasvinder Singh wrote:
> > > Add deprecation note for making changes in data structures, APIs and
> > > macros in order to have more traffic classes, flexible mapping of
> > > pipe queues to traffic classes, subport level configuration of pipes
> > > and queues, etc. These changes are aligned to improvements suggested
> > > in the RFC-
> > > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> > >
> > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > ---
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > +* sched: To allow more traffic classes, flexible mapping of pipe
> > > +queues to
> > > + traffic classes, and subport level configuration of pipes and
> > > +queues
> > > + changes will be made to macros, data structures and API functions
> > > +defined
> > > + in "rte_sched.h". These changes are aligned to improvements
> > > +suggested in the
> > > + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
>
> >
> > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> Acked-by : Reshma Pattan <reshma.pattan@intel.com>
>
> There are only 2 acks for this change.
> Any other opinion? yes or no?
>
Cristian has provided his ack as well, please see below signed-off line.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-05-13 13:59 ` Singh, Jasvinder
@ 2019-05-13 13:59 ` Singh, Jasvinder
2019-05-13 14:12 ` Thomas Monjalon
1 sibling, 0 replies; 15+ messages in thread
From: Singh, Jasvinder @ 2019-05-13 13:59 UTC (permalink / raw)
To: Thomas Monjalon, dev
Cc: Awal, Mohammad Abdul, Dumitrescu, Cristian, Yigit, Ferruh,
jerin.jacob, hemant.agrawal, stephen
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 13, 2019 2:56 PM
> To: dev@dpdk.org
> Cc: Awal, Mohammad Abdul <mohammad.abdul.awal@intel.com>; Singh,
> Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com;
> stephen@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
>
> 29/04/2019 12:31, Mohammad Abdul Awal:
> > On 24/04/2019 13:37, Jasvinder Singh wrote:
> > > Add deprecation note for making changes in data structures, APIs and
> > > macros in order to have more traffic classes, flexible mapping of
> > > pipe queues to traffic classes, subport level configuration of pipes
> > > and queues, etc. These changes are aligned to improvements suggested
> > > in the RFC-
> > > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> > >
> > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > ---
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > +* sched: To allow more traffic classes, flexible mapping of pipe
> > > +queues to
> > > + traffic classes, and subport level configuration of pipes and
> > > +queues
> > > + changes will be made to macros, data structures and API functions
> > > +defined
> > > + in "rte_sched.h". These changes are aligned to improvements
> > > +suggested in the
> > > + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
>
> >
> > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> Acked-by : Reshma Pattan <reshma.pattan@intel.com>
>
> There are only 2 acks for this change.
> Any other opinion? yes or no?
>
Cristian has provided his ack as well, please see below signed-off line.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-05-13 13:59 ` Singh, Jasvinder
2019-05-13 13:59 ` Singh, Jasvinder
@ 2019-05-13 14:12 ` Thomas Monjalon
2019-05-13 14:12 ` Thomas Monjalon
2019-05-13 21:31 ` Thomas Monjalon
1 sibling, 2 replies; 15+ messages in thread
From: Thomas Monjalon @ 2019-05-13 14:12 UTC (permalink / raw)
To: Singh, Jasvinder
Cc: dev, Awal, Mohammad Abdul, Dumitrescu, Cristian, Yigit, Ferruh,
jerin.jacob, hemant.agrawal, stephen
13/05/2019 15:59, Singh, Jasvinder:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 29/04/2019 12:31, Mohammad Abdul Awal:
> > > On 24/04/2019 13:37, Jasvinder Singh wrote:
> > > > Add deprecation note for making changes in data structures, APIs and
> > > > macros in order to have more traffic classes, flexible mapping of
> > > > pipe queues to traffic classes, subport level configuration of pipes
> > > > and queues, etc. These changes are aligned to improvements suggested
> > > > in the RFC-
> > > > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> > > >
> > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > ---
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > +* sched: To allow more traffic classes, flexible mapping of pipe
> > > > +queues to
> > > > + traffic classes, and subport level configuration of pipes and
> > > > +queues
> > > > + changes will be made to macros, data structures and API functions
> > > > +defined
> > > > + in "rte_sched.h". These changes are aligned to improvements
> > > > +suggested in the
> > > > + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> >
> > >
> > > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> > Acked-by : Reshma Pattan <reshma.pattan@intel.com>
> >
> > There are only 2 acks for this change.
> > Any other opinion? yes or no?
> >
>
> Cristian has provided his ack as well, please see below signed-off line.
You are right.
So we get enough acks from the whole team :)
If nobody is against, I will merge it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-05-13 14:12 ` Thomas Monjalon
@ 2019-05-13 14:12 ` Thomas Monjalon
2019-05-13 21:31 ` Thomas Monjalon
1 sibling, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2019-05-13 14:12 UTC (permalink / raw)
To: Singh, Jasvinder
Cc: dev, Awal, Mohammad Abdul, Dumitrescu, Cristian, Yigit, Ferruh,
jerin.jacob, hemant.agrawal, stephen
13/05/2019 15:59, Singh, Jasvinder:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 29/04/2019 12:31, Mohammad Abdul Awal:
> > > On 24/04/2019 13:37, Jasvinder Singh wrote:
> > > > Add deprecation note for making changes in data structures, APIs and
> > > > macros in order to have more traffic classes, flexible mapping of
> > > > pipe queues to traffic classes, subport level configuration of pipes
> > > > and queues, etc. These changes are aligned to improvements suggested
> > > > in the RFC-
> > > > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> > > >
> > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > ---
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > +* sched: To allow more traffic classes, flexible mapping of pipe
> > > > +queues to
> > > > + traffic classes, and subport level configuration of pipes and
> > > > +queues
> > > > + changes will be made to macros, data structures and API functions
> > > > +defined
> > > > + in "rte_sched.h". These changes are aligned to improvements
> > > > +suggested in the
> > > > + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> >
> > >
> > > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> > Acked-by : Reshma Pattan <reshma.pattan@intel.com>
> >
> > There are only 2 acks for this change.
> > Any other opinion? yes or no?
> >
>
> Cristian has provided his ack as well, please see below signed-off line.
You are right.
So we get enough acks from the whole team :)
If nobody is against, I will merge it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-05-13 14:12 ` Thomas Monjalon
2019-05-13 14:12 ` Thomas Monjalon
@ 2019-05-13 21:31 ` Thomas Monjalon
2019-05-13 21:31 ` Thomas Monjalon
1 sibling, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2019-05-13 21:31 UTC (permalink / raw)
To: Singh, Jasvinder
Cc: dev, Awal, Mohammad Abdul, Dumitrescu, Cristian, Yigit, Ferruh,
jerin.jacob, hemant.agrawal, stephen
13/05/2019 16:12, Thomas Monjalon:
> 13/05/2019 15:59, Singh, Jasvinder:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > 29/04/2019 12:31, Mohammad Abdul Awal:
> > > > On 24/04/2019 13:37, Jasvinder Singh wrote:
> > > > > Add deprecation note for making changes in data structures, APIs and
> > > > > macros in order to have more traffic classes, flexible mapping of
> > > > > pipe queues to traffic classes, subport level configuration of pipes
> > > > > and queues, etc. These changes are aligned to improvements suggested
> > > > > in the RFC-
> > > > > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> > > > >
> > > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > > ---
> > > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > > +* sched: To allow more traffic classes, flexible mapping of pipe
> > > > > +queues to
> > > > > + traffic classes, and subport level configuration of pipes and
> > > > > +queues
> > > > > + changes will be made to macros, data structures and API functions
> > > > > +defined
> > > > > + in "rte_sched.h". These changes are aligned to improvements
> > > > > +suggested in the
> > > > > + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> > >
> > > >
> > > > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> > > Acked-by : Reshma Pattan <reshma.pattan@intel.com>
> > >
> > > There are only 2 acks for this change.
> > > Any other opinion? yes or no?
> > >
> >
> > Cristian has provided his ack as well, please see below signed-off line.
>
> You are right.
> So we get enough acks from the whole team :)
>
> If nobody is against, I will merge it.
Applied, thanks
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
2019-05-13 21:31 ` Thomas Monjalon
@ 2019-05-13 21:31 ` Thomas Monjalon
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2019-05-13 21:31 UTC (permalink / raw)
To: Singh, Jasvinder
Cc: dev, Awal, Mohammad Abdul, Dumitrescu, Cristian, Yigit, Ferruh,
jerin.jacob, hemant.agrawal, stephen
13/05/2019 16:12, Thomas Monjalon:
> 13/05/2019 15:59, Singh, Jasvinder:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > 29/04/2019 12:31, Mohammad Abdul Awal:
> > > > On 24/04/2019 13:37, Jasvinder Singh wrote:
> > > > > Add deprecation note for making changes in data structures, APIs and
> > > > > macros in order to have more traffic classes, flexible mapping of
> > > > > pipe queues to traffic classes, subport level configuration of pipes
> > > > > and queues, etc. These changes are aligned to improvements suggested
> > > > > in the RFC-
> > > > > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> > > > >
> > > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > > ---
> > > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > > +* sched: To allow more traffic classes, flexible mapping of pipe
> > > > > +queues to
> > > > > + traffic classes, and subport level configuration of pipes and
> > > > > +queues
> > > > > + changes will be made to macros, data structures and API functions
> > > > > +defined
> > > > > + in "rte_sched.h". These changes are aligned to improvements
> > > > > +suggested in the
> > > > > + RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> > >
> > > >
> > > > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> > > Acked-by : Reshma Pattan <reshma.pattan@intel.com>
> > >
> > > There are only 2 acks for this change.
> > > Any other opinion? yes or no?
> > >
> >
> > Cristian has provided his ack as well, please see below signed-off line.
>
> You are right.
> So we get enough acks from the whole team :)
>
> If nobody is against, I will merge it.
Applied, thanks
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
@ 2020-07-16 10:28 Savinay Dharmappa
0 siblings, 0 replies; 15+ messages in thread
From: Savinay Dharmappa @ 2020-07-16 10:28 UTC (permalink / raw)
To: savinay.dharmappa, jasvinder.singh, dev; +Cc: cristian.dumitrescu
Add deprecation note for making changes in data structures and APIs
in order to allow dynamic configuration of subport bandwidth profile.
These changes are aligned as suggested in the RFC[1].
https://mails.dpdk.org/archives/dev/2020-July/175161.html
Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index a58a179..d78a3a1 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -129,6 +129,12 @@ Deprecation Notices
in "rte_sched.h". These changes are aligned to improvements suggested in the
RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
+* sched: To allow dynamic configuration of the subport bandwidth profile,
+ changes will be made to data structures ``rte_sched_subport_params``
+ ``rte_sched_port_params`` and new data structure, API fuctions will be
+ defined in "rte_sched.h". These changes are aligned as suggested in the
+ RFC https://mails.dpdk.org/archives/dev/2020-July/175161.html
+
* metrics: The function ``rte_metrics_init`` will have a non-void return
in order to notify errors instead of calling ``rte_exit``.
--
2.7.4
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-07-16 10:28 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24 12:37 [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes Jasvinder Singh
2019-04-24 12:37 ` Jasvinder Singh
2019-04-29 10:31 ` Mohammad Abdul Awal
2019-04-29 10:31 ` Mohammad Abdul Awal
2019-05-13 13:56 ` Thomas Monjalon
2019-05-13 13:56 ` Thomas Monjalon
2019-05-13 13:59 ` Singh, Jasvinder
2019-05-13 13:59 ` Singh, Jasvinder
2019-05-13 14:12 ` Thomas Monjalon
2019-05-13 14:12 ` Thomas Monjalon
2019-05-13 21:31 ` Thomas Monjalon
2019-05-13 21:31 ` Thomas Monjalon
2019-04-30 15:18 ` Pattan, Reshma
2019-04-30 15:18 ` Pattan, Reshma
2020-07-16 10:28 Savinay Dharmappa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).