DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number
@ 2019-04-28  6:13 Wei Zhao
  2019-04-28  6:13 ` Wei Zhao
  2019-04-28  6:51 ` Xiao, QimaiX
  0 siblings, 2 replies; 6+ messages in thread
From: Wei Zhao @ 2019-04-28  6:13 UTC (permalink / raw)
  To: dev; +Cc: stable, qi.z.zhang, qimaix.xiao, yuan.peng, Wei Zhao

There is no need to do such a check of queue number, so remove it.

Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f0..5059bad 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12699,9 +12699,6 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		return -EINVAL;
 	}
 
-	if (rss_info->conf.queue_num)
-		return -EINVAL;
-
 	/* If both VMDQ and RSS enabled, not all of PF queues are configured.
 	 * It's necessary to calculate the actual PF queues that are configured.
 	 */
-- 
2.7.5

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number
  2019-04-28  6:13 [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number Wei Zhao
@ 2019-04-28  6:13 ` Wei Zhao
  2019-04-28  6:51 ` Xiao, QimaiX
  1 sibling, 0 replies; 6+ messages in thread
From: Wei Zhao @ 2019-04-28  6:13 UTC (permalink / raw)
  To: dev; +Cc: stable, qi.z.zhang, qimaix.xiao, yuan.peng, Wei Zhao

There is no need to do such a check of queue number, so remove it.

Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f0..5059bad 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12699,9 +12699,6 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		return -EINVAL;
 	}
 
-	if (rss_info->conf.queue_num)
-		return -EINVAL;
-
 	/* If both VMDQ and RSS enabled, not all of PF queues are configured.
 	 * It's necessary to calculate the actual PF queues that are configured.
 	 */
-- 
2.7.5


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number
  2019-04-28  6:13 [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number Wei Zhao
  2019-04-28  6:13 ` Wei Zhao
@ 2019-04-28  6:51 ` Xiao, QimaiX
  2019-04-28  6:51   ` Xiao, QimaiX
  2019-04-29 11:57   ` Zhang, Qi Z
  1 sibling, 2 replies; 6+ messages in thread
From: Xiao, QimaiX @ 2019-04-28  6:51 UTC (permalink / raw)
  To: Zhao1, Wei, dev; +Cc: stable, Zhang, Qi Z, Peng, Yuan

Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>

-----Original Message-----
From: Zhao1, Wei 
Sent: Sunday, April 28, 2019 2:13 PM
To: dev@dpdk.org
Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xiao, QimaiX <qimaix.xiao@intel.com>; Peng, Yuan <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/i40e: remove useless check for queue number

There is no need to do such a check of queue number, so remove it.

Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index dca61f0..5059bad 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12699,9 +12699,6 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		return -EINVAL;
 	}
 
-	if (rss_info->conf.queue_num)
-		return -EINVAL;
-
 	/* If both VMDQ and RSS enabled, not all of PF queues are configured.
 	 * It's necessary to calculate the actual PF queues that are configured.
 	 */
--
2.7.5

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number
  2019-04-28  6:51 ` Xiao, QimaiX
@ 2019-04-28  6:51   ` Xiao, QimaiX
  2019-04-29 11:57   ` Zhang, Qi Z
  1 sibling, 0 replies; 6+ messages in thread
From: Xiao, QimaiX @ 2019-04-28  6:51 UTC (permalink / raw)
  To: Zhao1, Wei, dev; +Cc: stable, Zhang, Qi Z, Peng, Yuan

Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>

-----Original Message-----
From: Zhao1, Wei 
Sent: Sunday, April 28, 2019 2:13 PM
To: dev@dpdk.org
Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xiao, QimaiX <qimaix.xiao@intel.com>; Peng, Yuan <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/i40e: remove useless check for queue number

There is no need to do such a check of queue number, so remove it.

Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index dca61f0..5059bad 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12699,9 +12699,6 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		return -EINVAL;
 	}
 
-	if (rss_info->conf.queue_num)
-		return -EINVAL;
-
 	/* If both VMDQ and RSS enabled, not all of PF queues are configured.
 	 * It's necessary to calculate the actual PF queues that are configured.
 	 */
--
2.7.5


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number
  2019-04-28  6:51 ` Xiao, QimaiX
  2019-04-28  6:51   ` Xiao, QimaiX
@ 2019-04-29 11:57   ` Zhang, Qi Z
  2019-04-29 11:57     ` Zhang, Qi Z
  1 sibling, 1 reply; 6+ messages in thread
From: Zhang, Qi Z @ 2019-04-29 11:57 UTC (permalink / raw)
  To: Xiao, QimaiX, Zhao1, Wei, dev; +Cc: stable, Peng, Yuan



> -----Original Message-----
> From: Xiao, QimaiX
> Sent: Sunday, April 28, 2019 2:51 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Peng, Yuan
> <yuan.peng@intel.com>
> Subject: RE: [PATCH] net/i40e: remove useless check for queue number
> 
> Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>
> 
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Sunday, April 28, 2019 2:13 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xiao, QimaiX
> <qimaix.xiao@intel.com>; Peng, Yuan <yuan.peng@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: remove useless check for queue number
> 
> There is no need to do such a check of queue number, so remove it.
> 
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number
  2019-04-29 11:57   ` Zhang, Qi Z
@ 2019-04-29 11:57     ` Zhang, Qi Z
  0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Qi Z @ 2019-04-29 11:57 UTC (permalink / raw)
  To: Xiao, QimaiX, Zhao1, Wei, dev; +Cc: stable, Peng, Yuan



> -----Original Message-----
> From: Xiao, QimaiX
> Sent: Sunday, April 28, 2019 2:51 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Peng, Yuan
> <yuan.peng@intel.com>
> Subject: RE: [PATCH] net/i40e: remove useless check for queue number
> 
> Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>
> 
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Sunday, April 28, 2019 2:13 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xiao, QimaiX
> <qimaix.xiao@intel.com>; Peng, Yuan <yuan.peng@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: remove useless check for queue number
> 
> There is no need to do such a check of queue number, so remove it.
> 
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-04-29 11:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-28  6:13 [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number Wei Zhao
2019-04-28  6:13 ` Wei Zhao
2019-04-28  6:51 ` Xiao, QimaiX
2019-04-28  6:51   ` Xiao, QimaiX
2019-04-29 11:57   ` Zhang, Qi Z
2019-04-29 11:57     ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).