* [dpdk-dev] [PATCH] ipc: handle more invalid parameter cases
@ 2019-04-29 13:59 Anatoly Burakov
2019-04-29 13:59 ` Anatoly Burakov
2019-05-03 15:07 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Anatoly Burakov @ 2019-04-29 13:59 UTC (permalink / raw)
To: dev; +Cc: keith.wiles, herakliusz.lipiec, stable
Length of buffer and number of fd's to send are signed values, so
they can be negative, but the API doesn't check for that. Fix it
by checking for negative values as well.
Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/common/eal_common_proc.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index b46d644b3..42df2b3bf 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -758,6 +758,18 @@ check_input(const struct rte_mp_msg *msg)
if (validate_action_name(msg->name))
return false;
+ if (msg->len_param < 0) {
+ RTE_LOG(ERR, EAL, "Message data length is negative\n");
+ rte_errno = EINVAL;
+ return false;
+ }
+
+ if (msg->num_fds < 0) {
+ RTE_LOG(ERR, EAL, "Number of fd's is negative\n");
+ rte_errno = EINVAL;
+ return false;
+ }
+
if (msg->len_param > RTE_MP_MAX_PARAM_LEN) {
RTE_LOG(ERR, EAL, "Message data is too long\n");
rte_errno = E2BIG;
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH] ipc: handle more invalid parameter cases
2019-04-29 13:59 [dpdk-dev] [PATCH] ipc: handle more invalid parameter cases Anatoly Burakov
@ 2019-04-29 13:59 ` Anatoly Burakov
2019-05-03 15:07 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Anatoly Burakov @ 2019-04-29 13:59 UTC (permalink / raw)
To: dev; +Cc: keith.wiles, herakliusz.lipiec, stable
Length of buffer and number of fd's to send are signed values, so
they can be negative, but the API doesn't check for that. Fix it
by checking for negative values as well.
Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/common/eal_common_proc.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index b46d644b3..42df2b3bf 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -758,6 +758,18 @@ check_input(const struct rte_mp_msg *msg)
if (validate_action_name(msg->name))
return false;
+ if (msg->len_param < 0) {
+ RTE_LOG(ERR, EAL, "Message data length is negative\n");
+ rte_errno = EINVAL;
+ return false;
+ }
+
+ if (msg->num_fds < 0) {
+ RTE_LOG(ERR, EAL, "Number of fd's is negative\n");
+ rte_errno = EINVAL;
+ return false;
+ }
+
if (msg->len_param > RTE_MP_MAX_PARAM_LEN) {
RTE_LOG(ERR, EAL, "Message data is too long\n");
rte_errno = E2BIG;
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] ipc: handle more invalid parameter cases
2019-04-29 13:59 [dpdk-dev] [PATCH] ipc: handle more invalid parameter cases Anatoly Burakov
2019-04-29 13:59 ` Anatoly Burakov
@ 2019-05-03 15:07 ` Thomas Monjalon
2019-05-03 15:07 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2019-05-03 15:07 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, keith.wiles, herakliusz.lipiec, stable
29/04/2019 15:59, Anatoly Burakov:
> Length of buffer and number of fd's to send are signed values, so
> they can be negative, but the API doesn't check for that. Fix it
> by checking for negative values as well.
>
> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] ipc: handle more invalid parameter cases
2019-05-03 15:07 ` Thomas Monjalon
@ 2019-05-03 15:07 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-05-03 15:07 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, keith.wiles, herakliusz.lipiec, stable
29/04/2019 15:59, Anatoly Burakov:
> Length of buffer and number of fd's to send are signed values, so
> they can be negative, but the API doesn't check for that. Fix it
> by checking for negative values as well.
>
> Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-03 15:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-29 13:59 [dpdk-dev] [PATCH] ipc: handle more invalid parameter cases Anatoly Burakov
2019-04-29 13:59 ` Anatoly Burakov
2019-05-03 15:07 ` Thomas Monjalon
2019-05-03 15:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).